- Issue created by @chrisfromredfin
- πΊπΈUnited States pfrilling Minster, OH
Attached is a patch that I started. Not entirely sure I'm on the right path. Would love some feedback and/or it can help someone else as a starting point.
- First commit to issue fork.
- πͺπΈSpain fjgarlin
It's defo a good beginning, I made it into an MR so we can continue there, give feedback, etc.
https://git.drupalcode.org/project/project_browser/-/merge_requests/651/... - πͺπΈSpain fjgarlin
I simplified a bit some of the cosmetic changes. I haven't tested anything yet so I don't know how close we are to a solution.
- πͺπΈSpain fjgarlin
β¨ Display warnings/errors from DrupalOrgJsonApi backend Active is ready for review and introduces a way to send error messages to the front-end which we may or may not use here, but I'd like validation of that approach before continuing here.
- πͺπΈSpain fjgarlin
As the related issue was just committed, doing this is very straightforward. Ready to test.
In order to test, we could, in `DrupalDotOrgJsonApi.php`, at line 144, add any of the following:
throw new Exception("Exception Test", 0);
throw new RequestException("RequestException Test", 1);
throw new GuzzleException("GuzzleException Test", 2);
Then this should show into the front-end.
-
chrisfromredfin β
committed c96da090 on 2.0.x authored by
fjgarlin β
Issue #3494818 by fjgarlin, chrisfromredfin, pfrilling, phenaproxima:...
-
chrisfromredfin β
committed c96da090 on 2.0.x authored by
fjgarlin β
- πΊπΈUnited States chrisfromredfin Portland, Maine
Wonderful work, y'all. This surfaced a follow-up about "caching" results, which include errors. But that's a bigger can of worms.
- πͺπΈSpain fjgarlin
The follow-up is this π Split results storage in keyValue per plugin instead of global Active
Automatically closed - issue fixed for 2 weeks with no activity.