- Merge request !182Issue #3267678: Replace Wrench icon on project views with Gear icon → (Merged) created by tim.plunkett
- Status changed to Needs work
about 1 year ago 12:34pm 18 October 2023 - 🇺🇸United States tishmg
My input on wrench vs. gear: a wrench icon to me implies heavy work, like under construction, vs. a gear, which seems to imply a smoothly running machine. The gear seems to be a better fit for actively maintained to me. A wrench would seem to apply that the module needs a lot of work.
- 🇺🇸United States dblanken Carmel, Indiana
I did not immediately get the impression that the gear or the wrench meant "maintained". I'm wondering if you can somehow convey it with a silhouette of a person to convey it's maintained by a person? Person with a hammer? Or the gear with a person silhouette inside?
- 🇺🇸United States MikeTullo
Hello! Just some UX two cents here. My initial thought with a gear icon is settings and with a shield icon is security. If we were to go in a different direction than these two I would suggest something with a person avatar that is either holding a tool or on a computer to indicate that there is a human maintaining this.
- 🇺🇸United States johnpicozzi Providence, RI
I'm going to be honest, I'm not sure if a wrench or a gear really matter. The larger issue is educating the user as to what the icons means. I have discussed not using a legend ( ✨ Improve iconography usability by adding a legend Needs work ) and adding a tool tip ( 🐛 Security and maintained icons need to communicate correct information Fixed ). I tend to agree that a wrench might be better than a gear based on the above comment of a gear being associated with settings.
- 🇦🇺Australia pameeela
I think this is a really, really hard thing to covey with an icon! It is interesting that there are people strongly in favour of both. I don't see either one as being very indicative, and agree with #25 that the icon itself probably won't achieve much either way.
Coming into this issue I did not know what the blue check icon meant either, but looking at PB I was able to determine from the filters that it means 'Covered by a security policy'. However, given that this is also a default filter, I am not sure the icon is a good idea? It will add clutter to the UI, considering that every module will have it by default. So I guess the use case is someone who selects 'Show all'?
I think it would probably be better to add an icon if it's *not* actively maintained, as this is something to alert users to. Otherwise, nothing to see here. And I see now this was already suggested in #2!
Screenshot of the filter for reference:
- Issue was unassigned.
- 🇸🇰Slovakia poker10
I am curious if we can check some d.o. statistics about "Maintenance status" and "Development status" in comparision with gitlab commits. It can be interesting to see how many modules are Actively maintained and/or Under active development and have no commits for a longer period (or similar).
I often see that these two values does not reflect the reality in many modules (would say that maintainers set them mostly when creating a module and then never update it). Certainly there are exceptions and lot of modules has this set correctly, but the question is if it does not get too much space, so that the module maintainers will be abusing this to get the "icon".
- 🇮🇳India narendraR Jaipur, India
Hi @Chris, while looking at the projects, I don't find
wrench icon
. Is this issue still relevant? - 🇺🇸United States chrisfromredfin Portland, Maine
I think we removed the wrench icon that used to be there because of this issue, and not wanting it to appear inside the filters (old UI) because it messed up responsiveness of the filters.
I do believe we need to re-introduce an icon for "well-maintained." I understand that most maintainers probably set it and forget it, but I think some of the point of project browser is to encourage maintainers to do more tending to their garden. So I am inclined to say we need to do the following:
1. re-introduce the old wrench icon (I do not agree that a gear is the right thing here, it's too easily confused with "configure" or "settings")
2. place the wrench icon on the cards for modules whose maintenance status matches our default filter (that is, you get the wrench if you are actively maintained or seeking co-maintainers or minimally maintained)
3. (this is already in a separate issue) introduce a legend to clearly explain what the icons mean, without relying on pulling down a filter, etc. see related ✨ Improve iconography usability by adding a legend Needs work I'll ask @tim.plunkett to change the target branch to 2.0.x as i don't have the permission of doing that and then maybe work on this to get it more refined.
Assigning it to Tim for above mentioned task.This still needs some CSS fixing as there is a difference in heights between the 2 icons.
Now the icons are of the same size as you can see in the attached screenshots.
This now has some work align to what @chrisfromredfin mentioned in #31 📌 Replace Wrench icon on project views with Gear icon Postponed .Marking it needs review.
- Status changed to Needs review
about 2 months ago 5:21am 4 November 2024 - 🇺🇸United States leslieg
After manaull testimg I can confirm that the wrench icon appear on the correct place on the card when the Project is maintained and does not display when the project is unsupported.
Needs a code review
- 🇮🇪Ireland lostcarpark
I've reviewed the code, and I've queried one thing. I think at present, a module will only showed the maintained icon if it is also covered by the security policy.
I've tried testing manually, but at present I'm only seeing data if I turn off the "maintained" filter, so I think there may be an issue with the back end at present, but because of this I wasn't seeing any "maintained" icons. I think this is a data issue rather than an application issue.
I have created a follow-up issue Include the wrench icon on the module's detail page ✨ Include the wrench icon on the module's detail page Active .
All the feedbacks are addressed and the test fails are not related to the changes in this MR, keeping the status as NR as this is blocking Improve iconography usability by adding a legend ✨ Improve iconography usability by adding a legend Needs work therefore also increasing the priority for this issue as both are Beta blockers.-
chrisfromredfin →
committed 62085846 on 2.0.x authored by
tim.plunkett →
Issue #3267678 by utkarsh_33, tim.plunkett, fjgarlin, bnjmnm, leslieg,...
-
chrisfromredfin →
committed 62085846 on 2.0.x authored by
tim.plunkett →
- 🇺🇸United States chrisfromredfin Portland, Maine
Thanks for the resurrection! This will unblock two more issues, so those are cleared to go now.
Automatically closed - issue fixed for 2 weeks with no activity.