Remove the clear button from the tab order

I wonder if tabindex="-1" would be good enough or would there be a better way.

Note: tabindex="-1" may be useful for elements that should not be navigated directly using the Tab key, but need to have keyboard focus set to them. Examples include an off-screen modal window that should be focused when it comes into view, or a form submission error message that should be immediately focused when an errant form is submitted.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabi...

After chatting with Mike Herchel about this. He recommended we get rid of the x altogether and use the standard HTML web search element instead of input.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/search

re #2: yes Scott o Hara is simply adding a tabbindex of -1 for excluding the element from the tab order.

re #3 problem going with the search element is that the clear button is then based on the browser and styling and behavior differs in between browsers. firefox for example doesnt have a clear button at all.

Yes, and standard search clear button then doesn't allow refreshing the results in a good way - see ✨ Ability to clear keyword/search filter with one click Needs work .

let's do the tabindex -1 approach.

kwiseman → changed the visibility of the branch 3444658-remove-the-clear to hidden.

confirmed pre-MR and post-MR that this fixes it. ship it!Will open a follow-up cuz I already merged before I realized this probably should have a test...

Added Portland2024 tag

Automatically closed - issue fixed for 2 weeks with no activity.