- Issue created by @alexpott
- First commit to issue fork.
- First commit to issue fork.
- @vasike opened merge request.
- Status changed to Needs review
7 months ago 10:42am 12 April 2024 - 🇺🇸United States sonfd Portland, ME
After review, noting that there are 2 final classes and 3 interfaces without the tag. I'm not really sure if we need it in these cases, but my guess is that we do want the @internal tag on the interfaces, but :shrug: idk re: final classes.
Final Classes:
Drupal\Core\Config\Action\Attribute\ConfigActionDrupal\Core\Config\Action\Plugin\ConfigAction\Deriver\PermissionsPerBundleDeriver
Interfaces:
Drupal\Core\Config\Action\ConfigActionPluginInterfaceDrupal\Core\Config\Checkpoint\CheckpointListInterfaceDrupal\Core\Config\Checkpoint\CheckpointStorageInterface
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@sonfd nice review! Yep we want it on everything inc final classes.
- Status changed to Needs work
7 months ago 9:27am 13 April 2024 - Status changed to Needs review
7 months ago 2:33pm 13 April 2024 - 🇺🇸United States sonfd Portland, ME
Added the internal tag to the noted final classes and interfaces.
-
alexpott →
committed 3dcbb5ce on 10.3.x
Issue #3439952 by vasike, sonfd, alexpott: Mark all non test classes and...
-
alexpott →
committed 3dcbb5ce on 10.3.x
-
alexpott →
committed bd913b60 on 11.x
Issue #3439952 by vasike, sonfd, alexpott: Mark all non test classes and...
-
alexpott →
committed bd913b60 on 11.x
- Status changed to Fixed
7 months ago 7:21am 14 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed bd913b60e42 to 11.x and 3dcbb5ce022 to 10.3.x. Thanks!
And merged to the core MR.
- 2a62dedb committed on patch
Update recipe 10.3.x patch 3dcbb5ce Issue #3439952 by vasike, sonfd,...
- 2a62dedb committed on patch
- c38065fb committed on patch
Update recipe 11.x patch bd913b60 Issue #3439952 by vasike, sonfd,...
- c38065fb committed on patch
Automatically closed - issue fixed for 2 weeks with no activity.