- Issue created by @anwar_max
- Assigned to sourav_paul
- Issue was unassigned.
- Status changed to Needs review
11 months ago 9:12am 13 September 2024 - ๐ฎ๐ณIndia sourav_paul Kolkata
I've checked the module code of 1.0.x-dev branch on D11.0.1.
This module is incompatible with drupal11.
I've made the module code compatible with D11.
please review...
attaching ss for reference:
Before:
After:
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Thanks for the patch. I don't think that
$typedConfigManager
should have theprotected
visibility indicator because it is declared as a property elsewhere. - ๐ฎ๐ณIndia atul_ghate
MR!2 is not applying as a patch for the 1.1.x branch. Could you please raise a merge request specifically against 1.1.x
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I don't think commit 7bf5ec7 is needed, but the other commit needs to be fixed like I said in #5.
- ๐ฎ๐ณIndia sourav_paul Kolkata
@liam morland I've resolved your feedback, could you please review & merge the MR..
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Because of the changes in the testing infrastructure, we'll need to do the
core_version_requirement
changes here so that tests can run. - Status changed to RTBC
8 months ago 7:50am 9 December 2024 - ๐ฎ๐ณIndia atul_ghate
I have reviewed and applied MR2. It resolved the mentioned issue, and we can now install this module on Drupal 11 without any errors. Changing the status to RTBC. See the attached video for reference.