- Merge request !263Resolve #2616184 Right click should not work on submit buttons with Ajax behaviors → (Closed) created by mpp
- Status changed to Needs work
about 2 years ago 11:55pm 30 January 2023 The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇧🇪Belgium tijsdeboeck Antwerp 🇧🇪 🇪🇺 🌎
Tested patch #110 against D9.5.4, and it works!
Also, I'm not sure the issue title is the most accurate. It's not that right-click shouldn't work on a button, but rather that it shouldn't submit or trigger AJAX. It's fine if it shows the context menu.
- Status changed to Needs review
about 2 years ago 9:56am 28 March 2023 - Status changed to Needs work
almost 2 years ago 3:01pm 4 April 2023 - 🇮🇳India sahil.goyal
- 🇮🇳India sahil.goyal
In my case patch is applying cleanly. will look more regard the issue of being failed to apply
- First commit to issue fork.
- 🇦🇺Australia VladimirAus Brisbane, Australia
Getting an error when trying to apply #118 and #121 to
10.1.x
error: patch failed: core/misc/ajax.js:391
Needs work.
- Status changed to Needs review
almost 2 years ago 4:11pm 12 April 2023 - 🇺🇸United States neclimdul Houston, TX
Drupal 9 problems where from 🐛 After using select to change plugin or region, element loses focus and page scrolls to bottom. Fixed where there was some new behaviors around the field_ui js that linked to the click trigger. the simple rerolls above where failing because they didn't update the new behavior.
Drupal 10 was a mess because of #3278415: Remove usages of the JavaScript ES6 build step, the build step itself, and associated dev dependencies → so manually re-applied all the javascript components and made a 10.x branch
This should all work now.
- Status changed to Needs work
almost 2 years ago 10:57am 13 April 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India nikhil_110
Attached patch against Drupal 10.1.x
Patch #125 is not applied for Drupal 10.1.x so Inter-diff file is not added.
Checking patch core/lib/Drupal/Core/Render/Element/RenderElement.php...
Hunk #1 succeeded at 278 (offset -1 lines).
Checking patch core/misc/ajax.js...
error: while searching for:
Drupal.Ajax = function (base, element, elementSettings) {
const defaults = {
type: 'POST',
event: element ? 'mousedown' : null,
keypress: true,
selector: base ? `#${base}` : null,
effect: 'none',error: patch failed: core/misc/ajax.js:399
error: core/misc/ajax.js: patch does not apply
Checking patch core/modules/field_ui/field_ui.js...
Checking patch core/modules/file/file.js...
Checking patch core/modules/media_library/src/MediaLibraryFieldWidgetOpener.php...
Checking patch core/modules/media_library/tests/src/FunctionalJavascript/WidgetAccessTest.php...
Checking patch core/modules/views_ui/js/ajax.js...
Checking patch core/modules/views_ui/js/views-admin.js...
Checking patch core/tests/Drupal/FunctionalJavascriptTests/Ajax/AjaxFormImageButtonTest.php...
Checking patch core/tests/Drupal/FunctionalJavascriptTests/Ajax/CommandsTest.php... - Status changed to Needs review
almost 2 years ago 10:09am 14 April 2023 - Status changed to Needs work
almost 2 years ago 1:27pm 14 April 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Merge request !3832Issue #2616184: Right click should not work on submit buttons with Ajax behaviors → (Closed) created by VladimirAus
- last update
almost 2 years ago 29,202 pass - last update
almost 2 years ago 29,202 pass - last update
almost 2 years ago Custom Commands Failed - Status changed to Needs review
almost 2 years ago 3:28pm 15 April 2023 - Status changed to Needs work
almost 2 years ago 3:19pm 19 April 2023 - Status changed to Needs review
almost 2 years ago 9:16pm 19 April 2023 - last update
almost 2 years ago 29,284 pass - 🇺🇸United States neclimdul Houston, TX
not sure what's going on in the patches or merge request. Might be missing what they're trying to accomplish but they don't seem to be addressing the CI failure. Here's the fix for the CI failure.
Also updated issue summary.
- Status changed to RTBC
almost 2 years ago 5:22pm 23 April 2023 - 🇺🇸United States smustgrave
Confirmed the issue described in the issue summary following the same steps.
Applying the patch fixes the issue.
Tested with a file and media library field.Ran tests locally and verified they fail as expected without the fix.
- last update
almost 2 years ago Patch Failed to Apply - Status changed to Needs work
almost 2 years ago 7:01am 24 April 2023 - last update
almost 2 years ago Custom Commands Failed - last update
almost 2 years ago Custom Commands Failed - last update
almost 2 years ago 29,305 pass - Status changed to Needs review
almost 2 years ago 9:51am 24 April 2023 - 🇺🇸United States neclimdul Houston, TX
📌 Add a "changes not applied until saved" warning when changing widget/formatter settings Fixed was what caused the "conflict" but skimming the changes it just looks to be near the field_ui.js changes from this and shouldn't affect anything. Re-roll looks good.
- Status changed to RTBC
almost 2 years ago 10:58pm 24 April 2023 - 🇺🇸United States smustgrave
Thanks @srishtiiee. For next time even with rerolls would be nice to include an interdiff or diff file please thanks!
- 🇺🇸United States neclimdul Houston, TX
When I re-rolled to confirm the patch I didn't get an interdiff. The changes where just close as noted in #142. That could have been clearer though.
- Status changed to Needs work
almost 2 years ago 7:12am 25 April 2023 - 🇫🇮Finland lauriii Finland
--- a/core/lib/Drupal/Core/Render/Element/RenderElement.php +++ b/core/lib/Drupal/Core/Render/Element/RenderElement.php @@ -279,25 +279,14 @@ public static function preRenderAjaxForm($element) { - // Pressing the ENTER key within a textfield triggers the click event of - // the form's first submit button. Triggering Ajax in this situation - // leads to problems, like breaking autocomplete textfields, so we bind - // to mousedown instead of click. - // @see https://www.drupal.org/node/216059
We need to carefully consider this change because it modifies the behavior of the feature. By no longer listening to the mousedown event, pressing enter on a text field may now trigger events that were not triggered before.
Although this change may not completely break autocomplete text fields, it definitely alters the behavior of some fields. It appears to have been documented as an undesirable side-effect.
I tested this change by adding a media field and another field with autocomplete to a content type. Autocomplete appears to be functioning as expected, but pressing enter on a text field now appears to try to make changes to the media field. When I reverted the patch and tried pressing enter again, nothing happened.
I don't think this side-effect is desired, or at least it hasn't been documented before.
- 🇺🇸United States neclimdul Houston, TX
For me that's part of the fix. I don't think you can currently submit a form with ctrl-enter which breaks standard form behaviors for keyboard users.
- Status changed to Needs review
over 1 year ago 9:41am 7 September 2023 - last update
over 1 year ago 29,472 pass - 🇧🇪Belgium jelle_s Antwerp, Belgium
Rerolled #140 against 10.1.x. There is no interdiff since the conflicting line wasn't part of the diff.
- last update
over 1 year ago 29,472 pass - Status changed to Needs work
over 1 year ago 5:08pm 8 September 2023 - 🇺🇸United States smustgrave
Patch does not apply to 11.x
error: core/modules/field_ui/field_ui.js: No such file or directory - Status changed to Needs review
over 1 year ago 5:11pm 11 September 2023 - last update
over 1 year ago 30,140 pass, 1 fail - 🇮🇳India vsujeetkumar Delhi
Addressed #149, Patch created, Please have a look.
The last submitted patch, 150: 2616184-150.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 3:26pm 18 December 2023 Updating title for clarity. Users should be able to right-click on a button and see the context menu; it just shouldn't submit/click the button.
- last update
about 1 year ago Patch Failed to Apply - 🇧🇾Belarus aylis
Tried to apply patch from #148 🐛 Right click should not submit buttons with Ajax behaviors Needs work to Drupal 10.2.1 and failed as composer "could not apply patch". Attached a patch for 10.2.x - hunks are the same, just line numbers changed.
- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 7:52pm 17 January 2024 - last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 8:48pm 17 January 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- Merge request !6219drupal-2616184: Right click should not work on submit buttons with Ajax behaviors. → (Open) created by shweta__sharma
- Status changed to Needs review
about 1 year ago 9:11am 18 January 2024 - Status changed to RTBC
about 1 year ago 12:37pm 22 January 2024 - 🇮🇳India Kanchan Bhogade
Hi,
I verified and tested the MR 6219 on the Drupal 11. x version.Testing steps:
Install the Drupal version 11. x and login as an admin user
Add File Field for Article content type with unlimited values
and check for the Remove button, able to reproduce the issue
Apply MR, and again check for the sameTest Result:
Now, when clicking the "Remove button" the file is not removed, showing the event handler.Attaching screenshots for reference
Moving to RTBC
- Status changed to Needs work
about 1 year ago 3:41am 19 February 2024 - 🇳🇿New Zealand quietone
I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions.
This is failing commit-code-checks, specifically spelling. Setting back to Needs work.
- 🇧🇪Belgium fernly
The patch in #155 🐛 Right click should not submit buttons with Ajax behaviors Needs work causes the following bug:
When using paragraphs and using the Modal in the widget to add new paragraphs, the modal closes "on click" when trying to hit a paragraph button to add. So before the button is clicked to trigger the ajax, the modal closes.
- 🇺🇸United States neclimdul Houston, TX
I haven't had any troubles with paragraphs but I suspect paragraphs is fighting with the mousedown behavior to work around core so there would need to be follow up I guess.
- Merge request !10589Issue #3483299-Right click should not submit buttons → (Closed) created by Unnamed author
- Status changed to Needs review
about 1 month ago 10:18pm 19 February 2025 - 🇫🇷France mably
Thanks @atul_ghate, your patch seems to be working fine.
Testing on Drupal 11.1.3.
- 🇨🇦Canada mgifford Ottawa, Ontario
Looks to me like it is merge-able now, least technically. Is anything else needed before RTBC?
- 🇺🇸United States smustgrave
The MR for 11.x is 1000+ commits back so that will need updating
@atul_ghate why did you open a new MR for 11.1 when the ticket is meant to point to 11.x?