Right click should not work on submit buttons with Ajax behaviors

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Tested patch #110 against D9.5.4, and it works!

#110 does not apply to Drupal 9.5.7

Also, I'm not sure the issue title is the most accurate. It's not that right-click shouldn't work on a button, but rather that it shouldn't submit or trigger AJAX. It's fine if it shows the context menu.

Reroll of #110.

#118 applies to 9.5.7 and works as intended.

Failure for 9.5.x appears to be valid.

fixing the Failure in #118 as it does not apply on D 10.1.x as some changes are not looks correct as per rerolled from #110 so attaching reroll to making it compatible with 10.1x.

In my case patch is applying cleanly. will look more regard the issue of being failed to apply

Getting an error when trying to apply #118 and #121 to 10.1.x

error: patch failed: core/misc/ajax.js:391

Needs work.

Drupal 9 problems where from 🐛 After using select to change plugin or region, element loses focus and page scrolls to bottom. Fixed where there was some new behaviors around the field_ui js that linked to the click trigger. the simple rerolls above where failing because they didn't update the new behavior.

Drupal 10 was a mess because of #3278415: Remove usages of the JavaScript ES6 build step, the build step itself, and associated dev dependencies → so manually re-applied all the javascript components and made a 10.x branch

This should all work now.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Attached patch against Drupal 10.1.x

Patch #125 is not applied for Drupal 10.1.x so Inter-diff file is not added.

Checking patch core/lib/Drupal/Core/Render/Element/RenderElement.php...
Hunk #1 succeeded at 278 (offset -1 lines).
Checking patch core/misc/ajax.js...
error: while searching for:
Drupal.Ajax = function (base, element, elementSettings) {
const defaults = {
type: 'POST',
event: element ? 'mousedown' : null,
keypress: true,
selector: base ? `#${base}` : null,
effect: 'none',

error: patch failed: core/misc/ajax.js:399
error: core/misc/ajax.js: patch does not apply
Checking patch core/modules/field_ui/field_ui.js...
Checking patch core/modules/file/file.js...
Checking patch core/modules/media_library/src/MediaLibraryFieldWidgetOpener.php...
Checking patch core/modules/media_library/tests/src/FunctionalJavascript/WidgetAccessTest.php...
Checking patch core/modules/views_ui/js/ajax.js...
Checking patch core/modules/views_ui/js/views-admin.js...
Checking patch core/tests/Drupal/FunctionalJavascriptTests/Ajax/AjaxFormImageButtonTest.php...
Checking patch core/tests/Drupal/FunctionalJavascriptTests/Ajax/CommandsTest.php...

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Switching to MR.

Summary need love

Per #133

not sure what's going on in the patches or merge request. Might be missing what they're trying to accomplish but they don't seem to be addressing the CI failure. Here's the fix for the CI failure.

Also updated issue summary.

Confirmed the issue described in the issue summary following the same steps.
Applying the patch fixes the issue.
Tested with a file and media library field.

Ran tests locally and verified they fail as expected without the fix.

Patch no longer applies 😞

Rerolled

📌 Add a "changes not applied until saved" warning when changing widget/formatter settings Fixed was what caused the "conflict" but skimming the changes it just looks to be near the field_ui.js changes from this and shouldn't affect anything. Re-roll looks good.

Thanks @srishtiiee. For next time even with rerolls would be nice to include an interdiff or diff file please thanks!

When I re-rolled to confirm the patch I didn't get an interdiff. The changes where just close as noted in #142. That could have been clearer though.

--- a/core/lib/Drupal/Core/Render/Element/RenderElement.php
+++ b/core/lib/Drupal/Core/Render/Element/RenderElement.php

@@ -279,25 +279,14 @@ public static function preRenderAjaxForm($element) {
-          // Pressing the ENTER key within a textfield triggers the click event of
-          // the form's first submit button. Triggering Ajax in this situation
-          // leads to problems, like breaking autocomplete textfields, so we bind
-          // to mousedown instead of click.
-          // @see https://www.drupal.org/node/216059

We need to carefully consider this change because it modifies the behavior of the feature. By no longer listening to the mousedown event, pressing enter on a text field may now trigger events that were not triggered before.

Although this change may not completely break autocomplete text fields, it definitely alters the behavior of some fields. It appears to have been documented as an undesirable side-effect.

I tested this change by adding a media field and another field with autocomplete to a content type. Autocomplete appears to be functioning as expected, but pressing enter on a text field now appears to try to make changes to the media field. When I reverted the patch and tried pressing enter again, nothing happened.

I don't think this side-effect is desired, or at least it hasn't been documented before.

For me that's part of the fix. I don't think you can currently submit a form with ctrl-enter which breaks standard form behaviors for keyboard users.

Rerolled #140 against 10.1.x. There is no interdiff since the conflicting line wasn't part of the diff.

Patch does not apply to 11.x
error: core/modules/field_ui/field_ui.js: No such file or directory

Addressed #149, Patch created, Please have a look.

The last submitted patch, 150: 2616184-150.patch, failed testing. View results →

Updating title for clarity. Users should be able to right-click on a button and see the context menu; it just shouldn't submit/click the button.

Tried to apply patch from #148 🐛 Right click should not submit buttons with Ajax behaviors Needs work to Drupal 10.2.1 and failed as composer "could not apply patch". Attached a patch for 10.2.x - hunks are the same, just line numbers changed.

Patch #150 applies to 10.2.1 and works

quick fix for style problems.

This should probably be using a MR against 11.x

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Created MR against 11.x

Hi,
I verified and tested the MR 6219 on the Drupal 11. x version.

Testing steps:

Install the Drupal version 11. x and login as an admin user
Add File Field for Article content type with unlimited values
and check for the Remove button, able to reproduce the issue
Apply MR, and again check for the same

Test Result:
Now, when clicking the "Remove button" the file is not removed, showing the event handler.

Attaching screenshots for reference

Moving to RTBC

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions.

This is failing commit-code-checks, specifically spelling. Setting back to Needs work.

The patch in #155 🐛 Right click should not submit buttons with Ajax behaviors Needs work causes the following bug:

When using paragraphs and using the Modal in the widget to add new paragraphs, the modal closes "on click" when trying to hit a paragraph button to add. So before the button is clicked to trigger the ajax, the modal closes.

I haven't had any troubles with paragraphs but I suspect paragraphs is fighting with the mousedown behavior to work around core so there would need to be follow up I guess.

Rerolled the patch for 10.3.x

Patch doesn't apply to newly released 11.1.0 :(

I will work on this issue.

Created MR for 11.1.x branch please review.

Thanks @atul_ghate, your patch seems to be working fine.

Testing on Drupal 11.1.3.

Looks to me like it is merge-able now, least technically. Is anything else needed before RTBC?

smustgrave → closed merge request !263

smustgrave → closed merge request !3832

smustgrave → closed merge request !10589

The MR for 11.x is 1000+ commits back so that will need updating

@atul_ghate why did you open a new MR for 11.1 when the ticket is meant to point to 11.x?

We are being hit by the side effects described in comment #145.

Media library fields are being submitted when users use the enter key on any fields of the form.

How could we fix that?

I suspect we need to fix media's buttons then. Without looking at the interface, I suspect they shouldn't be submit and just buttons since what your describing sounds like an interactive action, not a form submission.

What you're describing of triggering the first submit button is expected HTML behavior outlined in the HTML spec and I believe required by WCAG?

rebased. Doubt back porting to d7 tag means much now so removing.

@neclimdul even if you use '#type' => 'button' in your form, Drupal still generates an input of type submit.

It looks like simply switching from "mousedown" to "mouseup" could fix the accessibility problem (context menu available on right click) without being affected by the auto-click on submit browser behavior.

Rebased and slightly modified the original path disabling Ajax on right click.

It's not perfect on an a11y point of view, but doesn't seem to have any side effect and is better than nothing.