🇧🇪Belgium @tijsdeboeck

Merged!

Added usage + marked Flexible Table Of Contents as D7 only for easier comparison

I've created an MR with the alteration & a patch in case someone prefers that.

tijsdeboeck → created an issue.

We've tested this patch on a couple of our websites, and it works perfectly, in combination with google_tag 2.0.3.
We haven't had any issues with our D10.2.x sites, nor on the D9.5.x sites that haven't been upgraded.

tijsdeboeck → created an issue.

We can also confirm that this patch fixes the spam. We've applied it to 10 sites on Friday, and none received any spam over the weekend. We didn't see any other negative impact on legitimate form submissions, etc.

It would be great to have a new release with this patch as this is highly critical.

Seeing that multiple people confirmed this I'm marking this issue as RTBC.

My mailbox exploded Gitlab updates today! Thanks for your hard work Grevil & Anybody on getting this merged!

Hi all, I've just tested the MR4 diff on 2 projects (D10.2.1 + CK5), and got editor_file working without any issues.
Love to see it merged into a new release! Thanks a lot for the hard work!

I've made a small tweak so the code works for D10.

I agree with #5 about bumping it to Major, this issue broke important pages, including /admin/structure/types/add
The MR fixed the issue for us as well, thanks!!

Hi TR, I understand that core should support this, but it doesn't at the moment (in views at least), see #3112256 → .

Since it is very simple, doesn't create any issues for this module, and uuid comes with core, I thought it would be a good idea to add support here (at least until core supports it).

Simple fix, so merging it...

Fixed issue + added extra functionality to add all e-mails from the update settings and symfony mailer sources to array instead of replacing the array with emails from last checked source.

tijsdeboeck → created an issue.

I've added support for uuid field_type in the barcode field formatter. It is working for our use-case.

Quick tip: Since uuid doesn't have a default formatter at the moment, we found the uuid_extra → module very useful. It adds a regular formatter for UUID, so you can easily output the UUID as a regular uuid string, or as a barcode when using both modules.

tijsdeboeck → created an issue.

The previous MR version only stored the translated 'name' base field. Added support for custom fields in translations.

tijsdeboeck → made their first commit to this issue’s fork.

We've used patch #33 to fix asymmetric translations, works perfectly!

Is there a reason why EnvironmentIndicator.php isn't using the newly created VitalsExtraPlugin?

Re #4 &#5, it might be useful to add it in the readme, just in case someone isn't using Composer?

@alexharries, woops, thanks for spotting that - I've updated my comment.

Hi @alexharries, I've posted a comment on this in the cookies issue queue, maybe it helps you: https://www.drupal.org/project/cookies/issues/3364470#comment-15120948 ✨ Add GA4 snippet support in cookies_ga Fixed

We'll try to work on this soon, as we need to support this on multiple projects. As soon as we have something working we'll create an MR 👍

We can also confirm this behaviour. It's indeed a big issue under GDPR.

We were able to work around this by using cookies_gtag in combination with (COOKiES Google Tag Manager Consent)[ https://www.drupal.org/sandbox/gresko8/3267405] → (sandbox module). That allowed us to use Google Consent Mode through Tag Manager. Altough it's a sandbox module, it works perfectly for what we needed.

Maybe Cookies should look into only supporting google_tag 2.x for Cookies, as this is the recommended module for Google Analytics from now on... Maybe in combination with datalayer/consent mode support...

Done! This was surprisingly difficult 😆

I also missed subgroups. I combined Modules & Themes in an extensions group, for example. It would be logical to add subgroups for Modules, and Themes, to group their menu items.

Makes complete sense! I might have time to work on a new patch in the coming days...

I've tested the patch on Drupal 9.5.8 + commerce 2.35 - works like a charm! Marking it RTBC.

Anyone who has this working on D9/D10?

First of all, thanks for all the hard work! Having this in core would be amazing!

I like "Content links" as it conveys the message. The term "Content" is broad enough here to contain more than just nodes from an average content admin viewpoint.

Tested patch #110 against D9.5.4, and it works!

Re-rolled patch against Vitals 2.3

Any update? Would be great to have this merged... Thanks!

Any update on the status? We are looking to integrate with Dynamics as well, would be good to use and contribute to an existing project, instead of starting another project ;)

Marking this as RBTC, #49 is still working on Drupal Core 9.5.3 + Commerce 8.x-2.33

Patch #5 has been working perfectly on production for the past 6 months.

Hi @dunx, thanks for the follow-up and I totally get your point.

Hi @the_g_bomb & @seeduardo, thanks for your reactions!

We used to use drd_agent ourselves, but we wanted to have a more lightweight solution, a the ability to create our own custom dashboards. That's how discovered Vitals.

Have you tested Vitals recently or was that already a while ago? Since version 2.2.0 it uses plugins, which allows you to choose what you want to output, and allows you to easily create custom plugins (that's why we created the vitals_extra module).

The core Vitals module has plugins that can output the CMS version, PHP version, the active default and admin themes, and a list of security and regular updates (I've attached a screenshot of an example json output).

I've tested the dev version site_guardian, and I see that it outputs a lot more data which can be useful, but that could be achieved with a custom plugins for Vitals if you would interested in using Vitals as well.

I'm definitely not saying your module doesn't have a valid use-case, I am just trying to prevent the "yet another module that does almost the same" issue that Drupal suffers from 😆
I think it would be great that more people used and expanded modules like these, as that would create more secure and robust modules.

Btw, I really like the Site notes field in site_guardian! Do you mind that I create a custom plugin for this in our vitals_extra module? 😬

Feel free to close this issue if you want.

Thanks for the update. No worries ;)

Our offer to join as co-maintainers still stand if you are interested / can use the help.