- π§πͺBelgium tijsdeboeck Antwerp π§πͺ πͺπΊ π
Any update? Would be great to have this merged... Thanks!
- Status changed to Needs work
over 1 year ago 2:37am 12 March 2023 - πΊπΈUnited States rlhawk Seattle, Washington, United States
I like the idea of encrypting keys. Here are my thoughts:
- The dependencies would be more cleanly defined if the functionality were provided in a separate project rather than a submodule. It would also limit security issues to that project and would not affect Key. We may even want to expand this functionality to allow key values provided by any key provider to be encrypted.
- The encrypted key value should be base64-encoded, so that it can be better managed in configuration files, and more easily overridden (in settings.php, for instance).
- The key value should be obfuscated when editing the key, so it is never displayed in plaintext in the UI after it's been entered.
I will wait a few days for feedback and then create a new project for this feature and we can address the other bullet points in that project's issue queue.
- πΊπΈUnited States rlhawk Seattle, Washington, United States
@pookmish - I don't want to ignore your offer to create the project, so if you're still willing to do it, please go ahead. I think the name you've already given the module, "Key Encrypt", is a good name for it, especially if we end up using it for encrypting key values more broadly, not just in configuration.
- last update
about 1 year ago 8 pass - π§πͺBelgium tijsdeboeck Antwerp π§πͺ πͺπΊ π
I've made a small tweak so the code works for D10.
- Status changed to Needs review
4 months ago 7:11am 19 July 2024 - π§πͺBelgium tijsdeboeck Antwerp π§πͺ πͺπΊ π
@joseph.olstad, I've updated the core_version_requirement to match the parent module, this adds support for D11.
- Status changed to Postponed
21 days ago 3:08pm 25 October 2024 - π―π΅Japan ptmkenny
This MR will not be accepted as described in #24. Instead of updating the MR, a new module should be created.
- πΊπΈUnited States rlhawk Seattle, Washington, United States
I did create a module called Key Encrypt β , but it's currently empty. Let's bring this work over there.