🇺🇸United States @rlhawk

heatherwoz → credited rlhawk → .

chadhester → credited rlhawk → .

Thanks for the offer, @torfj. I have added you as a maintainer.

The default branch has been changed to 7.0.x. I cloned the repo to confirm.

Thanks. I've updated the project page.

Regarding the question of where this plugin should live: My inclination is to include it in Key. What do other modules that provide ECA actions do?

rlhawk → made their first commit to this issue’s fork.

smustgrave → credited rlhawk → .

Here are the steps that I performed to try to reproduce the issue you describe:

1. Added drupal/key, drupal/encrypt, and drupal/sodium to the project with Composer (using the command line)
2. Installed Key, Encrypt, and Sodium (using Drupal's UI)
3. Created an encryption key (using using Drupal's UI)
4. Created an encryption profile that uses the encryption key and the Sodium encryption method (using Drupal's UI)
5. Tested that encryption and decryption were successfully performed
6. Deleted the encryption profile (using Drupal's UI)
7. Uninstalled Sodium (using Drupal's UI)
8. Uninstalled Encrypt (using Drupal's UI)

I did not see the error that you describe. Please list the exact steps that need to be performed to reproduce the error.

I did create a module called Key Encrypt → , but it's currently empty. Let's bring this work over there.

Thanks! I made one change to update a parameter description to match others.

rlhawk → made their first commit to this issue’s fork.

rlhawk → made their first commit to this issue’s fork.

rlhawk → made their first commit to this issue’s fork.

This looks good, thanks!

I strongly support adding @ptmkenny as a maintainer. I've been impressed with his work on other modules that I maintain (Sodium, Encrypt, and Key), especially with improving test coverage.

liberatr → credited rlhawk → .

liberatr → credited rlhawk → .

I think this is a great idea. I suppose we just need to check if base_sizes is a string or an array. If it's a string, we consider it a number value; if it's an array, we assume it's a label–number value pair.

Great, thanks. The remaining issue to finalize looks good, so we're all set to go forward with the new version.

This looks good!

Looks good. Thanks!

rlhawk → made their first commit to this issue’s fork.

More specifically, I want to be mindful of the concerns and considerations Jakob Perry lists in this article:
https://medium.com/jakob-on-drupal/dont-go-making-major-version-changes-...

@ptmkenny Thanks for proposing this. I agree that it is appropriate to create a new branch. I'd like users to be able to update Sodium and Drupal core separately, which means having some overlap in dependencies between versions. I think that's the case with what you're proposing, but please confirm.

Since there were no objections, I've added @ptmkenny as a maintainer.

I addressed the issue with PHPStan and backward compatibility, but now PHP CodeSniffer tests are failing on files that didn't change.

I am in support of this proposal. Your help on issues for Encrypt and Key have been invaluable and I know you'll bring the same level of commitment and expertise to Sodium.

Well, it looks as though we'll have to wait to require PHPStan to pass until after we drop backward compatibility for earlier versions of Drupal. The code to ignore PHPStan errors related to setMethods() can either be in phpstan.neon or as @phpstan-ignore-next-line lines in EncryptionProfileTest.php. Either would be fine with me, though I suppose I have a slight preference for the latter, since removal of those ignore lines could then just be part of the removal of the backward-compatibility code to which it relates. Either way, once we have a new release that supports Drupal 11, it can be the last one compatible with D8 and D9, and we can begin the process of stripping out backward-compatibility.

This is great. Thank you, @ptmkenny. I love to see all that green in the pipelines.

rlhawk → made their first commit to this issue’s fork.

This is fantastic, thanks!

Done, thanks!

Outstanding. Thanks, everyone!

rlhawk → made their first commit to this issue’s fork.

It looks good, thanks!

smustgrave → credited rlhawk → .

Looks good, thanks.

rlhawk → made their first commit to this issue’s fork.

Yes, this is a partial duplicate of 🐛 Deprecated Function: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\key\Plugin\KeyType\EncryptionKeyType->validateKeyValue() (line 124 of modules/contrib/key/src/Plugin/KeyType/EncryptionKeyType.php) Fixed . Let's focus this issue on the Error: Call to a member function getKeyValue() on null part of it.

I reran the pipeline and it passed the test that failed.

Thanks for the patches. In 🐛 Deprecated Function: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\key\Plugin\KeyType\EncryptionKeyType->validateKeyValue() (line 124 of modules/contrib/key/src/Plugin/KeyType/EncryptionKeyType.php) Fixed , we added a check to make sure the parameter is a string, so I'm marking this as a duplicate.

Oof, you're right. That was my mistake. I'm not quite ready to drop support for versions of Drupal prior to 9.1, but I imagine we will do it fairly soon.

rlhawk → made their first commit to this issue’s fork.

rlhawk → made their first commit to this issue’s fork.

Thanks for this discussion.

I committed the issue to add Drupal 8 support and created a 2.6 release. We can follow up quickly with the three other issues mentioned by @ptmkenny.

I agree with keeping support for Drupal 8 and 9 until we're forced to drop it.

Committed, thanks!

Thanks for this. I'm hesitant to drop support for Drupal 8 only because of tests. If the module still works with D8, I'd like it to still be installable, even though tests can't be run.

Here's a reroll of the patch to add the test.

Support for Drupal 11 was added in 📌 Allow installation and testing with Drupal 11 Fixed . I'll leave this open for any additional automatic updates.

rlhawk → made their first commit to this issue’s fork.

Thanks. This has been merged.

I came across this also, but noticed that moving the Masquerade block above the Main Page Content block prevents the sidebar from disappearing, in case that helps with debugging.

Done!

@smustgrave - I absolutely support you as a co-maintainer. Thanks for offering!

I created a merge request, but I don't think we want to release a version of Key that claims to support Drupal 11. Can you use the Lenient Composer Endpoint ( https://www.drupal.org/docs/develop/using-composer/using-drupals-lenient... → ) to add the module with Drupal 11?

Thanks. I have updated the module description to remove references to Townsend Security's Alliance Key Manager.

This looks great. Thanks!

Closing this issue, since the module is deprecated and no longer supported.

Closing this issue, since the module is deprecated and no longer supported.

Closing this issue, since the module is deprecated and no longer supported.

Closing this issue, since the module is deprecated and no longer supported.

Closing this issue, since the module is deprecated and no longer supported.