- 🇯🇵Japan ptmkenny
I apply the patch against the 3-x-dev branch and ran a coding standards scan. Everything passed.
However, this kind of change is not a fix:
- * Class EncryptCommands. + * Class of EncryptCommands.
The warning for this is "The class short comment should describe what the class does and not simply repeat the class name."
Adding "of" here just removes the warning but doesn't solve the actual issue, which is to describe what the class actually does.
- Status changed to Needs review
about 2 years ago 1:59pm 6 February 2023 - 🇯🇵Japan ptmkenny
The MR (coding-standards) I added takes the patch in #2 and fixes the class descriptions as I pointed out in #3.
- 🇯🇵Japan ptmkenny
Now that the GitLab CI template has been committed, I merged in the latest changes, updated the MR to address the latest coding standards, and made the phpcs test mandatory in the template (because if the tests are passing now, we should keep them passing on future commits).
- 🇬🇧United Kingdom oily Greater London
@ptmkenny Is it best to wait for a maintainer to review your MR of will it help if I review it then if okay, change status to RTBC?
- 🇬🇧United Kingdom oily Greater London
I have tested MR4. I have run phpunit and phpcs tools on the MR using DDEV drupal contributions tool
All 16 PHPUnit tests passed and nothing was reported by the phpcs tool.
I am taking the liberty of changing the status to RTBC.
- Status changed to RTBC
7 months ago 9:33pm 8 September 2024 - 🇯🇵Japan ptmkenny
@andrew.farquharson Absolutely, you are welcome to set RTBC if you do a review. Thank you for reviewing!
- Status changed to Fixed
7 months ago 10:08pm 9 September 2024 - 🇬🇧United Kingdom oily Greater London
Hoping not to jump the gun, I am changing the status to fixed. I have added a commit with the --allow-empty flag to the MR. This is to seek credit for all 3 participants.
- Status changed to RTBC
7 months ago 11:34am 10 September 2024 - 🇯🇵Japan ptmkenny
Reverting to RTBC because this has not been committed yet; if confused, please see my explanation here: https://www.drupal.org/project/encrypt/issues/3460342#comment-15765744 🐛 The "default" form handler of the "encryption_profile" entity type specifies a non-existent class "Drupal\encrypt\Form\EncryptionProfileDefaultForm" RTBC
- First commit to issue fork.
- Status changed to Fixed
7 months ago 2:52pm 15 September 2024 - 🇺🇸United States rlhawk Seattle, Washington, United States
Outstanding. Thanks, everyone!
-
rlhawk →
committed f71937ad on 8.x-3.x authored by
ptmkenny →
Issue #3331525 by ptmkenny, andrew.farquharson, Vinni_Kadyan: Fix phpcs...
-
rlhawk →
committed f71937ad on 8.x-3.x authored by
ptmkenny →
Automatically closed - issue fixed for 2 weeks with no activity.