The "default" form handler of the "encryption_profile" entity type specifies a non-existent class "Drupal\encrypt\Form\EncryptionProfileDefaultForm"

andrew.farquharson → made their first commit to this issue’s fork.

It looks as though there is sufficient test coverage without the need for a new test. The 'encryption_profile' config entity type seems to enable CRUD without the need of the 'default' handler. As @adriancid states, there is no form corresponding with the handler so the handler and this one line of code seems to me to be redundant.

The example config entity in the 'Examples' project does not have a 'default' handler. It has the same as the remaining handlers in this project e.g. 'add', 'edit' 'delete'. So the Examples module would seem to set a sane baseline that, after this one line deletion, this module will adhere to.

Phpcs issues are not bugs and have already been fixed in 📌 Fix phpcs and make passing phpcs mandatory in GitLab CI Needs review . Please limit your fixes to the reported issue. It can be difficult to commit MRs when there are multiple MRs fixing the same issue, particularly if they do so in slightly different ways.

@ptmkenny Ah okay. I have been working on core issues and was told to fix phpcs errors by a maintainer. If that is not the correct approach in this project, do you want me to remove all my phpcs commits from the MR to leave only the one liner deletion that (I hope) closes the issue?

@andrew.farquharson Yes, please remove all phpcs changes from this MR. A one liner is fine if it fixes the problem described in the issue summary.

On Drupal.org, generally speaking, issues should only fix what is described in the issue summary and should not include additional fixes for phpcs, phpstan, and so on. If a core maintainer told you to fix the coding standards, I imagine that they meant to fix the phpcs issues in your MR (to avoid committing coding standards violations), not elsewhere in the code. Core is generally quite strict on issue scope.

There is no need to create a new issue for the phpcs changes because there is already an issue here: 📌 Fix phpcs and make passing phpcs mandatory in GitLab CI Needs review

@ptmkenny Thank you. That all makes sense. I will look at the phpcs issue, too.

This fix looks good to me-- as noted in #1 and #3, the form does not exist, so we should remove the reference.

@ptmkenny I hope I am getting this right. But it seemed correct (after I read some documentation about contributing on drupal.org) to change the status of this issue to 'fixed'. I also copied and used the commit message from the bottom of this page so as to credit all three persons involved in the fix. The commit was a git --no-update one. As the commit was a requirement of proper contribution but did not involve any code changes.

@andrew.farquharson After an issue is marked RTBC (Reviewed and tested by the community), then it can be committed, but only a module maintainer can commit to the module repository. So, we have to wait for a maintainer to review the MR and then, if the maintainer approves, commit the MR.

This is something only the maintainer can do; if anyone could commit to any module, Drupal would quickly be overrun by spam :(

So, until the maintainer makes a decision, this issue should stay as RTBC.

Hi @ptmkenny. Okay. The guide I read is a bit misleading (I may edit it). I will apply to be a maintainer if the fix takes a long time.

It looks good, thanks!

@rlhawk Thank you for the commit!

Automatically closed - issue fixed for 2 weeks with no activity.