- Issue created by @ptmkenny
- Status changed to Needs review
11 months ago 3:41pm 18 May 2024 - π―π΅Japan ptmkenny
This MR adds support for Drupal 11 and removes support for Drupal 8 + 9.
- Status changed to Needs work
10 months ago 4:52pm 1 June 2024 - π΅πΉPortugal jcnventura
Why needlessly remove support for Drupal 8 and 9? If there's any change that warrants dropping those versions, then by all means, drop them. But consider that there are about as many sites running D8 and D9 as those that run D10. Why drop support for half of the possible sites?
- Status changed to Needs review
10 months ago 8:43am 2 June 2024 - π―π΅Japan ptmkenny
Drupal 8 core has been out of support for over 2 years now, and Drupal 9 has been out of support since last year. Keeping support for 8 + 9 means that PHP 8 features can't be used. So I would move to drop support for unsupported core versions.
However, this is a decision for the maintainers, not me, so I've added another branch that keeps 8 + 9 support.
- π΅πΉPortugal jcnventura
When the point comes that this module wants to support PHP 8, it can certainly do so, and if that breaks the support for Drupal 8 and 9, so be it. I don't think that a separate branch to support unsupported versions is needed. What I'm saying is that the change here to add support to Drupal 11 is not doing any change that would break the support for Drupal 8 and 9, so removing that seems unnecessary.
Note that Drupal 9 also supported PHP 8, and it is very likely that there are Drupal 8 sites out there also running on PHP 8. The module can certainly require PHP 8 or above on it's own by specifying that requirement in the composer.json.
- π―π΅Japan ptmkenny
@jcventura Ok, you have persuaded me. I closed the MR dropping 8/9 support and opened a new one that only adds support for D11.
- Status changed to RTBC
10 months ago 2:12pm 22 June 2024 - πΊπΈUnited States rlhawk Seattle, Washington, United States
I agree with keeping support for Drupal 8 and 9 until we're forced to drop it.
-
rlhawk β
committed 5ba9ad00 on 8.x-2.x authored by
ptmkenny β
Issue #3448016 by ptmkenny: Support Drupal 11
-
rlhawk β
committed 5ba9ad00 on 8.x-2.x authored by
ptmkenny β
- Status changed to Fixed
10 months ago 2:33am 23 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.