- Issue created by @ptmkenny
- Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.0 & MySQL 5.7
28:22 28:22 Queueing - last update
6 months ago Composer require failure - Status changed to Needs review
6 months ago 2:18am 19 May 2024 - π―π΅Japan ptmkenny
I updated the tests and removed support for Drupal 8 since PHPUnit 10 requires Drupal 9 at a minimum.
- πΊπΈUnited States rlhawk Seattle, Washington, United States
Thanks for this. I'm hesitant to drop support for Drupal 8 only because of tests. If the module still works with D8, I'd like it to still be installable, even though tests can't be run.
- last update
6 months ago Composer require failure - last update
5 months ago 8 fail - last update
5 months ago 8 fail - last update
5 months ago 8 fail - last update
5 months ago Composer require failure - last update
5 months ago 8 fail - Status changed to Needs work
5 months ago 1:11am 7 July 2024 - π―π΅Japan ptmkenny
Automated tests are failing so setting to "Needs work".
- π΅πΉPortugal jcnventura
At this moment, and since this is only changing the tests directory, removing support for D8 and D9 would not be entirely justified.
There's still about 170K sites out there running D8 and D9, and maybe they can't upgrade to the next major for some reason, but could keep up with this module. - Status changed to Needs review
2 months ago 2:16pm 18 September 2024 - π―π΅Japan ptmkenny
Ok, tests are now green, so I'm setting to "Needs Review."
- Status changed to Needs work
2 months ago 2:30pm 18 September 2024 - π΅πΉPortugal jcnventura
Test modules should not have a
core_version_requirement
as long as they are inpackage: Testing
. See https://www.drupal.org/node/3070687#test β - Status changed to Needs review
2 months ago 2:33pm 18 September 2024 - Status changed to RTBC
2 months ago 2:39pm 18 September 2024 - π΅πΉPortugal jcnventura
Taking into account the fact that rector didn't find anything else to be fixed (https://dev.acquia.com/drupal11/deprecation_status/projects/encrypt) and that this only changes tests, and they are now passing, I think this can be merged.
Marking RTBC even if I was the last one committing, since my change was really minor.
- πΊπΈUnited States rlhawk Seattle, Washington, United States
This is fantastic, thanks!
-
rlhawk β
committed b9176b2f on 8.x-3.x authored by
ptmkenny β
Issue #3448070 by ptmkenny, jcnventura, rlhawk: Add support for Drupal...
-
rlhawk β
committed b9176b2f on 8.x-3.x authored by
ptmkenny β
Automatically closed - issue fixed for 2 weeks with no activity.