Theme hook commerce_giftcard_redemption_form not found

Patch #5 has been working perfectly on production for the past 6 months.

New version of the patch in #3, Drupal 10 compatible

Created a MR fron #8, thank you all!

The improvements in #5 were lost. #5 was already Drupal 10 compatible. #8 should not have been committed.

@rhovland thanks for the feedback and sorry for being too fast. Sorry I didn't see that -.-

The module is still in alpha, so no worries to change things and implement the additional fixes from #5. Could you prepare a MR?

I'll reopen this!

So I started making a patch for this and stopped realizing that how this is implemented is probably entirely wrong. Most panes are composed of fieldsets with titles that are generated by drupal. Meanwhile this pane uses a theme template to display the pane title which will not match the other panes if the site theme is different than the default. For example, my patch uses an H5 tag, but the other one is a H3. Which one is correct? Most panes don't even have templates. They just create a form using the API.

I will spend some more time evaluating how other panes are built and build a new MR that addresses these concerns.

Closing this in favor of followup issues.

✨ Display the gift card balance on the redemption form Active
📌 Checkout pane language cleanup Active
✨ Gift card pane display only looks correct in the sidebar Active

Automatically closed - issue fixed for 2 weeks with no activity.