- Issue created by @kopeboy
- 🇨🇦Canada mandclu
No real reason to exclude other options, they just hadn't been priorities when I created the module. The main irritants for me were the default menu and the display of author and date. Adding the publishing options probably wouldn't be a lot of work. If you want to take a stab at an MR, I will definitely consider it.
- 🇮🇹Italy kopeboy Milan
I've never made a drupal module MR on Gitlab so I'm not sure I can do it soon (I was just reviewing modules to make some fresh recipes for site builders), but I can try!
- First commit to issue fork.
- Merge request !2Issue #3454936: Added configurations for default publishing options. → (Merged) created by manish-31
- Status changed to Needs review
6 months ago 5:11pm 17 June 2024 - 🇮🇳India manish-31
@kopeboy I have raised MR to add configuration to configure default publishing options. Please review.
Not adding
hook_update()
for new configs as we have default case handled in code already. - Status changed to RTBC
5 months ago 7:57am 7 August 2024 - 🇮🇳India atul_ghate
The MR2 has been applied successfully, and the requested configuration option has been added cleanly. Everything looks good to me.
To reproduce the issue, I followed these steps:
1.Cloned the 1.0.x version of the module.
2.Installed and configured the module.
3.Created a new "news" content type and checked if its configuration options are working correctly after applying MR2.
4.Verified that the modules work both without the MR2 changes and with the MR2 applied.I'm changing its status to RTBC.
- Status changed to Active
2 months ago 10:12am 23 October 2024 - 🇮🇳India atul_ghate
Hi @kopeboy, if MR2 works well, we can change the status to RTBC instead of Active, as per the Drupal contribution guidelines.
-
mandclu →
committed a5b9b4ec on 1.0.x authored by
manish-31 →
Issue #3454936 by manish-31: Add Publishing Options configuration
-
mandclu →
committed a5b9b4ec on 1.0.x authored by
manish-31 →
- 🇨🇦Canada mandclu
Merged in, and I will incorporate into a new release shortly. Thanks for everyone's work here!
Automatically closed - issue fixed for 2 weeks with no activity.