- Issue created by @jan kellermann
- 🇩🇪Germany jan kellermann
jan kellermann → changed the visibility of the branch 3493742-decode-xml to hidden.
- 🇩🇪Germany jan kellermann
I want to fix the bug not to mitigate the wrong output (btw: I would fix the output here).
The double encoding occurs because the title is loaded directly from the XML (and not from the project array) and is encoded in the XML.
I have created an MR that decodes the title directly when processing the XML (3493742-11.x-decode-xml-correct).
- 🇺🇸United States smustgrave
Appears to have pipeline issues.
But should have test coverage too.
- 🇩🇪Germany jan kellermann
@smustgrave how can we simulate a xml from the Drupal server? Should we create a dummy contrib module with „&“ in their title for testing?
- 🇺🇸United States smustgrave
There may already be one in the upgrade module. Also believe in some of the tests they are hardcoding the xml maybe that would be easier.
- 🇩🇪Germany jan kellermann
jan kellermann → changed the visibility of the branch 11.x to hidden.
- 🇩🇪Germany jan kellermann
I added tests in MR!10571. I also added a branch with test only to see it fail in MR!10579.
Please review. Thank you.
- 🇺🇸United States smustgrave
You can close the test only branch. Pipelines has a test only feature for that
- 🇩🇪Germany jan kellermann
jan kellermann → changed the visibility of the branch 3493742-11.x-decode-xml-correct-test-only to hidden.
- 🇩🇪Germany jan kellermann
@smustgrave Thank you! I did not know. I just started the test.
I am not allowed to close MRs or delete branches :)
- 🇳🇿New Zealand quietone
The is a duplicate of an issue that got moved to the Project project.
There is a test, so removing tag. The MR also has out of scope changes, but that is minor to deciding what the solution should be here.