Double encoded ampersand in /admin/reports/updates

I will work on this issue.

jan kellermann → changed the visibility of the branch 3493742-decode-xml to hidden.

I want to fix the bug not to mitigate the wrong output (btw: I would fix the output here).

The double encoding occurs because the title is loaded directly from the XML (and not from the project array) and is encoded in the XML.

I have created an MR that decodes the title directly when processing the XML (3493742-11.x-decode-xml-correct).

smustgrave → closed merge request !10568

Appears to have pipeline issues.

But should have test coverage too.

@smustgrave how can we simulate a xml from the Drupal server? Should we create a dummy contrib module with „&“ in their title for testing?

There may already be one in the upgrade module. Also believe in some of the tests they are hardcoding the xml maybe that would be easier.

jan kellermann → changed the visibility of the branch 11.x to hidden.

I added tests in MR!10571. I also added a branch with test only to see it fail in MR!10579.

Please review. Thank you.

You can close the test only branch. Pipelines has a test only feature for that

jan kellermann → changed the visibility of the branch 3493742-11.x-decode-xml-correct-test-only to hidden.

@smustgrave Thank you! I did not know. I just started the test.

I am not allowed to close MRs or delete branches :)

Just some small comments on the MR.

The is a duplicate of an issue that got moved to the Project project.

There is a test, so removing tag. The MR also has out of scope changes, but that is minor to deciding what the solution should be here.

Thanks for this bug report, and for the work to try to fix it. Per #19, this issue is duplicate with 🐛 Module names on the Available Updates page are double-escaped Needs review , which started doing much the same thing here, but then ended up moving to another queue since the problem is really in the XML release history feeds provided by updates.drupal.org, not the update.module itself. I just replied there in support of fixing this at u.d.o, not in update.module. Let's continue in the original issue. If it turns out we have to fix this only in update.module, we can move that issue back into the core queue.

Thanks again!
-Derek

Update for folks following this issue: the release history XML has now been rebuilt to no longer double-encode project titles. So this issue is now fixed for all versions of core. 🎉

quietone → closed merge request !10571

@dww, thanks for commenting here. I am glad this have been fixed!