Contrib.social

Automated Drupal 11 compatibility fixes for colorbox_media_video

Open on Drupal.org →
Created on 16 March 2024, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment over 1 year ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-120835

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !5Automated Project Update Bot fixes → (Open) created by project update bot
  • Status changed to RTBC 9 months ago
  • Comment 9 months ago →
    🇺🇸United States johnpicozzi Providence, RI

    This change is simple enough and the patch applies cleanly. I'm moving this to RTBC and suggest a release is tagged.

  • Comment 5 months ago →
    🇨🇦Canada danrod Ottawa

    This worked fine and dandy, attached a screenshot below, can we have a release sometime soon, if possible?

  • Comment 4 months ago →
    🇺🇸United States bsufan17

    Will we get this released soon?

  • Comment about 1 month ago →
    🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺

    It would be great to this merged to be able to switch to Drupal 11

  • Comment 27 days ago →
    🇺🇸United States mark_fullmer Tucson

    Joining the chorus -- a new release would be wonderful, given that it is 1 year since Drupal 11 was released. Per the current proposed guidelines at 🌱 Guidelines for semantic versioning and Drupal core support Active , it is acceptable to provide new compatibility for Drupal core versions with a patch-level release, so this release could simply go from 2.0.2 to 2.0.3.

  • Comment 27 days ago →
    🇨🇦Canada danrod Ottawa

    I'm guessing we have to create a github repo and host the D11 project there and then add the repo in your local <code>composer.json file

  • Comment 26 days ago →
    🇺🇸United States johnpicozzi Providence, RI

    I would suggest someone here follow these steps → to take over this project. Hosting a Drupal 11 version of this on GitHub is not the best idea as it's outside of the Drupal Security and Regulatory ecosystem.

  • Comment 25 days ago →
    🇨🇦Canada danrod Ottawa

    Thanks @johnpicozzi , will try these steps

  • Comment 20 days ago →
    🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺

    Just for information we encountered an issue on Drupal 11 where isFunction is undefined.

    THe following code crashes:
    $.isFunction($.colorbox)

    I believe the latest version of JQuery that comes with Drupal 11 doesn't have isFunction anymore.

  • Comment 20 days ago →
    🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺

    That's the patch I used in addition if somebody has the same issue.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024