Make it possible to override custom fields when embedding media in CKEditor

Open on Drupal.org →

Created on 30 April 2020, over 4 years ago

Updated 21 June 2023, over 1 year ago

We're using the core media library and core embed button with ckeditor. Unfortunately after an image is embedded from the media library the "edit" button only allows editing the alt tag, not the custom fields that are part of our image media items (such as caption, attribution).

If we edit the image from the media library we see all of the fields that we want to edit.

Also I notice the contrib media embed button does allow this functionality, but the core one does not.

To explain another way:

When I add an image to a content area using ckeditor the image embeds fine, but there's no option to edit anything about the image except the alt tag.

1) I insert an image into a wysiwyg field using the core embed button:
The image shows up in the editor and has an edit button next to it:

Clicking the edit button does not go to the edit screen to edit all image fields but instead goes to an abbreviated edit that only includes the alt tag.

It does not even show the name of the image so that I can search for it in the media library :/

If instead I find the image in the media library and edit it from there (using the small pencil icon) ...

I can edit all of the important image fields like caption, copyright year, media source, and more.

Also, I notice the contrib module "Media Entity Embed" doesn't have this problem, does allow accessing and editing these extra fields. (clicking on the selected entity link goes to the full image media edit screen as shown in Screenshot 3 above) .

Is there a way to edit image media entities from the wysiwyg editor? Thanks to anyone who can help!

✨ Feature request

Status

Active

Version

11.0 🔥

Component

Last updated about 12 hours ago

Maintained by
🇳🇱Netherlands @seanB
🇩🇪Germany @chr.fritsch
🇺🇸United States @phenaproxima
🇪🇸Spain @marcoscano

Created by

🇺🇸United States plato1123

Live updates comments and jobs are added and updated live.

Media Initiative

Triaged Media Initiative issue

ckeditor

Usability
Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇷🇴Romania claudiu.cristea Arad 🇷🇴
I think, at least, we should allows 3rd-party to hook in and alter the cloned media entity. Then MediaEmbed::applyPerEmbedMediaOverrides() looks like a good place from where to dispatch an event, so that listeners are able to change the cloned media, overriding the way is rendered.
Comment over 1 year ago →
🇷🇴Romania claudiu.cristea Arad 🇷🇴
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Custom Commands Failed
@claudiucristea opened merge request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,374 pass
Comment over 1 year ago →
🇨🇦Canada b_sharpe
To edit from inside ckeditor, you're likely going to need 🐛 Drupal.ckeditor5.openDialog missing existingValues param Needs work
Comment over 1 year ago →
🇺🇸United States cgmonroe
FYI - This is already possible using the form alter hook. I added how to do this to the Embedding Media With CKEditor documents a couple of years ago. See:

https://www.drupal.org/docs/core-modules-and-themes/core-modules/media-library-module/embedding-media-with-ckeditor-4#s-customizing-the-edit-embedded-media-form →

Haven't tried it yet, but don't see why this will not work for CKEditor 5 as well.

Perhaps the focus of this issue should be to add tests to ensure that code using this method does not break.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024