🇮🇳India @chandu7929

chandu7929 → changed the visibility of the branch project-update-bot-only to hidden.

chandu7929 → made their first commit to this issue’s fork.

chandu7929 → changed the visibility of the branch 3449149-drupal-11-release to active.

Before creating this issue I have ran test locally by including other related issue changes like type_data Drupal 11 branch and then reported failure in this ticket. Its not that I have randomly posted issue here, please check its parent 📌 Drupal 11 compatibility fixes for rules Needs work issue for more details.

No, this patch does not make Rules compatible with D11, and does break Rules for lower versions of Drupal. Some of the changes are unexplained and IMO wrong, and none of the issues in the summary are addressed.

1. I don't see any test failure on lower version of Drupal with this changes considering this CI → is passing for lower version, let me know what's breaking on lower version.
2. Regarding un unexplained changes: There are following two test which are failing on D10.3 and hence those changes are made
   

   1) Drupal\Tests\rules\Functional\ActionsFormTest::testActionsFormWidgets with data set "3. List item add" ('rules_list_item_add', array('node.uid.entity.roles', '1'), array(true, 'start'))
   Behat\Mink\Exception\DriverException: Textual and file form fields don't support array or boolean values.
   2) Drupal\Tests\rules\Functional\ActionsFormTest::testActionsFormWidgets with data set "12. Entity save" ('rules_entity_save', array('node'), array(true))
   Behat\Mink\Exception\DriverException: Textual and file form fields don't support array or boolean values.
   

3. Regarding issue summary: I have only committed those changes which are required to make this module compatible with D11 and rest are tagged as separate issue as suggested in the this issue (Don't commit unrelated changes here)

If this is to be a tracking issue for D11 compatibility, then things should NOT be fixed piecemeal here. Don't just throw a bunch of unrelated changes into a patch. A new issue should be open for each change, and the patches in those issues should not contain out-of-scope changes, and those issues should be linked here. There should be no patches here in this tracking issue.

I do agree with you on this point. The only changes I have done here to fix other D10.3 test failure which I can revert if you want.

This is part of the reason I closed the issue - I don't want to have to maintain a tracking issue and have to keep asking people to open new issues for each problem. And I don't want to have to keep trying to untangle dozens of patches for dozens of different things all posted here under "D11 Compatibility".

Yes! I have followed the same approach by creating separate issue unrelated to this ticket.

Actual D11 compatibility requires some structural changes, like turning on matrix testing with GitLab CI, porting the dependencies (typed_data), dropping D9 support, moving to semantic versioning for D10+, determining the lowest version of D10 that can be supported with these changes (see the original post where some of these changes only work for >D10.3), and yes addressing some of the deprecations.

I think we already have issues for things like turning on matrix testing with GitLab CI, dropping D9 support, moving to semantic versioning for D10+ etc and its been tagged here. Additionally I have also run the tests locally on Drupal 11 by including these issues fixes to see the remaining task and accordingly created separate issue specially for test failure(#3455432: Fix failing tests for Drupal 11).

With respect to Drupal 11 compatibility, I don't see any other pending issues that are not already reported and tagged here.

Thanks @vishalkhode I have updated the MR with requested changes, please take a look.

Ran test locally on Drupal 10.3 (included commit) and all tests are passing, created separate issue #3455432: Fix failing tests for Drupal 11, hence requesting review.

chandu7929 → created an issue.

Reviewed MR #52 and changes looks good to me, hence RTBC.

@ankitv18 - I can see issue when enabling this module on Drupal 11.

PHP Fatal error:  Declaration of Drupal\jsonapi_extras\Normalizer\JsonApiNormalizerDecoratorBase::supportsNormalization($data, $format = null): bool must be compatible with Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool in /Users/chandan.singh/Sites/D11/web/modules/contrib/jsonapi_extras/src/Normalizer/JsonApiNormalizerDecoratorBase.php on line 58

Fatal error: Declaration of Drupal\jsonapi_extras\Normalizer\JsonApiNormalizerDecoratorBase::supportsNormalization($data, $format = null): bool must be compatible with Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool in /Users/chandan.singh/Sites/D11/web/modules/contrib/jsonapi_extras/src/Normalizer/JsonApiNormalizerDecoratorBase.php on line 58
 [warning] Drush command terminated abnormally.

I ran tests locally and can see the following error:

There were 124 errors:

1) Drupal\Tests\rules\Functional\ActionsFormTest::testActionsFormWidgets with data set "3. List item add" ('rules_list_item_add', array('node.uid.entity.roles', '1'), array(true, 'start'))
Behat\Mink\Exception\DriverException: Textual and file form fields don't support array or boolean values.

/Users/chandan.singh/Sites/acquia_cms/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:427
/Users/chandan.singh/Sites/acquia_cms/vendor/behat/mink/src/Element/NodeElement.php:118
/Users/chandan.singh/Sites/acquia_cms/vendor/behat/mink/src/Element/TraversableElement.php:166
/Users/chandan.singh/Sites/acquia_cms/docroot/modules/contrib/rules/tests/src/Functional/RulesBrowserTestBase.php:97
/Users/chandan.singh/Sites/acquia_cms/docroot/modules/contrib/rules/tests/src/Functional/ActionsFormTest.php:134
/Users/chandan.singh/Sites/acquia_cms/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

2) Drupal\Tests\rules\Functional\ActionsFormTest::testActionsFormWidgets with data set "12. Entity save" ('rules_entity_save', array('node'), array(true))
Behat\Mink\Exception\DriverException: Textual and file form fields don't support array or boolean values.

/Users/chandan.singh/Sites/acquia_cms/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:427
/Users/chandan.singh/Sites/acquia_cms/vendor/behat/mink/src/Element/NodeElement.php:118
/Users/chandan.singh/Sites/acquia_cms/vendor/behat/mink/src/Element/TraversableElement.php:166
/Users/chandan.singh/Sites/acquia_cms/docroot/modules/contrib/rules/tests/src/Functional/RulesBrowserTestBase.php:97
/Users/chandan.singh/Sites/acquia_cms/docroot/modules/contrib/rules/tests/src/Functional/ActionsFormTest.php:134
/Users/chandan.singh/Sites/acquia_cms/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

3) Drupal\Tests\rules\FunctionalJavascript\EventBundleTest::testEventBundleSelection
RuntimeException: Unable to complete AJAX request.

/Users/chandan.singh/Sites/acquia_cms/docroot/core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php:117
/Users/chandan.singh/Sites/acquia_cms/docroot/core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php:38
/Users/chandan.singh/Sites/acquia_cms/docroot/modules/contrib/rules/tests/src/FunctionalJavascript/EventBundleTest.php:62
/Users/chandan.singh/Sites/acquia_cms/vendor/phpunit/phpunit/src/Framework/TestResult.php:729

4) Drupal\Tests\rules\Unit\Integration\Condition\EntityHasFieldTest::testConditionEvaluation
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "plugin.manager.field.field_type_category".

For issue: You have requested a non-existent service "plugin.manager.field.field_type_category". tagging the related issue.

I am re-opening this issue to keep track of the progress of D11 readiness work. I will also tag the related issue here so that we can work on the remaining deprecations.

Changes looks good to me, hence RTBC.

Latest status:

I can see multiple issue while running test with major version:

1. Devel module is not compatible with D11 and causes requirement issue, refer issue: https://gitlab.com/drupalspoons/devel/-/issues/527
2. Using module with _LENIENT_ALLOW_LIST, it adds modules initial version for given requirement which causes different issue, for example if you check rules module its downloading(3.0.0-alpha1) version and gives error like:
   The 'core_version_requirement' key must be present in modules/contrib/rules/rules.info.yml

We should revisit this issue once we have D11 compatible release for rules and devel module at least.

@vishal for the point you have raised:

• Regarding #15: There is a separate issue with https://www.drupal.org/project/scheduler/issues/3359998 📌 SchedulerDrushTest fails on Gitlab-CI but OK on drupal.org Active .
• Regarding update of DataProvider: I have update all the dataProvider method for each tests static method.

chandu7929 → changed the visibility of the branch project-update-bot-only to hidden.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Hence pushed changes in separate branch to fix failing tests.

@vishalkhode - The test you have mentioned are not being run in current CI, hence I have created separate MR and will update CI accordingly to fix all the test failure in minor as well as major version of Drupal

chandu7929 → changed the visibility of the branch 3434325-automated-drupal-11 to active.

Changes looks good to me, hence RTBC.

The overall change in MR #19 looks good to me since this will drop support for D8 and D9; hence, let's wait for the maintainer's response on this.

@vishalkhode - I have remove those changes since its already covered here https://www.drupal.org/project/honeypot/issues/3450488 📌 PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest' Needs review

The header asserts in the test cases are being addressed by #3450488: PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest'

Verified MR 46 change and its look good to me, hence RTBC.

@mishradeepak1991 - I verified MR 46 and can see following deprecations hence needs work.

modules/contrib/default_content/tests/src/Kernel/ExporterIntegrationTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      26   Usage of deprecated trait                                   
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class 
                    Drupal\Tests\default_content\Kernel\ExporterIntegrationTest.
                    Deprecated in drupal:10.2.0 and is removed from             
                    drupal:11.0.0. Use                                          
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait 
                    instead.                                                    
--------------------------------------------------------------------------------

FILE:
modules/contrib/default_content/tests/src/Kernel/MenuLinkContentNormalizerTest.p
hp

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      19   Usage of deprecated trait                                   
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class 
                    Drupal\Tests\default_content\Kernel\MenuLinkContentNormalize
                    rTest. Deprecated in drupal:10.2.0 and is removed from      
                    drupal:11.0.0. Use                                          
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait 
                    instead.                                                    
--------------------------------------------------------------------------------

FILE:
modules/contrib/default_content/tests/src/Kernel/ParagraphNormalizerTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      24   Usage of deprecated trait                                   
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class 
                    Drupal\Tests\default_content\Kernel\ParagraphNormalizerTest.
                    Deprecated in drupal:10.2.0 and is removed from             
                    drupal:11.0.0. Use                                          
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait 
                    instead.                                                    
--------------------------------------------------------------------------------

FILE:
modules/contrib/default_content/tests/src/Kernel/TranslationNormalizerTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      19   Usage of deprecated trait                                   
                    Drupal\Tests\field\Traits\EntityReferenceTestTrait in class 
                    Drupal\Tests\default_content\Kernel\TranslationormalizerTest
                    . Deprecated in drupal:10.2.0 and is removed from           
                    drupal:11.0.0. Use                                          
                    Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait 
                    instead.                                                    
--------------------------------------------------------------------------------

@deepakkm - I verified MR 16 and can see following deprecations, hence needs work.

================================================================================
Embed, --
Scanned on Wed, 06/05/2024 - 06:23

FILE: modules/contrib/embed/src/Form/EmbedButtonForm.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 117  Call to deprecated function watchdog_exception(). Deprecated
                    in drupal:10.1.0 and is removed from drupal:11.0.0. Use Use 
                    Drupal\Core\Utility\Error::logException() instead.          
--------------------------------------------------------------------------------

FILE: modules/contrib/embed/tests/src/Unit/DomHelperTraitTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 35   Missing call to parent::setUp() method.                     
--------------------------------------------------------------------------------

Thanks @jonathan1055, I have updated MR with deprecation fix reported in #7 hence moving back in review.

Thanks @TR, I ran the scan again today and I don't those issue reported in #7 hence moving in review.

================================================================================
Honeypot, --
Scanned on Mon, 06/03/2024 - 13:29

No known issues found.

I ran tests locally and can see 272 error with same message: "Undefined array key "commerce_product"

Time: 07:47.584, Memory: 28.00 MB

There were 272 errors:

1) Drupal\Tests\scheduler_rules_integration\Functional\SchedulerRulesActionsTest::testPublishOnActions with data set "#node" ('node', 'testpage')
Undefined array key "commerce_product"

Running command ./vendor/bin/drush upgrade_status:analyze scheduler I can see following issue, which need to be fixed.

================================================================================
Scheduler, --
Scanned on Fri, 05/31/2024 - 13:02

FILE: modules/contrib/scheduler/src/SchedulerManager.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix now        930  Call to deprecated method loadRevision() of class           
                    Drupal\Core\Entity\EntityStorageInterface. Deprecated in    
                    drupal:10.1.0 and is removed from drupal:11.0.0. Use        
                    Drupal\Core\Entity\RevisionableStorageInterface::loadRevisio
                    n instead.                                                  
--------------------------------------------------------------------------------

FILE: modules/contrib/scheduler/scheduler.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^8 || ^9 || ^10 is not   
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE:
modules/contrib/scheduler/scheduler_rules_integration/scheduler_rules_integratio
n.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^8 || ^9 || ^10 is not   
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Ran command ./vendor/bin/drush upgrade_status:analyze jsonapi_extras I can see below status which can be ignored.

================================================================================
JSON:API Extras, --
Scanned on Fri, 05/31/2024 - 12:30

FILE:
modules/contrib/jsonapi_extras/modules/jsonapi_defaults/src/Controller/EntityRes
ource.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 29   Class Drupal\jsonapi_defaults\Controller\EntityResource     
                    extends @internal class                                     
                    Drupal\jsonapi\Controller\EntityResource.                   
--------------------------------------------------------------------------------

FILE:
modules/contrib/jsonapi_extras/src-impostor-normalizers/ResourceIdentifierNormal
izerImpostor.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 10   Class                                                       
                    Drupal\jsonapi\Normalizer\ImpostorFrom\jsonapi_extras\Resour
                    ceIdentifierNormalizerImpostor extends @internal class      
                    Drupal\jsonapi_extras\Normalizer\ResourceIdentifierNormalize
                    r.                                                          
--------------------------------------------------------------------------------

FILE:
modules/contrib/jsonapi_extras/src-impostor-normalizers/ResourceObjectNormalizer
Impostor.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 10   Class                                                       
                    Drupal\jsonapi\Normalizer\ImpostorFrom\jsonapi_extras\Resour
                    ceObjectNormalizerImpostor extends @internal class          
                    Drupal\jsonapi_extras\Normalizer\ResourceObjectNormalizer.  
--------------------------------------------------------------------------------

FILE:
modules/contrib/jsonapi_extras/src/ResourceType/ConfigurableResourceType.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 15   Class                                                       
                    Drupal\jsonapi_extras\ResourceType\ConfigurableResourceType 
                    extends @internal class                                     
                    Drupal\jsonapi\ResourceType\ResourceType.                   
--------------------------------------------------------------------------------

FILE:
modules/contrib/jsonapi_extras/src/ResourceType/ConfigurableResourceTypeReposito
ry.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 15   Class                                                       
                    Drupal\jsonapi_extras\ResourceType\ConfigurableResourceTypeR
                    epository extends @internal class                           
                    Drupal\jsonapi\ResourceType\ResourceTypeRepository.         
--------------------------------------------------------------------------------

Since all tests are passing hence requesting review.

chandu7929 → made their first commit to this issue’s fork.

Running command ./vendor/bin/drush upgrade_status:analyze honeypot give following status which can be ignored, because its false positive contact/feedback-formis not a library.

================================================================================
Honeypot, --
Scanned on Fri, 05/31/2024 - 08:21

FILE: modules/contrib/honeypot/tests/src/Functional/HoneypotFormTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 304  The 'contact/feedback-form' library is not defined because  
                    the defining extension is not installed. Cannot decide if it
                    is deprecated or not.                                       
--------------------------------------------------------------------------------

FILE: modules/contrib/honeypot/tests/src/Functional/HoneypotFormCacheTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 93   The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------
Check manually 96   The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------
Check manually 103  The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------
Check manually 105  The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------
Check manually 110  The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------

Regarding the the remaining test failure see MR:https://git.drupalcode.org/project/rules/-/merge_requests/26/diffs

chandu7929 → made their first commit to this issue’s fork.

Since all tests are passing hence requesting review.

chandu7929 → created an issue.

chandu7929 → changed the visibility of the branch project-update-bot-only to active.

chandu7929 → changed the visibility of the branch project-update-bot-only to hidden.

chandu7929 → created an issue.

chandu7929 → created an issue.

Verified locally all looks good to me.

chandu7929 → made their first commit to this issue’s fork.

chandu7929 → changed the visibility of the branch 3434417-automated-drupal-11 to hidden.

chandu7929 → changed the visibility of the branch project-update-bot-only to active.

chandu7929 → changed the visibility of the branch project-update-bot-only to hidden.

Now, test with D10 as well as D11 passing, hence requesting review.

Running command ./vendor/bin/drush upgrade_status:analyze seckit I can see following issues:

================================================================================
Security Kit, --
Scanned on Tue, 05/14/2024 - 11:44

FILE: modules/contrib/seckit/tests/src/Functional/SecKitTestCaseTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 66   Call to deprecated method getConfig() of interface          
                    GuzzleHttp\ClientInterface: ClientInterface::getConfig will 
                    be removed in guzzlehttp/guzzle:8.0.                        
--------------------------------------------------------------------------------

FILE: modules/contrib/seckit/seckit.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 4    Value of core_version_requirement: ^9.3 || ^10 is not       
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

We need to rebase with 8.x-1.x since the failing tests have already been fixed here.

I have created MR with required changes, hence requesting review.

Thank you, @darvanen. I have run a scan against the dev branch, and there is only one issue being reported by the upgrade_status module. Also, I have updated the issue descriptions.

chandu7929 → created an issue.

Update MR to fix Drupal 11 compatibility issue, hence requesting review.

chandu7929 → made their first commit to this issue’s fork.

chandu7929 → created an issue.

Hello kelly.m.jacobs I was trying to replicate the issue and followed the steps below.

1. Enable module google_tag & term_condition
2. Created terms under tags vocab [abc, xyz]
3. Created content type [abc] and added taxonomy reference field then selected tags as source.
4. Create two content of type abc and tagged abc, xyz respectively.
5. Placed recent content block and add condition to show on abc tags
6. Verified GTM inclusion and its there.

Is there specific steps where this condition is interfering?

@deepakkm - I don't see the use of a canonical url in the case of the workbench_email module, and hence, providing a route for something that has no use doesn't make sense. Also, Drupal Core already does the fallback to edit-form if a canonical URL is not present; hence, removing the canonical would make more sense in this case.

chandu7929 → made their first commit to this issue’s fork.

chandu7929 → made their first commit to this issue’s fork.

chandu7929 → created an issue.

chandu7929 → made their first commit to this issue’s fork.

Use following patches to patch the module:

"drupal/acquia_cms_site_studio": {
                "3421068- Update aborted by: acquia_cms_site_studio_update_8008": "https://www.drupal.org/files/issues/2024-02-13/acquia_cms_site_studio_update_8008.patch"
            },
            "acquia/cohesion": {
                "3421068- Update aborted by: cohesion_update_8705": "https://www.drupal.org/files/issues/2024-02-13/cohesion_update_8705.patch"
            }

chandu7929 → created an issue.

Verified with patch #4, its working fine.

Drupal 10 compatible release is available now, Hence closing.

Dropping support for D10 in 1.x branch and will create 2.x branch with Drupal 10 support.

chandu7929 → created an issue.

@gbyte, we have in-house CI which runs on multiple versions of PHP and its failing for one our our job which is configured to run with PHP 7.4, I think we should add minimum php support version in the release.

chandu7929 → created an issue.

chandu7929 → created an issue.

chandu7929 → made their first commit to this issue’s fork.

Hi @ jonathan1055 when can we expect this to be released? This is breaking our site installation.

chandu7929 → created an issue.

Will check separatly for D10.1.x

This is caused by third party module, hence closing this one. As its working expected.