Align Acquia DAM assets embedding options with Drupal core Media embed filter in text editors

I agree with Jura, it is confusing that for media types the user can select the view mode from the CKEditor, but for DAM images they need to select the image style.

I have added a patch that comments out some of the Acquia DAM code to:
- Add the view modes back
- Remove the CKEditor plugin
- Remove the step to select format when adding DAM images

That way media types images and dam images behave the same way. I don't fully understand all the code I have commented out, but it looks like it is working just fine without it.

vadim.hirbu → made their first commit to this issue’s fork.

Thank you for the update Vadim Hirbu, do you think we should keep the image style dropdown? It is very confusing having both presented to the user, when media types only display the view modes.

Also now all the images from drupal have the "Embed Code" text displaying in ckeditor which shouldn't be the case since it has no options, I getting rid of it will be better so there is alignment with core media.

Hi Ok4p1
I think we should keep all that image style dropdown and keep all functionality added by core media.

Ok, but at least "Embed Code" should not be displayed for the core media images, since that was introduced by acquia dam, right now it is visible in both.

This patch helped me a lot, but with version 1.0.23 it didn't work. It was necessary to rebase the patch.

chandu7929 → changed the visibility of the branch 3381934-align-acquia-dam to hidden.

chandu7929 → changed the visibility of the branch 3381934-hide-embed-code to hidden.

After the merge request has been merged, I cannot see any major difference between how the dropdown list works for an embedded image:

@jura.khrapunov → / @ok4p1 → / @vadim.hirbu → could any of you please update the issue description with a proper list of steps for reproduction? Otherwise, it's hard to tell the issue status until it's unclear what the exact expectations were. Thanks in advance!

After the merge request has been merged, I cannot see any major difference between how the dropdown list works for an embedded image (not counting the last option with ling name which was added in a separate MR):

@jura.khrapunov → / @ok4p1 → / @vadim.hirbu → could any of you please update the issue description with a proper list of steps for reproduction? Otherwise, it's hard to tell the issue status until it's unclear what the exact expectations were. Thanks in advance!

The update applies specifically to Drupal Media, not to Acquia DAM media assets. As shown in the attached file, the Embed Code option is currently visible for Drupal media, whereas it should not be.

Without this fix:

With this fix:

The solution provided here has been merged into both development branches, therefore I think we can close this ticket as Fixed.