- Issue created by @jura.khrapunov
- ๐ฌ๐งUnited Kingdom Ok4p1 Glasgow
I agree with Jura, it is confusing that for media types the user can select the view mode from the CKEditor, but for DAM images they need to select the image style.
I have added a patch that comments out some of the Acquia DAM code to:
- Add the view modes back
- Remove the CKEditor plugin
- Remove the step to select format when adding DAM imagesThat way media types images and dam images behave the same way. I don't fully understand all the code I have commented out, but it looks like it is working just fine without it.
- ๐ฒ๐ฉMoldova vadim.hirbu
vadim.hirbu โ made their first commit to this issueโs fork.
- Merge request !31#3381934 โ Fix Acquia DAM rewrites of view modes on Embedded Media โ (Open) created by vadim.hirbu
- last update
10 months ago Composer require-dev failure - ๐ฌ๐งUnited Kingdom Ok4p1 Glasgow
Thank you for the update Vadim Hirbu, do you think we should keep the image style dropdown? It is very confusing having both presented to the user, when media types only display the view modes.
Also now all the images from drupal have the "Embed Code" text displaying in ckeditor which shouldn't be the case since it has no options, I getting rid of it will be better so there is alignment with core media.
- ๐ฒ๐ฉMoldova vadim.hirbu
Hi Ok4p1
I think we should keep all that image style dropdown and keep all functionality added by core media. - ๐ฌ๐งUnited Kingdom Ok4p1 Glasgow
Ok, but at least "Embed Code" should not be displayed for the core media images, since that was introduced by acquia dam, right now it is visible in both.
This patch helped me a lot, but with version 1.0.23 it didn't work. It was necessary to rebase the patch.
- First commit to issue fork.
- First commit to issue fork.
- Merge request !81#3381934 โ Remove embed code from inapplicable media โ (Open) created by chandu7929
- ๐ฎ๐ณIndia chandu7929 Pune
chandu7929 โ changed the visibility of the branch 3381934-align-acquia-dam to hidden.
- ๐ฎ๐ณIndia chandu7929 Pune
chandu7929 โ changed the visibility of the branch 3381934-hide-embed-code to hidden.