Hello, the patch mitigates the issue but I am still experiencing it
If anyone else faces this issue, my problem was the syntax used to disable the field programmatically so users could not change the default value (something that worked with 1.2.11).
Breaks: $form['field_page_type']['widget']['#attributes'] = ['disabled' => 'disabled'];
Works: $form['field_page_type']['widget']['#attributes']['disabled'] = 'disabled';
Apologies, I wasn't able to replicate it either on a clean install, so it must be something about my codebase :(
Hello, thank you for getting back to me. The part I don't get is that this is not a custom element, it is just an entity reference referencing a taxonomy term. Shouldn't that work out-of-the-box without having to customize it, like it did on 1.2.11?
I tried with 1.2.18 and the issue is still there.
Hello, are you planning to make this work with groups 3.x? I tried the patch but got the following error, thanks.
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "group_content" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of core/lib/Drupal/Core/Entity/EntityTypeManager.php).
Same thing, #175 works for me but #176 is still showing up untranslated menu items.
Ok, but at least "Embed Code" should not be displayed for the core media images, since that was introduced by acquia dam, right now it is visible in both.
Thank you for the update Vadim Hirbu, do you think we should keep the image style dropdown? It is very confusing having both presented to the user, when media types only display the view modes.
Also now all the images from drupal have the "Embed Code" text displaying in ckeditor which shouldn't be the case since it has no options, I getting rid of it will be better so there is alignment with core media.
I agree with Jura, it is confusing that for media types the user can select the view mode from the CKEditor, but for DAM images they need to select the image style.
I have added a patch that comments out some of the Acquia DAM code to:
- Add the view modes back
- Remove the CKEditor plugin
- Remove the step to select format when adding DAM images
That way media types images and dam images behave the same way. I don't fully understand all the code I have commented out, but it looks like it is working just fine without it.
Ignore my last message, I was on the mobile phone and missed the link from the description :)
@justmeplease would you mind sharing your fork? Thank you.
I am also experiencing this issue
Never mind, the modal closes now fine with the latest update of the acquia cms modules.
Using the patch I no longer get the error but the modal window does not close when I select "Insert selected" (even though the image is selected correctly).