Drupal.editors.ckeditor5.onChange event has outdated data when user types too fast.

This is a regression introduced by 🐛 CKEditor5 doens't save updated value if form submitted right after the change Active 😭

Let's get the (detailed, thank you!) steps to reproduce encoded in the core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5Test.php test coverage that #3396742 expanded. We should be able to reproduce the failure in there.

Reproduced easily without Site Studio, just by using a Drupal core text field. Rephrased the issue summary for that. This does not negatively impact Drupal core today, but impacts potentially many contrib modules.

if debounce method is called with callback and delay only then it works perfectly.

Hi @ankitv18
Did you provide patch for this since this branch looks empty?

MR!8284 opened agaisnt 10.2.x branch, if this fix resolve the issue then we can push the commit to the 11.x branch too.

11.x was correct target for the MR as a fix will have to land there first. I do see comment #8 but fix will have to pass 11.x too.

Tagging for issue summary as proposed solution appears to be missing. This a UI issue? If so can we add before/after there.

Also appears to be tagged for tests which may still be needed. Though with regressions (especially data loss) I'm a +1 for fixing and opening a follow up for expanding test coverage. But I can't make those calls.

Adding the change from the MR as a patch so we can kick off some tests against this.

Hello, the patch mitigates the issue but I am still experiencing it

I wonder if we could just get rid of debounce to fix this. (I pushed MR!10265 with that change)
Before the 🐛 CKEditor5 doens't save updated value if form submitted right after the change Active it worked just like without debounce, but with a 400ms delay for each call as mentioned in the issue summary there.

And IMO it just makes more sense, that onChange should be called on each change immediately, and if the user/contrib code needs to throttle that, it is their responsibility, and they will be able to decide how much they want to throttle it.

Issue summary still appears to need updating. Recommend using standard issue template.

Was previously tagged for tests but not sure what those would look like

I expanded the \Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5Test::testSave to check the behaviour of the onChange event. The test assumes there will be no debounce/throttling from this method.
Updated the IS
Back to "Needs review".

smustgrave → closed merge request !8284

1) Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5Test::testSave
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 [
     0 => '<p>c</p>',
-    1 => '<p>ch</p>',
-    2 => '<p>cha</p>',
-    3 => '<p>chan</p>',
-    4 => '<p>chang</p>',
-    5 => '<p>change</p>',
 ]
/builds/issu

Test change looks good and summary is correct so removing those tags.

Following the steps am seeing the issue and MR does appear to addressed.