- Issue created by @jessebaker
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This is a regression introduced by 🐛 CKEditor5 doens't save updated value if form submitted right after the change Active 😭
Let's get the (detailed, thank you!) steps to reproduce encoded in the
core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5Test.phptest coverage that #3396742 expanded. We should be able to reproduce the failure in there.Reproduced easily without Site Studio, just by using a Drupal core text field. Rephrased the issue summary for that. This does not negatively impact Drupal core today, but impacts potentially many contrib modules.
- First commit to issue fork.
- 🇮🇳India ankitv18
if debounce method is called with callback and delay only then it works perfectly.
- 🇷🇸Serbia rakun
Hi @ankitv18
Did you provide patch for this since this branch looks empty? - Merge request !8284Issue #3425568 by mstrelan: Block attribute class expecting wrong ContextDefinition → (Open) created by ankitv18
- 🇮🇳India ankitv18
MR!8284 opened agaisnt 10.2.x branch, if this fix resolve the issue then we can push the commit to the 11.x branch too.
- Status changed to Needs review
6 months ago 12:54pm 4 June 2024 - Status changed to Needs work
6 months ago 2:58pm 4 June 2024 - 🇺🇸United States smustgrave
11.x was correct target for the MR as a fix will have to land there first. I do see comment #8 but fix will have to pass 11.x too.
Tagging for issue summary as proposed solution appears to be missing. This a UI issue? If so can we add before/after there.
Also appears to be tagged for tests which may still be needed. Though with regressions (especially data loss) I'm a +1 for fixing and opening a follow up for expanding test coverage. But I can't make those calls.
- 🇬🇧United Kingdom 8ballsteve
Adding the change from the MR as a patch so we can kick off some tests against this.
- 🇬🇧United Kingdom Ok4p1 Glasgow
Hello, the patch mitigates the issue but I am still experiencing it
- First commit to issue fork.
- Merge request !10265Issue #3443422: [regression] Drupal.editors.ckeditor5.onChange event doesn't... → (Open) created by reinfate
I wonder if we could just get rid of debounce to fix this. (I pushed MR!10265 with that change)
Before the 🐛 CKEditor5 doens't save updated value if form submitted right after the change Active it worked just like without debounce, but with a 400ms delay for each call as mentioned in the issue summary there.And IMO it just makes more sense, that onChange should be called on each change immediately, and if the user/contrib code needs to throttle that, it is their responsibility, and they will be able to decide how much they want to throttle it.
