- Issue created by @vishalkhode
- Merge request !42Resolve #3515234 "Migration dashboard enhancement." โ (Merged) created by rajeshreeputra
- First commit to issue fork.
- ๐ฎ๐ณIndia chandu7929 Pune
Updated MR with required changes, hence requesting review.
- ๐ฎ๐ณIndia ankitv18
Please add a hook_update_N to by default enable the Acquia DAM module so that user can see the migration dashboard fully functional.
- ๐ฎ๐ณIndia chandu7929 Pune
Since all requested changes are done, hence requesting review.
- ๐บ๐ธUnited States japerry KVUO
Need to continue reviewing code, but marking NW due to the following:
Enable Acquia DAM and Media: Acquia DAM
1) Add a few items to the Media: Acquia DAM image type
2) Add a few items to the Acquia DAM image type
3) Run the migration toolYou'll notice that it suggests deleting the Acquia DAM: Image type, which contains existing data! Also, the media type labels are greyed out. The ones that come with Acquia DAM should be editable alongside the old Media: Acquia DAM types so you can get a full picture of the all the media types and their names.
- ๐ฎ๐ณIndia chandu7929 Pune
@japerry - Thank you for highlighting first point; we will take it into consideration for inclusion. However, regarding your second point,
Also, the media type labels are greyed out. The ones that come with Acquia DAM should be editable alongside the old Media: Acquia DAM types so you can get a full picture of the all the media types and their names.
What is the reasoning behind permitting updates to the media labels of the new media type provided by the Acquia DAM module, despite the apparent logic in offering label modification options for the older media types?
- ๐บ๐ธUnited States japerry KVUO
The media types that ship with Acquia DAM are fairly generic, so say you have a site with multiple image types due to permissions, download/sync, or another edge case that requires per media type delineation. You may then want to change the media type labels to reflect what they're used for, including the default one.
- ๐ฎ๐ณIndia chandu7929 Pune
Incorporated requested changes, hence requesting review.
- ๐บ๐ธUnited States japerry KVUO
Verified locally that indeed a test is failing: https://git.drupalcode.org/issue/media_acquiadam-3515234/-/jobs/5062463
Failed asserting that the text of the element identified by '[data-drupal-selector="edit-media-label"] li:nth-child(2)' equals 'Acquia DAM Image โ Media: Acquia DAM Image'.
Failed asserting that two strings are equal.
Expected :'Acquia DAM Image โ Media: Acquia DAM Image'
Actual :'Acquia DAM Video โ Media: Acquia DAM Image'My guess is that the order is different on older versions of Drupal? nevertheless, we should have this fixed before committing.
-
japerry โ
committed f692755f on 2.x authored by
rajeshreeputra โ
Issue #3515234 by chandu7929, rajeshreeputra, ankitv18, vishalkhode:...
-
japerry โ
committed f692755f on 2.x authored by
rajeshreeputra โ