Automated Drupal 11 compatibility fixes for quickedit

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

The last submitted patch, 2: quickedit.1.0.3.rector.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

VladimirAus → changed the visibility of the branch 3434080-automated-drupal-11 to hidden.

ankitv18 → changed the visibility of the branch 3434080-automated-drupal-11 to active.

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

@ankitv18 why would you remove upgrade status ci pipeline?
Also, phpstan pipelines need more love.

Basically upgrade_status reports same as phpstan so it's ideal to avoid running extra jobs and just focusing on to fix phpunit first then I'll restore the upgrade_status in the pipeline.

Need to fix phpunit errors and the following phpstan errors

 ------ --------------------------------------------------------------- 
  Line   tests/src/Unit/Access/QuickEditEntityFieldAccessCheckTest.php  
 ------ --------------------------------------------------------------- 
  83     Trying to mock an undefined method get() on class              
         Drupal\Core\Entity\EntityInterface.                            
  87     Trying to mock an undefined method hasTranslation() on class   
         Drupal\Core\Entity\EntityInterface.                            
 ------ --------------------------------------------------------------- 

The remaining tests are failing because the library quickedit.inPlaceEditor.formattedText is not attached during testing. I will investigate further to determine the root cause.

I have fixed most of the failing tests only 2 similar test are failing.

1. Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderIntegrationTest::testArticleNode - This caused by empty body field value
2. Drupal\Tests\quickedit\FunctionalJavascript\CKEditor5IntegrationTest::testArticleNode - Not sure why saving state isn't available for body field

Created a separate issue 🐛 Quick Edit doesn't support inline editing with ckeditor5 Needs work to cover the 2 pipeline issue and require a fresh set of eyes on them as that has dependency on ckeditor 5 module. Hence moving this ticket into review.

I'm trying to apply this patch agains version 1.0.3 and it does not work, it only seems to work with 1.0.x, should this be the case?
I'm currently just adding the patch under extra, patches in my composer.json file.
Setting as needs review as I would expect it to apply.

Yes @darrenwh , you cannot apply a patch for this module for an older version, you need to apply against dev [1.0.x].

Note: You can update your composer.json to load quickedit module dev version and then apply the patch in extra section and it will work fine.