albert volkman → made their first commit to this issue’s fork.
Duplicate of https://www.drupal.org/project/pdf/issues/2805053 🐛 Required PDF.js library is not installed when using composer RTBC
I haven't worked on this module in ages, but if memory serves it just adds additional functionality the to chosen module to maintain sort order of the available options. Are you saying that the chosen module offers that now?
The upgrade_status module reports the following-
Class Drupal\purge_queuer_url\Commands\SqlSanitizeCommands implements deprecated interface Drush\Drupal\Commands\sql\SanitizePluginInterface: use \Drush\Commands\sql\sanitize\SanitizePluginInterface instead.
This looks similar- https://www.drupal.org/project/drupal/issues/3243387 🐛 Argument 1 passed to Drupal\Core\Routing\RequestContext::fromRequest() must be an instance of Symfony\Component\HttpFoundation\Request, null given Closed: cannot reproduce
Seeing this in the 2.0.x branch as well. Bumping up so we can fix it there first.
albert volkman → made their first commit to this issue’s fork.
Looks like this got addressed here- https://git.drupalcode.org/project/acquia_perz/-/commit/d86695a1f9c41382...
Albert Volkman → created an issue.
One missed instance of the renderPlain() method.
volkswagenchick → credited Albert Volkman → .
LGTM
LGTM
Tested and confirmed working. LGTM.
Albert Volkman → created an issue.
Created a version of the existing patch to apply to 10.1.x
Albert Volkman → made their first commit to this issue’s fork.
Albert Volkman → made their first commit to this issue’s fork.
Merged. Thank you @Harlor!
Updating patch to apply to dev branch
LGTM
Re-roll for latest 10.1
Albert Volkman → made their first commit to this issue’s fork.
Setting status per @nessthehero's review.
quietone → credited Albert Volkman → .
DamienMcKenna → credited Albert Volkman → .
Albert Volkman → created an issue.
Albert Volkman → created an issue.
@hotwebmatter nice catch! Latest commit should handle that.
Albert Volkman → created an issue.
@Nelo_Drup just wanted to say "thank you" for referencing this module. It's helped me out a lot!
Reviewed and merged! Thank you.
Albert Volkman → made their first commit to this issue’s fork.
Albert Volkman → made their first commit to this issue’s fork.
Re-roll for 9.5.x
Albert Volkman → made their first commit to this issue’s fork.
volkswagenchick → credited Albert Volkman → .
Thanks @awolfey!
Thanks @anpolimus!
volkswagenchick → credited Albert Volkman → .
I just took over maintainership of this module. And, upon reviewing the commit history, it looks like the decision to point to the database replica may have been a mistake (or a need for the author, that slipped through to the contrib code).
I'm going to modify your patch to use the default database, instead of the replica.
Merged! Thank you!
Reroll for 9.5.x.
@apaderno thank you!
We have a need for this project and it is no longer actively maintained. I'm interested in moving this project forward.
Just checked out and used daggerhart's module. Worked perfectly. Thank you!
daggerhart++