- πΊπΈUnited States kenrbnsn New Jersey
This issue and https://www.drupal.org/project/pdf/issues/3365327 π Use composer to handle the dependency on pdf.js Active seem to addressing the same problem. Perhaps the solution it that issue can be implemented.
- πΊπΈUnited States chri5tia PDX
For those that ended up here for the reason I did, the instructions for #15 worked and in on par with usual practices.
- πΊπΈUnited States Albert Volkman
albert volkman β made their first commit to this issueβs fork.
- π§πΎBelarus mozh92
Steps for add pdf.js:
1. add repository in your root composer.json:"repositories": [ .................................. { "type": "package", "package": { "name": "mozilla/pdf.js", "version": "5.1.91", "type": "drupal-library", "dist": { "url": "https://github.com/mozilla/pdf.js/releases/download/v5.1.91/pdfjs-5.1.91-dist.zip", "type": "zip" } } } ],
2. Add "mozilla/pdf.js": "^5.1", in require section
"require": { .................................... "mozilla/pdf.js": "5.1.91" }
3. run 'composer require mozilla/pdf.js'
- πΊπΈUnited States mortona2k Seattle
Any reason not to merge what we've got? It should be set up to load the library automatically, right?
Having the module define the asset repo as a package in composer.json and requiring it should work.
If not, the instructions to set up composer.json are working fine and could just be pasted into a README.