- Issue created by @Albert Volkman
- @albert-volkman opened merge request.
- Status changed to Needs review
over 1 year ago 2:20pm 8 May 2023 - πΊπΈUnited States hotwebmatter Providence, Rhode Island, USA
This seems correct.
I will note, however, that the behavior appears to be sticky until caches are cleared.
So ... either invalidate caches for the specified routes when config is saved, or take the lazy route and add some text saying "Rebuild caches after saving configuration."
Does that make sense?
- πΊπΈUnited States Albert Volkman
@hotwebmatter nice catch! Latest commit should handle that.
- Status changed to RTBC
over 1 year ago 10:20pm 9 May 2023 - πΊπΈUnited States hotwebmatter Providence, Rhode Island, USA
Tested Merge request !3
With unpatched module,
http://d9.lndo.site/admin/config/system/m4032404
is redirected to 404, whether or not the "Enforce on Admin Only" boolean is setTRUE
.After applying patch, if no Pages are specified, the default behavior remains the same, and
http://d9.lndo.site/admin/config/system/m4032404
is redirected to 404, whether or not the "Enforce on Admin Only" boolean is setTRUE
.After specifying
/admin/config/system/m4032404
in Pages, the following behavior occurs:- When "Redirect the above paths to 404" radio button is selected:
$ wget --spider http://d9.lndo.site/admin/config/system/m4032404 Spider mode enabled. Check if remote file exists. --2023-05-09 18:12:29-- http://d9.lndo.site/admin/config/system/m4032404 Resolving d9.lndo.site (d9.lndo.site)... 127.0.0.1 Connecting to d9.lndo.site (d9.lndo.site)|127.0.0.1|:80... connected. HTTP request sent, awaiting response... 404 Not Found Remote file does not exist -- broken link!!!
- When "Do not redirect the above paths to 404" radio button is selected:
$ wget --spider http://d9.lndo.site/admin/config/system/m4032404 Spider mode enabled. Check if remote file exists. --2023-05-09 18:12:40-- http://d9.lndo.site/admin/config/system/m4032404 Resolving d9.lndo.site (d9.lndo.site)... 127.0.0.1 Connecting to d9.lndo.site (d9.lndo.site)|127.0.0.1|:80... connected. HTTP request sent, awaiting response... 403 Forbidden Remote file does not exist -- broken link!!!
Reviewed and tested by the community.
- When "Redirect the above paths to 404" radio button is selected: