Contrib.social

Download count settings includes download_count_last_cron which should really be a Drupal state variable instead of a setting

Open on Drupal.org →
Created on 14 November 2020, about 4 years ago
Updated 12 July 2024, 4 months ago

Problem/Motivation

As download_count_last_cron gets updated on cron runs it then exports with config. On a site where config is tracked in git this shows up as extraneous changes.

Steps to reproduce

Install download_count, make no changes to the site but just let cron run, export config. Note that the system wants to export a new value for download_count.settings causing a developer who is deploying code to have to check whether live values have changed.

Proposed resolution

Use the States API → for this variable instead. See the issue marked as related for an example.

User interface changes

None

API changes

Update the settings schema.

Data model changes

Remove download_count_last_cron from settings.

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇨🇦Canada lolcode

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024