Download count settings includes download_count_last_cron which should really be a Drupal state variable instead of a setting

Created on 14 November 2020, over 3 years ago

Updated 22 March 2024, 3 months ago

Problem/Motivation

As download_count_last_cron gets updated on cron runs it then exports with config. On a site where config is tracked in git this shows up as extraneous changes.

Steps to reproduce

Install download_count, make no changes to the site but just let cron run, export config. Note that the system wants to export a new value for download_count.settings causing a developer who is deploying code to have to check whether live values have changed.

Proposed resolution

Use the States API → for this variable instead. See the issue marked as related for an example.

User interface changes

None

API changes

Update the settings schema.

Data model changes

Remove download_count_last_cron from settings.

🐛 Bug report

Status

RTBC

Version

2.0

Component

Code

Created by

🇨🇦Canada lolcode

Live updates comments and jobs are added and updated live.

Incomplete comments

Merge Requests

!5Download count settings includes download_count_last_cron which should really be a Drupal state variable instead of a setting
Open
🇺🇸United States Albert Volkman
updated 2 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States mlncn Minneapolis, MN, USA
Still a (frustrating) issue on the 2.0.x branch. (2.0.x is not available as a version in the issues for some reason so assigning to 2.0.0 for now.)
Comment 8 months ago →
🇺🇸United States Albert Volkman
Albert Volkman → made their first commit to this issue’s fork.
Merge request !5Replace download_count_last_cron config with state → (Open) created by Albert Volkman
Status changed to Needs review 8 months ago6:10pm 9 November 2023
Comment 8 months ago →
🇺🇸United States Albert Volkman
Status changed to RTBC 4 months ago7:17pm 27 February 2024
Comment 4 months ago →
🇺🇸United States Albert Volkman
Comment 3 months ago →
🇩🇪Germany szeidler Berlin
Thanks for providing the MR, this is a really annoying issue. Should we implement a update hook that removes the stored config value for existing sites?

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024