πŸ‡¬πŸ‡§United Kingdom @darrenwh

Bristol
Account created on 27 December 2012, over 12 years ago
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

I'm trying to apply this patch agains version 1.0.3 and it does not work, it only seems to work with 1.0.x, should this be the case?
I'm currently just adding the patch under extra, patches in my composer.json file.
Setting as needs review as I would expect it to apply.

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

True, had tunnel vision there, have removed those two methods.

Hi Rupert, yes its been ages; hope your doing fine :-)

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

This should not break in older versions

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

Just refactoring this as there was an issue accessing the job object using this method, added a var that the array value is assigned to.

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

Attaching patch

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

darrenwh β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

Attached patch

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

darrenwh β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

@DamienMcKenna a minimum PHP version could be added to the info file? Will need to go back and see when it changed as pretty sure the syntax has been around for a while.

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

darrenwh β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

darrenwh β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

I've found the issue I think, the elements were a submit and cancel button, I wrapped them in a action section https://api.drupal.org/api/drupal/developer%21topics%21forms_api_referen... and it now seems to work. Closing

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

Closing works as designed as found a old patch that was overwriting the temp store file

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

Looking further it is in fact the current user and seems to relate to https://www.drupal.org/node/3006268 β†’

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

The function urlencode in SimpleGMapTrait->viewElements line 254 is throwing a depreciated error in php 8.1

      $url_value = is_null($item->value) ? '' : urlencode($item->value);
      $address_value = is_null($item->value) ? '' : $item->value;
πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

darrenwh β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom darrenwh Bristol

Adding patch

Production build 0.71.5 2024