Account created on 19 April 2011, over 14 years ago
  • Drupal Senior Developer at ImageX 
#

Merge Requests

More

Recent comments

🇧🇷Brazil igorgoncalves

Really thanks for asking that @smustgrave, because its a trick one.

Despite typo @joshahubbers have fixed, the wrong space was being replaced at the line 262 when we pass through the explode(":")

And when i was trying to replicate the issue, i found a false positive as we can see below at the Before screenshot:

Before

The empty space in that case was caused by the lack of label on my test. when we add the label value the message contain no errors.

So, i suggested the change i made on last MR, and i will give the 2 new After screenshots, with and without label field filled.

After

🇧🇷Brazil igorgoncalves

It works with the suggestion @drunken monkey gives in another issue 💬 Autocomplete Not Suggesting More than 1 Word Fixed

using the “Display live results” suggester with its “Suggest result labels as keywords”

Drupal 11.2.2
autocomplete 8.x-1.10
search_api_solr 4.3.10

🇧🇷Brazil igorgoncalves

I double check the changes, and achieve the same result as i found at #59
(Sorry that i didnt added the screenshots back then)
The advanced column "is gone" as the collapsible behavior.

So i will add the Before Screenshot that @uesli give to us to not flood the IS with duplicated images

Before - just checked with a clean D11.2-dev instalation.

----------------------------------

After - just checked with a clean D11.2-dev instalation + MR 11424.

🇧🇷Brazil igorgoncalves

Thanks @sandip

I just check your MR for 10.6.x, and works as expected and fixes the issue.

RTBC +1

🇧🇷Brazil igorgoncalves

RTBC +2

#11 works great on my D11 site, and the default timezone now its set to the website default tz.

thanks

🇧🇷Brazil igorgoncalves

Hi @brahmjeet789, Murilo just tried to give us another way to fix with the MR we currently have.

did you tried to check the proposal MR with the steps at #27?

🇧🇷Brazil igorgoncalves

Thanks @anybody, i think we can reopen though.

I just struggle with this issue on my project today.

I will leave steps to reproduce:

1 - clean install Drupal 11.2.2
2 - contrib module: views_load_more 2.x-dev
3 - create 2 or 3 test articles.
4 - create a page view with pagination of 1 article by page, and using the load_more link.
5 - check the view working with olivero, claro... any theme.
6 - now drush generate a test theme with base theme: stable9
7 - check views pagination stop work.

After copy the views-view.html.twig file from olivero theme into my test theme folder. the views is back to work

I tried to only add the classes as yivanov suggested at #6 but didnt work.

🇧🇷Brazil igorgoncalves

Hey @murilo,

you could just add ".diff" at the end of the MR link, and we are go to go on composer. :)

Like: https://git.drupalcode.org/project/quickedit/-/merge_requests/18.diff

🇧🇷Brazil igorgoncalves

Just tried to reproduce the error following the steps at summary but didnt work.

With simplytest, and Drupal 10.5.1-dev

Needs a summary update indeed.

If i find the way, i will edit the summary.

🇧🇷Brazil igorgoncalves

Hi Vasyl, thanks for the patch.

But i couldn't reproduce the error, even following the steps you provided.

Here the versions i tested on simplytest.me:

Drupal: 11.3-dev
social_link_field: 2.1.0
token: 8.x-1.x-dev

Can you provide more details? thanks!

🇧🇷Brazil igorgoncalves

RTBC + 2

Works great on my Drupal 11.2.0 clean install.

I will leave below the steps that i had to follow, maybe can help someone else in the future too.

Check it out this page

I ran this commands to start from stratch, using ddev:

ddev composer create-project drupal/recommended-project
ddev config --project-type drupal --docroot web
ddev start
ddev composer create-project drupal/recommended-project
** ddev composer require mglaman/composer-drupal-lenient **
ddev composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/quickedit"]'
ddev composer require cweagans/composer-patches
ddev composer require --dev drush/drush
ddev drush site:install --account-name=admin --account-pass=admin -y
ddev composer require drupal/ctools; ddev drush en ctools
ddev composer require drupal/entity; ddev drush en entity
ddev composer require drupal/libraries; ddev drush en libraries
ddev composer require drupal/quickedit; ddev drush en quickedit 

[here we added the libraries required and the merge request patch]

ddev composer update drupal/quickedit
ddev launch

** This was done to remove a barrier with getting extensions installed via Composer to work on making modules Drupal 11 ready.

After that i created a test article and the result works as expected i could change the title of my article.

🇧🇷Brazil igorgoncalves

Thanks @jatingupta40

the MR was showing a red line at csslint:
"description":"Unexpected deprecated at-rule \"@nest\" (at-rule-no-deprecated)"

I committed a fix and Lint looks all green now.

I also applied the last changed patch, and the bug is fixed.

🇧🇷Brazil igorgoncalves

igorgoncalves made their first commit to this issue’s fork.

🇧🇷Brazil igorgoncalves

Thanks @benstallings.

I tried to fix the phpunit errors, but with no success.

I will investigate this further and try again later.

🇧🇷Brazil igorgoncalves

igorgoncalves made their first commit to this issue’s fork.

🇧🇷Brazil igorgoncalves

Thanks @jpamar!

@jatingupta40 i think you forget to create the MR, i opened now, and fix looks good to me.

🇧🇷Brazil igorgoncalves

Hi @prudloff, thanks for you patch.

Despite the fact your change its important to keep the code standards and prevent the issue, i couldn't reproduce the error.

Can you update the IS with a quick step-by-step?

I just tried with a Drupal 11 clean installation, the module version of this issue, and i deleted every vocabulary before test.

Even though created the feedback as normal, without any warning on watchdog.

🇧🇷Brazil igorgoncalves

Thanks @dcam

I just followed the steps to reproduce and i confirm the error at the time to create my test content translation.

And after applying the patch, i could create the translation with no problem.

Drupal version 11.2.0-dev

🇧🇷Brazil igorgoncalves

Thanks @alex.bukach

Just followed the steps to reproduce and i confirm that on a clean Drupal 11 instalation there's no "numeric filter" available for my integer field.

And testing with the Merge Request there's numeric filter (screenshot below) and when i applied, the filter works as it should with "greater than" option, for example.

🇧🇷Brazil igorgoncalves

It says that "Merge request contains no changes".

I just reopened a new one with the changes from @ananya.k patch.

🇧🇷Brazil igorgoncalves

Hi guys

As the last feedback review was given by #41, i made another up-to-date check after all last commits and the changes seems to address the requests.
The advanced column "is gone" as the collapsible behavior.

Checked with Drupal 11.2.x-dev

🇧🇷Brazil igorgoncalves

thanks @IshaniPatel

The tests result was consistent after applying your code improvement.

🇧🇷Brazil igorgoncalves

Hi guys,

i agree with @joachim that a lot of new comments seems redundant.
So, i made some changes which i think has enough to inform what and how we can enable the draggable list feature.

So, assuming you follow the steps-to-reproduce, the drush generator create my test entity type just like:

 *   entity_keys = {
 *     "id" = "id",
 *     "label" = "label",
 *     "uuid" = "uuid"
 *   }

so, simply adding the "weight" = "weight" into that, the draggable will works (as screenshot below)

then i thought add this simple code example at class docblock could be useful aswell.

i also removed the new "inline comment" from the construct, as the whole information at those lines already being explained at the method.

🇧🇷Brazil igorgoncalves

Hey @svenryen and @rajeshreeputra

i am interested to help, if stills available.

I took a look into the spreadsheet and the issue queue and i'll be glad to give a hand.

🇧🇷Brazil igorgoncalves

Yes, i agree with you.

Both scenarios we found here should be fixed inside cobtrib modules issues, not here.

Thats why i suggest to close this Core Bug Issue and open a Core Feature request, as at least the thread serves to pointed out some core-code improvements.

🇧🇷Brazil igorgoncalves

Hi @smustgrave!
Thanks for your quick reply.

I can see what you said on #10: "Will need a test case showing this issue in core though".

But i raised the idea on my last comment #20, that maybe we'll never find the way to show this issue on core.
As both scenarios we reproduce here was related to 3rd contrib modules: mimemail and moderated_note

Also, the patch #2 attached have some cons pointed by #6.

So maybe we have nothing to test here, and instead review if this original issue its a bug or can be replaced as a feature request.

Do you agree?

🇧🇷Brazil igorgoncalves

After facing this same issue on my project, i fall into this old thread and i just updated the steps to reproduce.

Looks like the original problem of @_renify_ was related with the mimemail module and the fix pointed by @joelpittet and @TR resolves the error.

But in my case i wasn't using the mimemail, insted, i faced the issue using the moderation_note.

As following the same trail they left here, i checked the moderation_node module and also a very similar code gap was causing the error.

So, after adding the patch into moderation_note module (just added the related issue to this thread as well), the error is gone.

Maybe at this point is enough to say that the issue its not in the core.
But i also agree that it's a good idea to do the injection properly in the PhpMail constructor, rather than just use the global function.

Should be the case to close this one as a bug report, and open a feature request mentioning this thread?

🇧🇷Brazil igorgoncalves

Patch #42 works well for me, thanks!

Drupal version : 10.4.6
conditional_fields Version: 4.0.0-alpha6

🇧🇷Brazil igorgoncalves

Hey guys, actually there's a long thread here about this issue: https://www.drupal.org/project/drupal/issues/2916876 Add visibility control conditions to blocks within Layout Builder Needs work

🇧🇷Brazil igorgoncalves

Worked with @mmenavas at #Atlanta2025

Issue still needs review.

🇧🇷Brazil igorgoncalves

working with @bember and @kwiseman at #Atlanta2025

🇧🇷Brazil igorgoncalves

I attended the slack meeting and registered. [2]

🇧🇷Brazil igorgoncalves

Hey guys, i was able to reproduce this issue with:

  • Drupal: 10.4.2
  • PHP version: 8.2.18
  • single_content_sync: 1.4.10
  • entity_reference_revisions: 8.x-1.12

also, the file @aaronchristian attached indeed import with no problem, but on export the issue happens.

So, after debugging i find out the issue was inside the exportCustomValues, and following the bug trail i realize the field entity_reference_revisions was unsupported, and when getFieldValue was called we'v got into a kind of loophole.

The solution i found was to check if the field has that specific unsupported type and then 'get the value as it is' as the previous code comment says.

🇧🇷Brazil igorgoncalves

Attended.
Helping at Mentor communications too. Thanks!

🇧🇷Brazil igorgoncalves

Confirm with the MR, the updb ran without errors and 'Update events_logging entity type.'

🇧🇷Brazil igorgoncalves

confirm that issue was happening with Drupal Core 10.4.2 and after applying the patch the error is gone, as screenshots below.

🇧🇷Brazil igorgoncalves

tests are failing due to phpcs and phpunit, we are looking into at ContributionWeekend2025

🇧🇷Brazil igorgoncalves

I’v found this related issue at github.com/symfony and following the last comment, with the proposed solutions i created one commit with changes at the file we get the previous error.
But the pipeline keeping crashing before completion.
Still requiring more researching.

🇧🇷Brazil igorgoncalves

igorgoncalves made their first commit to this issue’s fork.

🇧🇷Brazil igorgoncalves

I did some changes to follow README sections, specially the required ones.
Also added the optional Maintainers section.
Please review.

🇧🇷Brazil igorgoncalves

Hi Sayan, thanks for the effort.
Despite the fact that tests have "Pass" status, there's one warning left, and checking the detail says:

Drupal\Tests\Core\Utility\UnroutedUrlAssemblerTest::testAssembleWithExternalUrl with data set #7
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'https://example.com/test?foo'
+'https://example.com/test?foo='

which sounds like pretty much what we are testing here, isnt?

🇧🇷Brazil igorgoncalves

Hey guys, any luck with the push notifications on ios?

Im diving into this and even the modal wasnt showing on my iphone. So i needed to upgrade my ios (https://developer.apple.com/documentation/usernotifications/sending-web-...)

only ios 16.4 or + it works.

after that i was able to see the modal, but as @2dareis2do said, push still not appearing after create new contents or broadcast some push tests

🇧🇷Brazil igorgoncalves

Thanks @anthonyf!
I ending up at the same error, my "optional" field was included in annotation for the entity keys.

Now it works ok.

🇧🇷Brazil igorgoncalves

Checked, and working perfectly now, thanks @mglaman !

🇧🇷Brazil igorgoncalves

@carolpettirossi patch fixed the contextual link issue and they're back!
Thanks carol.

But in my project it ending up showing another issue after trying to editing blocks using those links, and this issue/patch helps me:

https://www.drupal.org/project/drupal/issues/3208687

sharing just in case another one faces the same.

🇧🇷Brazil igorgoncalves

My fix try to make sure the directory exists before the action, if not they will create.

🇧🇷Brazil igorgoncalves

igorgoncalves made their first commit to this issue’s fork.

🇧🇷Brazil igorgoncalves

Thanks @mahtab_alam
I checked the code at the last MR and looks ok, but i will ask for guidance on how the proper way to test the change. I will also ask on our slack #channel.

🇧🇷Brazil igorgoncalves

@oliverpolden i got the same issue as you but end up working without no patch.
you can just use the regular option "A date in any machine readable format. CCYY-MM-DD HH:MM:SS is preferred."

and set the field value as: Y

🇧🇷Brazil igorgoncalves

The content is accurate.
I also checked the code into my test enviroment (D10.1.6).

🇧🇷Brazil igorgoncalves

Any progress with this issue @motren-37?
I just faced that very same problem after D10 and CK5 upgrade. Im looking to it.

🇧🇷Brazil igorgoncalves

At: 
https://www.drupal.org/docs/administering-a-drupal-site/security-in-drup...

I suggest change the db_like($user) good practice example for the D10 current one: escapeLike()

As the documentation explain right below the example, db_like method were removed since D9 to use escapeLike.

So, basically we are showing to the user an example that its not used at the latest core version, and at the bottom we are saying they should use a new improved version.

Production build 0.71.5 2024