- Issue created by @GuillaumePacilly
- First commit to issue fork.
- 🇮🇳India annmarysruthy
In authoring information tab (in node add, edit), 'Authored by' has maxlength 1024. Only in translation form, Authored by inside translation tab has maxlength 60. In the same translation form, Authored by field inside 'Authoring information' tab has maxlength 1024 and this causes issue.
Instead of removing maxlength, I would recommend changing maxlength of 'Authored By' inside translation tab to 1024 and make it same as ' Authored by' field inside 'Authoring information' tab
- 🇮🇳India annmarysruthy
annmarysruthy → changed the visibility of the branch 3473029-wrong-maxlength-on to hidden.
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- 🇮🇳India annmarysruthy
annmarysruthy → changed the visibility of the branch 3473029- to hidden.
- Merge request !9534Issue #3473029: correct the maxlength on Authored By field for translation → (Open) created by annmarysruthy
- Status changed to Needs review
10 months ago 5:40am 19 September 2024 - Status changed to Needs work
10 months ago 1:04pm 19 September 2024 - 🇺🇸United States smustgrave
New approach will need issue summary update.
Also might be nice to get a test showing how this is a probelm.
- First commit to issue fork.
- 🇧🇷Brazil igorgoncalves
Thanks @dcam
I just followed the steps to reproduce and i confirm the error at the time to create my test content translation.
And after applying the patch, i could create the translation with no problem.
Drupal version 11.2.0-dev
- 🇺🇸United States smustgrave
Pulled up the original issue #1807800: Add status and authoring information as generic entity translation metadata → and don't see any discussion around using 60 so I imagine no one is super against changing.
Test-only job didn't run https://git.drupalcode.org/issue/drupal-3473029/-/jobs/5575179
Ran locally but it seems to be passing so may need some tweaking
- 🇺🇸United States dcam
I asked in the core-development Slack if the test-only job passes because the new assertions are in an abstract base class. Per @godotislate that is the case. The test-only runner looks for changes in *Test.php files. I was advised to create a test-only MR, which I did in MR 12393.
- 🇺🇸United States dcam
And now you can see that multiple content translation UI tests are failing. Thank you @godotislate!
- 🇺🇸United States smustgrave
Good to know, but the test failure happening doesn't appear to happen around the code being introduced.
Also
$this->assertSession()->statusMessageNotExists('error');
This could probably be updated.
- 🇺🇸United States dcam
I improved the test. I think it's probably good to go now.
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 3473029-correct-maxlength-test-only to hidden.
- 🇺🇸United States smustgrave
Hiding the test-only branch incase the bot picks it up.
But I see that the failures are now coming from the added test coverage
│ /builds/issue/drupal-3473029/core/modules/content_translation/tests/src/Functional/ContentTranslationUITestBase.php:368
That was the only feedback I had, so believe this one is good to go.