I have a production use case where mail of the users are subject to change relativly frequently and therefor I need to be able to select another unique and more stable attribute for the user mapping.
While the provided patches and MR add the ability to select another user field for the mapping, it raises an error in my context cause the email attribute is not part of the default mail keys defined.
I added in a new MR api hooks for the saml_sp_drupal_login to let other modules alter the mail keys and the mandatory and optional attributes mapping.
This is a quick fix and a better way would probably to make it configurable on the IdP settings page directly or smth similar to the approach described here https://www.drupal.org/project/saml_sp/issues/3118296#comment-14050093 ✨ Add extra fields to config Needs work
guillaumepacilly → made their first commit to this issue’s fork.
@djg_tram thanks for pointing this out. Indeed webhook should return a successfull response in this case. This will be fixed in https://www.drupal.org/project/commerce_payrexx_integration/issues/3554162 🐛 Payment with INITIATED status incorrectly marked as completed, causing premature order completion Active
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → changed the visibility of the branch issue/GS1-161_performance_issues to active.
guillaumepacilly → changed the visibility of the branch issue/GS1-161_performance_issues to hidden.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → changed the visibility of the branch 3523312-support-upgrade-to to hidden.
@freezernick, I can't reproduce the issue on any instance. I suspect there is a conflict with a generic css class in your custom theme.
Could you please test again on the 4.x-dev branche and let me know?
guillaumepacilly → created an issue.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.
guillaumepacilly → made their first commit to this issue’s fork.