Advanced settings in Views edit - preserve state or leave expanded?

Created on 16 January 2017, over 8 years ago
Updated 3 August 2024, 10 months ago

Problem/Motivation

  1. Install Drupal
  2. Edit a view - e.g. /admin/structure/views/view/content
  3. 'Advanced' section ('.details-wrapper') is always collapsed/hidden on initial page load, regardless of whether advanced settings have been made, and if the user has just expanded and edited something in that section, e.g. adding a contextual links or relationship, when the modal window is closed the Advanced div is always collapsed again

Motivation:

UX/DX, timesaving, specifically:

  • I find myself wasting a lot of clicks when editing views.
  • Avoid active settings being missed because they're not immediately visible
  • Is there real reason it needs to be collapsible at all? On desktop it saves no space, you just get an empty column area, and the content is always loaded in background.
  • Are the "advanced" settings really "advanced", i.e. more complicated than those in the first two columns. I'd argue relationships, contextual filters, machine name, admin comment and CSS class perhaps aren't. e.g The first two would work well in column two, and machine name and admin comment could go in (Page|Block|..) Settings. I'm wondering if the page has grown over time and the "advanced" column has turned more into "miscellaneous"?

Proposed resolution

  • Lose disclosure triangle and always show remember previous setting.
  • Move some items in advanced column to better locations.

Remaining tasks

Preemptively tagged for subsystem review as it'll require sign-off.

Discuss to see likelihood of approval, then work on patch.

User interface changes

Depends on outcome.

API changes

None.

Data model changes

None.

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
Views UIΒ  β†’

Last updated 7 days ago

Created by

πŸ‡¬πŸ‡§United Kingdom wturrell

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    The work here is longer suitable for a novice, in my opinion.

  • First commit to issue fork.
  • Merge request !11424Remove the Advanced Settings details β†’ (Open) created by dcam
  • Pipeline finished with Failed
    3 months ago
    Total: 177s
    #443826
  • πŸ‡ΊπŸ‡ΈUnited States dcam
  • Pipeline finished with Success
    3 months ago
    Total: 6432s
    #443829
  • πŸ‡ΊπŸ‡ΈUnited States dcam

    Based on #22 I removed the collapsible behavior entirely.

  • πŸ‡ΊπŸ‡ΈUnited States dcam
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Asking about that update hook number (small change if needed)

    But we should have a CR for the configuration change. Mentioning why it's been removed.

  • πŸ‡ΊπŸ‡ΈUnited States dcam

    Change record added at https://www.drupal.org/node/3515212 β†’ . Leaving status as Needs Work due to the question of what the update number should be. I checked Slack and no one has responded yet. I'll try to check back in a day or two.

  • Pipeline finished with Canceled
    2 months ago
    Total: 184s
    #457637
  • Pipeline finished with Success
    2 months ago
    Total: 464s
    #457640
  • πŸ‡ΊπŸ‡ΈUnited States dcam

    The update function number was updated per the discussion in Slack. I also rebased it against 11.x to get the latest changes.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Apologize for taking so long to get back to this one, even after posting it in slack lol

    But feedback appears to be addressed.

  • Status changed to RTBC 24 days ago
  • πŸ‡«πŸ‡·France nod_ Lille
  • πŸ‡¬πŸ‡§United Kingdom catch

    The change record should explicitly reference the config key that's being removed. There will be some cases like distributions with a full set of exported config that could end up with stale config after this change and will need to remove the key manually.

    I'm confused by the update number here - left a comment on the MR.

  • Pipeline finished with Failed
    8 days ago
    Total: 214s
    #508474
  • Pipeline finished with Success
    8 days ago
    Total: 761s
    #508483
  • πŸ‡ΊπŸ‡ΈUnited States dcam

    #57 feedback was addressed.

  • πŸ‡§πŸ‡·Brazil igorgoncalves

    Hi guys

    As the last feedback review was given by #41, i made another up-to-date check after all last commits and the changes seems to address the requests.
    The advanced column "is gone" as the collapsible behavior.

    Checked with Drupal 11.2.x-dev

Production build 0.71.5 2024