Advanced settings in Views edit - preserve state or leave expanded?

The work here is longer suitable for a novice, in my opinion.

Based on #22 I removed the collapsible behavior entirely.

Asking about that update hook number (small change if needed)

But we should have a CR for the configuration change. Mentioning why it's been removed.

Change record added at https://www.drupal.org/node/3515212 → . Leaving status as Needs Work due to the question of what the update number should be. I checked Slack and no one has responded yet. I'll try to check back in a day or two.

The update function number was updated per the discussion in Slack. I also rebased it against 11.x to get the latest changes.

Apologize for taking so long to get back to this one, even after posting it in slack lol

But feedback appears to be addressed.

The change record should explicitly reference the config key that's being removed. There will be some cases like distributions with a full set of exported config that could end up with stale config after this change and will need to remove the key manually.

I'm confused by the update number here - left a comment on the MR.

#57 feedback was addressed.

Hi guys

As the last feedback review was given by #41, i made another up-to-date check after all last commits and the changes seems to address the requests.
The advanced column "is gone" as the collapsible behavior.

Checked with Drupal 11.2.x-dev

Feedback appears to be addressed for this one.

The screenshots appear to be in #33, but they also don't actually seem to show the "after" case. It's probably best not to embed them in the IS in either case, but we would want to at least link them. Tagging for new screenshots.

I disagree that this is a bug. It was a design behavior and was changed on purpose from a previous setup where the column was always shown, because we wanted to make the Views UI less overwhelming on page load. Therefore, I think this should have both usability and subsystem signoff. Once the screenshots are added and embedded in the IS, this can be tagged for usability review.

Hi, @xjm

Test summary

Drupal version: 11.2-dev

1 - Visited the views listing page.

2 - Edited one of the views (Content view).

3 - The Advanced column was visible and expanded in the first page load.

4 - Added a contextual filter and closed the modal window. The advanced settings column was visible and expanded.

5 - Saved the settings. The advanced settings column was visible and expanded.

@uesli, I think from the screenshots #62 is testing Drupal 11.2 without the merge request, correct?

I double check the changes, and achieve the same result as i found at #59
(Sorry that i didnt added the screenshots back then)
The advanced column "is gone" as the collapsible behavior.

So i will add the Before Screenshot that @uesli give to us to not flood the IS with duplicated images

Before - just checked with a clean D11.2-dev instalation.

----------------------------------

After - just checked with a clean D11.2-dev instalation + MR 11424.

I agree with @xjm this isn't really a bug, so moved to task, might be a feature ¯\_(ツ)_/¯

@dawehner seemed to be in favour of this back in the day, and so am I, so removing the subsystem tag. I understand the initial thought behind not showing this, but I believe the Views UI is still plenty complicated without showing this column. And as people have pointed out in this issue this can lead to information being hidden. Also, it always felt a little arbitrary what was considered 'Advanced', since, lets be honest, the whole Views UI is pretty advanced :)

@yoroy has commented here so not sure if a usability review is needed, but happy to follow @xjm on this, so tagging for usability review

Ahh, thanks @lendude, I missed #6:

I think the collapsed “Advanced” column was a rather brute-force way to reduce clutter in the Views UI. I wouldn't mind showing it expanded again.