Acquia DAM and Experience builder integration support.

vishalkhode → made their first commit to this issue’s fork.

vishalkhode → changed the visibility of the branch 3519247-approach-1 to hidden.

Updated MR with necessary changes, requesting review.

chandu7929 → changed the visibility of the branch 3519247-acquia-dam-all-media to hidden.

The approach in this MR is incompatible with what I've heard @lauriii describe: support both core's Image MediaType and Acquia DAM images at the same time.

👉 📌 Decouple image shape matching from the `image` MediaType Active paved most of the path for this to work the way that I've heard @lauriii describe it, but you'll first need to do 📌 Support image shape matching from the `image` MediaSource: support both the `image` + `oembed` MediaSources simultaneously Active to make it entirely possible. I've included clear next steps.

More concerning: the way this MR currently works is by introducing a completely separate prop shape, which means that all existing SDCs/code components won't work! Plus, the sole SDC that uses that new prop shape is adding half a dozen or so props that would present concerns to the content author that they should never see.

Due to the fact that code components are hard coded to image schemas, and that we need to define our own schema to start asset, external, and version IDS.. marking postponed until 📌 Support image shape matching from the `image` MediaSource: support both the `image` + `oembed` MediaSources simultaneously Active lands.

Implemented 📌 Support image shape matching from the `image` MediaSource: support both the `image` + `oembed` MediaSources simultaneously Active for y'all.

Then, over here:

The existing hook_storage_prop_shape_alter() in this MR was very helpful as a blueprint of knowing what the bundle + field name + prop name to target were! Thanks 🙏 😊
1. Merged in upstream 1.1.x because without it, Acquia DAM does not support Drupal 11.2, which XB requires
2. Removed the SDC this MR was adding: https://git.drupalcode.org/project/acquia_dam/-/merge_requests/147/diffs...
3. Added test coverage to prove that Acquia DAM can successfully build on top of what XB's \Drupal\experience_builder\Hook\ShapeMatchingHooks::mediaLibraryStoragePropShapeAlter() does, by taking whatever that found and adding in Acquia DAM's (hardcoded?!) image media type: https://git.drupalcode.org/project/acquia_dam/-/merge_requests/147/diffs...
4. … then updated Acquia DAM's hook_storage_prop_shape_alter() implementation to actually make the test pass
5. Result:

Note: CI is failing on 11.2 for HEAD of Acquia DAM: https://git.drupalcode.org/project/acquia_dam/-/jobs/5977020. This MR just adds one more failure: https://git.drupalcode.org/issue/acquia_dam-3519247/-/jobs/6071248. I recommend pinning it to Drupal 11.2.2 just like XB does, otherwise you won't have a stable test target.

The crucial new test passes fine locally — well, 3 of the 4 pass:

DDFD                                                                4 / 4 (100%)

Time: 00:53.362, Memory: 16.00 MB

There was 1 failure:

1) Drupal\Tests\experience_builder\Kernel\AcquiaDamHookStoragePropShapeAlterTest::testPropShapesYieldWorkingStaticPropSources
Sample value [{"target_id":"1"},{"target_id":"2"},{"target_id":"3"}] generated by field type entity_reference for type=array&items[$ref]=json-schema-definitions://experience_builder.module/image&items[type]=object is invalid!
Failed asserting that two arrays are identical.
…

The reason? The sample acquia_dam_image_asset media entity that gets randomly generated is invalid. I'll leave that for y'all to solve :)

Per request of @mglaman:

Also, GIF of this in action and showing the ability to seamlessly pick images from the local media library (core's Image extends File media source) and Acquia DAM:

FYI: when 📌 Decouple image (URI) shape matching from specific image file types/extensions Active lands, tests/src/Kernel/AcquiaDamHookStoragePropShapeAlterTest.php() will need to be updated similar to https://git.drupalcode.org/project/experience_builder/-/merge_requests/1....

In fact, I'd recommend doing that now — that's worthwhile hardening already :)

While here, checked where this MR is at. I'm surprised to see:

2) Drupal\Tests\experience_builder\Kernel\AcquiaDamHookStoragePropShapeAlterTest::testUniquePropSchemaDiscovery
Exception: Exception when installing config for module experience_builder, message was: Schema errors for editor.editor.xb_html_block with the following errors: 0 [settings.plugins.ckeditor5_list.properties] 'styles' is a required key.

— https://git.drupalcode.org/issue/acquia_dam-3519247/-/jobs/6072258#L95

I checked my local clone of Drupal 11.2 and the ckeditor5.plugin.ckeditor5_list config schema type definitely does not list a styles key under properties 🤔

The problem: this is currently testing against 11.x, it should be testing against 11.2. Which is the current minor, yet this project's "current" is actually testing against Drupal 10.3. I wonder if this is a problem with https://www.drupal.org/project/gitlab_templates → , or with this project. I haven't touched https://git.drupalcode.org/project/cdn in well over a year, and that is testing against 11.2 🤔

Hope this helps — good luck!