Contrib.social

Automated Drupal 11 compatibility fixes for panelizer

Open on Drupal.org →
Created on 24 March 2024, 9 months ago
Updated 7 May 2024, 8 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

5.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 9 months ago
    Waiting for branch to pass
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !13Automated Project Update Bot fixes → (Open) created by project update bot
  • Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 9 months ago
    Waiting for branch to pass
  • First commit to issue fork.
  • Merge request !15Drupal 11 compatibility. → (Open) created by japerry
  • Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    🇮🇳India vipin.mittal18 Greater Noida
  • First commit to issue fork.
  • Pipeline finished with Failed
    5 months ago
    Total: 304s
    #231212
  • Comment 5 months ago →
    🇮🇳India chandu7929 Pune

    chandu7929 → changed the visibility of the branch project-update-bot-only to hidden.

  • Pipeline finished with Failed
    5 months ago
    Total: 492s
    #231849
  • Pipeline finished with Failed
    5 months ago
    Total: 327s
    #232094
  • First commit to issue fork.
  • Pipeline finished with Failed
    2 months ago
    Total: 401s
    #305910
  • Pipeline finished with Canceled
    2 months ago
    Total: 335s
    #305966
  • Pipeline finished with Failed
    2 months ago
    Total: 373s
    #305971
  • Pipeline finished with Failed
    2 months ago
    Total: 370s
    #305983
  • Comment 2 months ago →
    🇮🇳India chandu7929 Pune
  • Pipeline finished with Failed
    2 months ago
    Total: 504s
    #306912
  • Pipeline finished with Failed
    2 months ago
    Total: 409s
    #306955
  • Pipeline finished with Failed
    2 months ago
    Total: 371s
    #307012
  • Pipeline finished with Failed
    2 months ago
    Total: 772s
    #307026
  • Pipeline finished with Failed
    2 months ago
    Total: 333s
    #307058
  • Pipeline finished with Failed
    2 months ago
    Total: 398s
    #307078
  • Pipeline finished with Failed
    2 months ago
    #309262
  • Pipeline finished with Failed
    2 months ago
    #309271
  • Pipeline finished with Failed
    2 months ago
    #309285
  • Pipeline finished with Failed
    2 months ago
    #309305
  • Pipeline finished with Failed
    2 months ago
    Total: 573s
    #309879
  • Comment 2 months ago →
    🇮🇳India rajeshreeputra Pune

    The test is failing because of the Panels IPE(In Place Editing), see related issue Drupal 11 compatibility fixes for Panels IPE 💬 Drupal 11 compatibility fixes Active .

  • Pipeline finished with Failed
    2 months ago
    Total: 3040s
    #310024
  • Pipeline finished with Failed
    2 months ago
    Total: 543s
    #310077
  • Pipeline finished with Failed
    2 months ago
    Total: 353s
    #311444
  • Pipeline finished with Failed
    2 months ago
    Total: 414s
    #313365
  • Comment 2 months ago →
    🇺🇸United States DamienMcKenna NH, USA

    Great work everyone on this so far.

    The way the composer.json file was changed won't work - you should update the requirement line to allow the dev release or a stable version, then add a require-dev line for the dev version.

    The Panels module's fixes in 💬 Drupal 11 compatibility fixes Active also need to be finished off and committed.

  • Comment 2 months ago →
    🇺🇸United States DamienMcKenna NH, USA
  • Pipeline finished with Failed
    2 months ago
    Total: 586s
    #315694
  • Pipeline finished with Failed
    2 months ago
    Total: 403s
    #315972
  • Pipeline finished with Failed
    2 months ago
    Total: 563s
    #315976
  • Pipeline finished with Failed
    2 months ago
    Total: 448s
    #315988
  • Pipeline finished with Failed
    2 months ago
    Total: 485s
    #316697
  • Comment 2 months ago →
    🇮🇳India vipin.mittal18 Greater Noida

    According to my perspective, it does not make sense to make Panelizer compatible with Drupal 11, since maintainers have already announced no further development and provided upgrade paths to Layout builder. Maintainers are also not supporting D11 compatibility in 4.x version 📌 Drupal 11 compatibility fixes for panelizer [v4] Active .

    @damienmckenna, Could you please let us know if you intend to make D11 compatible and see any values?

  • Comment 2 months ago →
    🇺🇸United States DamienMcKenna NH, USA

    The purpose of Panelizer 5 is to help with the upgrade path to Layout Builder, so we'll continue to support it.

    Panelizer 8.x-4.x is EOL.

  • Comment 2 months ago →
    🇮🇳India vipin.mittal18 Greater Noida

    gotcha. Thanks very much Damien for your prompt confirmation!

  • Comment 2 months ago →
    🇮🇳India rajeshreeputra Pune

    Thank you, @damienmckenna, for pointing out that Panelizer 5 is intended for use with Layout Builder. I will verify the functionality and corresponding tests, and I will remove the Panels IPE-related test, as it is not required.

  • Comment 2 months ago →
    🇮🇳India rajeshreeputra Pune

    Verified Migration functionality with following version and seems like its not working see attacked screenshot.
    Install site with Drupal 10.3, Panelizer 4.5, Panels 4.8
    Upgrade Panelizer 5.0
    Visit Manage dispay:

    • Check Use Layout Builder
    • Click Migrate to Layout Builder
    • Click I understand the risks and have backed up my database. Proceed!

    See following error:

  • Comment 2 months ago →
    🇮🇳India rajeshreeputra Pune

    My opinion here is to fix following issues:
    🐛 Ajax error while adding block Active
    📌 [META] Migration path to Layout Builder Active

  • Comment 2 months ago →
    🇮🇳India ankitv18
  • Comment 2 months ago →
    🇮🇳India rajeshreeputra Pune

    Created separate ticket to update the fixture see 📌 Panelizer - Update fixtures Active .

  • Comment about 2 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-321467

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.6
    2. mglaman/phpstan-drupal: 1.3.1
    3. palantirnet/drupal-rector: 0.20.3
  • Pipeline finished with Failed
    about 2 months ago
    Total: 309s
    #321612
  • Pipeline finished with Failed
    about 2 months ago
    Total: 470s
    #322695
  • Comment about 2 months ago →
    🇮🇳India rajeshreeputra Pune

    @ankitv18 updated the fixture path.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024