🇧🇷Brazil @aluzzardi

Adding a patch to 1.0.4 version.

aluzzardi → created an issue. See original summary → .

Updated it fully to properly check the preivousUrl to avoid issues passing a / to the auth0.

The patch has an issue that the previous URL might be empty.
I added an inter-diff patch to get the current URL.

kristiaanvandeneynde Thanks for explaining!

#10 I did not see the error anymore about the installed version being too old.
But I still see the database updates running after the upgrade from 3.2.2 to 3.3.2
Is that the expected behavior if I'm not upgrading from version 2.x?
My feeling is that upgrades, if needed to run, should check an show a notice/information that they are not running as the current version is already version 3.x

Here the interdiff patch and a fullpatch for the current 2.0 version.

By testing here, seems that the early is causing the issue, it's not allowing to go to the second condition to allow match the RequestPath conditon

if ($context->getContextData()->getValue() === NULL) {
  return FALSE;
}

I changed here for testing:

         if (empty($contexts)) {
            continue;
          }

          $isEmptyContextData = TRUE;
          foreach ($contexts as $context) {
            if ($context->getContextData()->getValue() !== NULL) {
              $isEmptyContextData = FALSE;
            }
          }
          if ($isEmptyContextData) {
            continue;
          }

I will prepare the interdiff and a new patch in a few minutes to send here.

Sorry, I mistyped! They did not show as they should.
When should match the Request Path, is always false and not showing on the page.
Seems that is not properly handling the context for the Request Path condition

Hi, I'm moving this to needs work, after applying the diff with a patch (attached here), the blocks with multiple conditions did show were they should.

I attached the image of my block_visibility_group configuration.

Another important thing is that before you run the composer update --lock remove the library from the libraries folder, otherwise it will not get the updated URL.
Composer need to detect that is missing to download and update the from the new URL.

I tried only the composer update --lock and was still having the issue, if you do not want to remove it, you can go to the composer.lock file and change the URL manually.

Same here.
My suggestion is to move from getting from github and pull it from asset.packagist.org:

https://asset-packagist.org/package/bower-asset/icheck

For now, adding this to you repositories array on your root composer.json should will solve:

    "jquery.icheck": {
      "type": "package",
      "package": {
        "name": "jquery/icheck",
        "version": "1.0.2 ",
        "type": "drupal-library",
        "extra": {
          "installer-name": "jquery.icheck"
        },
        "dist": {
          "url": "https://api.github.com/repos/drgullin/icheck/zipball/8a6eb37bd7dab1e843c1b630c91c6398ff409d05",
          "type": "zip"
        },
        "license": "MIT"
      }
    }

Or replacing the url: https://codeload.github.com/drgullin/icheck/zip/1.0.2/tags/1.0.2
On your composer.lock to: https://api.github.com/repos/drgullin/icheck/zipball/8a6eb37bd7dab1e843c...

Are you sure that this only happens from 2.3 to 3.3?
I have this message when upgrading from 3.2.2 to 3.3.1:

 [error]  The installed version of the /Group/ module is too old to update. Update to
an intermediate version first (last removed version: 9211, installed version:
9210).

And then the upgrades runs:

 -------- ----------- --------------- --------------------------------------------------------------
  Module   Update ID   Type            Description
 -------- ----------- --------------- --------------------------------------------------------------
  gnode    8007        hook_update_n   8007 - Updates views to drop obsolete key.
  group    10300       hook_update_n   10300 - Updates database and fields from Group 2 to Group 3.
  group    10301       hook_update_n   10301 - Updates indexes from Group 2 to Group 3.
  group    10302       hook_update_n   10302 - Updates views from Group 2 to Group 3.
  group    10303       hook_update_n   10303 - Updates views to drop obsolete key.
 -------- ----------- --------------- --------------------------------------------------------------

Those should be running even coming from 3.2 installations?

I applied this but still have the same issue of the wrong URL on the sitemap based on the URL I ran to regenerate it.
Could you explain how this is working by language based on domain?
I tried passing the URI of each on using drush or regenerating via Rebuild tab, no success.

I had that same issue and the patch from #10 worked for me.
It seems related to multilingual, when the language negotiation is configured to use domain instead of path_prefix
I'm on Drupal 10.3.6 with module on 1.3.0

Applying only that patch causes issues, so I'm generating a full patch from 2.0.x to 2.0.1alpha6.

Adding a second patch as I missed one change for the same issue.

I just saw branch 2.x has the fix for that issue already, so I created a patch to apply over 2.0.1alpha6

aluzzardi → changed the visibility of the branch 3479454-php-8.3-deprecations to hidden.

aluzzardi → created an issue.

The current solution seems not to solve the issue if a URL accessing the date field has an invalid date format.
For example, we received this request:

?to_date[date]=../admin/noop.cgi?foo=bar&test=blah

A bot trying to brute force and causing issues, in that case, it throws the same error:

User error: Exception thrown while calling __toString on a Drupal\Core\Datetime\DrupalDateTime object in /var/www/html/docroot/core/lib/Drupal/Component/Datetime/DateTimePlus.php on line 354: DateTime object not set. in Drupal\Component\Datetime\DateTimePlus->__toString() (line 20 of core/lib/Drupal/Component/Utility/ToStringTrait.php).
Drupal\Component\Datetime\DateTimePlus->__toString() (Line: 161)
Drupal\views\Plugin\views\filter\Date->acceptExposedInput(Array) (Line: 184)
Drupal\views\Form\ViewsExposedForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 609)
Drupal\Core\Form\FormBuilder->processForm('views_exposed_form', Array, Object) (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm('\Drupal\views\Form\ViewsExposedForm', Object) (Line: 134)
Drupal\views\Plugin\views\exposed_form\ExposedFormPluginBase->renderExposedForm() (Line: 1304)
Drupal\views\ViewExecutable->build(NULL) (Line: 1457)
Drupal\views\ViewExecutable->execute(NULL) (Line: 1520)
Drupal\views\ViewExecutable->render() (Line: 133)
Drupal\views\Plugin\views\display\Block->execute() (Line: 1696)
Drupal\views\ViewExecutable->executeDisplay('block_3', Array) (Line: 81)
Drupal\views\Element\View::preRenderViewElement(Array) (Line: 61)
Drupal\views\Plugin\Block\ViewsBlock->build() (Line: 106)
Drupal\layout_builder\EventSubscriber\BlockComponentRenderArray->onBuildRender(Object, 'section_component.build.render_array', Object)
call_user_func(Array, Object, 'section_component.build.render_array', Object) (Line: 97)
Drupal\tracer\EventDispatcher\TraceableEventDispatcher->dispatch(Object, 'section_component.build.render_array') (Line: 90)
Drupal\layout_builder\SectionComponent->toRenderArray(Array, ) (Line: 88)
Drupal\layout_builder\Section->toRenderArray(Array) (Line: 331)
Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->buildSections(Object) (Line: 291)
Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->buildMultiple(Array) (Line: 340)
Drupal\Core\Entity\EntityViewBuilder->buildComponents(Array, Array, Array, 'full') (Line: 24)
Drupal\node\NodeViewBuilder->buildComponents(Array, Array, Array, 'full') (Line: 282)
Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array) (Line: 239)
Drupal\Core\Entity\EntityViewBuilder->build(Array)
call_user_func_array(Array, Array) (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 870)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 432)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 238)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 231)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 128)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 97)
Drupal\tracer\EventDispatcher\TraceableEventDispatcher->dispatch(Object, 'kernel.view') (Line: 186)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 263)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 130)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 38)
Drupal\tracer\StackMiddleware\TracesMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I will check to apply a fix for that case too.

Adding patch to be applied on 6.1.4

Add a suggestion for change.

aluzzardi → created an issue.

I updated the patch to work with the new beta5 and created an MR to the dev branch.

I added a branch and a patch that changes only the JS file, seems the failed test as fixed on the main branch already.

aluzzardi → changed the visibility of the branch 2.0.x to hidden.

The new version 2.0.8 does merge this patch, needs work.

That issue is not only happening with images while adding via editor.
We found the same issue if you add a very long URL and click to see the Source Code.
I uploaded a video with the issue.
My quick fix for it was to add a custom css for the .ck.ck-editor via theme:

theme.info.yml
ckeditor5-stylesheets:
    - css/admin/ckeditor-fixes.css

.ck.ck-editor {
  max-width: 960px;
}

It's not the best I belive but should help others for now.

I'm facing the same issue on lightning_core 6.0.0 and the patch did not work for me.

Send a new patch file to be applied on version 1.0.12

aluzzardi → created an issue.

Hi!

This issue seems that been reverted by another commit in this issue: https://www.drupal.org/project/acquia_dam/issues/3398573 📌 Add GitLab CI and Fix issue reported Fixed
We need to reopen it to re-apply.

Hi!

I tested patch #10 with version 2.1.2 and all worked as expected.
I'm moving to reviewed and tested.

I agree with @froboy.
Also, adding the MR diff as a patch to be used while not merged.

Hi! I can confirm that MR solved the issue.
I tested reverted my patch, and seeing the issue happening, then I applied the plain diff from the MR and the error stoped.

Adding a patch to start.

aluzzardi → created an issue.

Just realized that my fix only works for environment with twig debug enabled, I will create a new patch.

Hi,

I created a patch for it, but I needed to validate the boolean fields and set a default 0 value if they are empty.

I attached the patch.

aluzzardi → created an issue.

aluzzardi → created an issue.

I created a patch for it.

aluzzardi → created an issue.

I created a patch that can be applied on beta4.

aluzzardi → created an issue.

Hi,
I was facing that issue, the patch solves it, but it break with the patch for this issue: https://www.drupal.org/project/drupal/issues/3357973 🐛 Grouped exposed taxonomy term filters does not work when input from user is an array. Needs work
This issue: https://www.drupal.org/project/drupal/issues/3357973 🐛 Grouped exposed taxonomy term filters does not work when input from user is an array. Needs work solves both cases, I would say with more testing we can close this issue.

I'm closing this as this seems duplicated from https://www.drupal.org/project/url_redirect/issues/3352036 🐛 Deprecated function getException() in RedirectSubscriber RTBC

I can confirm that this error also happens on Drupal 9.5.10

Adding a patch based on the diff, to avoid getting un-wanted updated/changes.

Add a patch based on the MR diff, to avoid loss or get some un-wanted updated changes.

I created a patch that changed the Dropdown JS file for a quick solution and this only works if the option Enable CDN is disabled on the configs, which will load the local file.
This was created after applying the patches for issues 3350875 and 3342683

I will update the description with a better solution for this.

aluzzardi → created an issue.

Also, you can check this issue:
https://www.drupal.org/project/path_redirect_import/issues/3313386 🐛 Drush updb fails when upgrading from 8.x-1.0 to 2.0.5 Fixed

What solved in my case:
Return back to version 1.0-beta5
Installed version 2 dependencies via composer:
composer require drupal/migrate_tools drupal/migrate_source_csv -W
Enabled these modules:
drush en migrate_tools migrate_source_csv
Then updated this module version to 2.0.6
composer require drupal/path_redirect_import:"^2.0"
Then no error showed anymore.

Does this have a migration path documented?
I tried going from version 1.0-beta5 to version 2.0.6 and this issue is still happening.

I'm changing this to Major priority because we needs to discuss and understand if the correct schema should be updating the URL for the asset or should maintain the original Year/Month of the first time upload.

Does anyone knows if this got merged to the dev and the release 2.0.9 has it?
I was not able to confirm that.

Here is the updated patch to 1.6.0 with the correct requests to clear caches.

I changed Acquia routes to remove the ones that are deprecated by their documentation

The first patch is not working, it's missing send body with the content.
I will adjust and send with some tests.

I'm adding a patch to version 1.6.0 that adds the Options to select all domains or current domain and to log requests and responses.
This patch was created after applying a patch from issue 3308305, I will prepare a clear patch for 1.6.0 later.
I will be working on adding to the fork branch and open an MR.

aluzzardi → created an issue.

aluzzardi → created an issue.