- Issue created by @themarkahrens
- π«π·France vbouchet
Hi Mark,
Thanks for reporting. I have the 1.3.0 version as well and I can't reproduce the issue. Checking at the iframe src, I can see?destination=/layout_builder_iframe_modal/redirect
. When I submit, the modal is properly closed.Which version of Drupal are you using?
- πΊπΈUnited States themarkahrens
We are on Drupal 10.0.5 and seeing the issue.
- πΊπ¦Ukraine Vadym.Tseiko
Hi @vbouchet, I have the same issue here. My project is drupal/core-recommended: 9.5.7. I use drupal/layout_builder_iframe_modal: 1.3.0. At the moment we faced this issue, after adding multilingual functionality via drupal core built-in multilingual functionality. Using language detection via URL by domain. Just as Mark mentioned I tried to change following: 'destination' => Url::fromRoute('layout_builder_iframe_modal.redirect')->toString(TRUE)->getGeneratedUrl(), back to 'destination' => '/layout_builder_iframe_modal/redirect', and it works fine in that case. When I work with iframe without multilingual changes everything works fine.
- πΊπΈUnited States themarkahrens
I can confirm that our site is multilingual as well.
- π¨π¦Canada dylan donkersgoed London, Ontario
Dylan Donkersgoed β made their first commit to this issueβs fork.
- π¨π¦Canada dylan donkersgoed London, Ontario
Same issue here, also on a multilingual site. I've opened a branch with the fix. It doesn't seem to want to let me open an MR right this second, but I'm attaching a patch with the fix.
This fix basically just switches the generated URL to be relative. I'm not sure what the reason for the original change was so not sure this is an acceptable solution or if an absolute URL is actually needed. But it does solve the issue.
- Status changed to Needs review
over 1 year ago 8:49pm 26 October 2023 - π§π·Brazil aluzzardi Pelotas, RS
I had that same issue and the patch from #10 worked for me.
It seems related to multilingual, when the language negotiation is configured to use domain instead of path_prefix
I'm on Drupal 10.3.6 with module on 1.3.0 - Merge request !19Added fix for issue where updating modal would cause full page refresh inside... β (Open) created by Taran2L
- First commit to issue fork.
- Status changed to Postponed: needs info
about 1 month ago 7:41am 5 March 2025 - π§πͺBelgium svendecabooter Gent
This patch & MR no longer apply to the current 1.3.x state.
I have also tested on a multilingual site (with paths instead of domains configured though), and cannot reproduce the issue.
Can people who encountered this, retest with the latest version of this module, and report back if the problem still exists? - πΊπΈUnited States themarkahrens
I tested this with 1.3.5 on Drupal 10.4.3 and it does appear to be working correctly now. I will let other folks test as well before closing this issue.