- Issue created by @ydahi
- π§π·Brazil aluzzardi Pelotas, RS
The patch from #2 can be applied to dev, it's not doing what needs for some functions but helps to install the module.
- First commit to issue fork.
- Merge request !26Increase version requirement for h5p/h5p-core so that H5PDrupal.php is... β (Open) created by shaundychko
- π¨π¦Canada shaundychko
The merge request adds to the provided patch by also increasing the version requirement of h5/h5p-core in composer.json in order to automatically retrieve a version of \H5PFrameworkInterface that is compatible with the updated H5PDrupal class.
- π¨π¦Canada ydahi Waterloo, Canada
Still a lot more to be done.
One current hang-up is the new metadata field introduce in h5p-core:1.27: a11y_title
Updating to core:1.27 means that existing h5p cannot be saved/updated.
- π¨π¦Canada ydahi Waterloo, Canada
The merge request adds to the provided patch by also increasing the version requirement of h5/h5p-core in composer.json in order to automatically retrieve a version of \H5PFrameworkInterface that is compatible with the updated H5PDrupal class.
MR26: h5p/h5p-core 1.24.4 is still installing even with bumping the requirement to 1.27 as in this MR. I think this is because the compose.lock is set to 1.24.4.
To circumvent:
cd web/module/contrib/h5p composer update
This installs h5p-core 1.27 and h5p-editor 1.25
- π¨π¦Canada shaundychko
Yes, the composer.lock would have that effect of locking the version despite changing composer.json. That issue didn't show up for me since I also applied π Remove vendor directory and composer.lock from project repository Active . The vendor dependencies should not be committed to the module.
- πΊπΈUnited States NicholasS
Can someone explain more about the a11y_title, I am not seeing it when editing H5P content. But it does run the update just fine, just don't want to say this is reviewed without understanding the a11y_title.
I was able to update and save a hotspot that previously existed. So maybe that is enough testing.
-------- ----------- --------------- --------------------------------------------------------------------------- Module Update ID Type Description -------- ----------- --------------- --------------------------------------------------------------------------- h5p 8005 hook_update_n 8005 - Update hook to modify the database schema to include 'a11y_title'. -------- ----------- --------------- --------------------------------------------------------------------------- // Do you wish to run the specified pending updates?: yes. > [notice] Update started: h5p_update_8005 > [notice] Update completed: h5p_update_8005 [success] Finished performing updates.
- π¨π¦Canada ydahi Waterloo, Canada
The new field introduced in the newer h5p editor version is called "Assistive Technologies label". It's in the metadata modal. Screenshot attached.
- Status changed to Needs review
8 days ago 3:56pm 8 May 2025 - π¬π§United Kingdom catch
I just tried a fresh install of h5p via composer, and it brought in h5p 1.27 and h5p/h5p-editor 1.25, which of course resulted in a fatal error due to the incompatibility in the H5PDrupal class.
It would have been useful to get feedback from H5P developers on this issue, however it's been open for five months already without comment. The MR looks good, tested the upgrade path etc.
I'm going to go ahead and commit this to 2.0.x. Not planning to do a release on that branch for a little while, so there will be time to follow-up with any remaining fixes after this gets wider testing on dev.
- π¬π§United Kingdom catch
Moving this to fixed - please open follow-ups for any remaining issues as a result of the library upgrade.