- Merge request !18Issue #3279492: Remove no-gutters class from templates โ (Open) created by Abdullah Yassin
- ๐ฎ๐ณIndia rinku jacob 13 Kerala
I have Reviewed merge request !18. Merge request helped to remove no-gutter classes from template and replace it with gx-0. Need RTBC+1
- ๐บ๐ธUnited States rhovland Oregon
Tested on my Bootstrap 5 based site. Setting no gutters now functions as expected.
I'm not sure if the version configuration item is really needed though? Why not set both classes? The one that matches the current bootstrap version will work, the other won't do anything.
Are there other differences between them that apply to this module, not bootstrap_styles, that would benefit from the version configuration item?
- Status changed to RTBC
8 months ago 6:28pm 11 April 2024 - ๐ง๐ทBrazil aluzzardi Pelotas, RS
Hi!
I tested patch #10 with version 2.1.2 and all worked as expected.
I'm moving to reviewed and tested. - ๐ง๐ทBrazil mabho Rio de Janeiro, RJ
Guys, this thing is essentially done. Although the comment by @rhovland does make sense if we have a more strict focus on the particular problem covered by this issue queue, the Bootstrap selector makes sense if other class name conflicts arise in the future (requiring us to apply additional conditions based on the framework version).
We should sign, seal, and deliver this thing so we don't need to keep applying this same patch over and over.
- ๐ฏ๐ดJordan Rajab Natshah Jordan
rajab natshah โ made their first commit to this issueโs fork.
- Status changed to Needs work
3 months ago 5:26pm 15 September 2024 - ๐ฏ๐ดJordan Rajab Natshah Jordan
- Add Schema item for
bootstrap_version
- Needs a hook update to update old settings
- Add Schema item for
- Status changed to Needs review
3 months ago 2:47pm 19 September 2024