Remove no-gutters class from templates

Created on 9 May 2022, over 2 years ago
Updated 19 September 2024, 3 months ago

Problem/Motivation

Remove no-gutters from twig templates in order to make it compatible with Bootstrap 5.

Steps to reproduce

Open twig templates and search about no-gutters class.

Proposed resolution

Open twig templates and search about no-gutters class and replace it with gx-0

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ› Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

๐Ÿ‡ฏ๐Ÿ‡ดJordan Abdullah Yassin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia rinku jacob 13 Kerala

    I have Reviewed merge request !18. Merge request helped to remove no-gutter classes from template and replace it with gx-0. Need RTBC+1

  • ๐Ÿ‡ง๐Ÿ‡ทBrazil andre.bonon

    Attaching a patch to use in composer.json

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States rhovland Oregon

    Tested on my Bootstrap 5 based site. Setting no gutters now functions as expected.

    I'm not sure if the version configuration item is really needed though? Why not set both classes? The one that matches the current bootstrap version will work, the other won't do anything.

    Are there other differences between them that apply to this module, not bootstrap_styles, that would benefit from the version configuration item?

  • Status changed to RTBC 8 months ago
  • ๐Ÿ‡ง๐Ÿ‡ทBrazil aluzzardi Pelotas, RS

    Hi!

    I tested patch #10 with version 2.1.2 and all worked as expected.
    I'm moving to reviewed and tested.

  • ๐Ÿ‡ง๐Ÿ‡ทBrazil mabho Rio de Janeiro, RJ

    Guys, this thing is essentially done. Although the comment by @rhovland does make sense if we have a more strict focus on the particular problem covered by this issue queue, the Bootstrap selector makes sense if other class name conflicts arise in the future (requiring us to apply additional conditions based on the framework version).

    We should sign, seal, and deliver this thing so we don't need to keep applying this same patch over and over.

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan Rajab Natshah Jordan

    rajab natshah โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Needs work 3 months ago
  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan Rajab Natshah Jordan
    1. Add Schema item for bootstrap_version
    2. Needs a hook update to update old settings
  • Status changed to Needs review 3 months ago
Production build 0.71.5 2024