I can confirm that the patch on #7 fixes the problem for Drupal 10.4.x as well.
I can confirm that the patch on #2 fixes the problem for 10.4.x
I needed to fix this in my current project so I have created a MR using the @kushagra.goyal solution.
I'm also adding a patch for Core version 10.4.x.
@kushagra.goyal What if all the code related to .indention and .tree classes was moved to the new indentation.pcss.css file?
It looks like this block of code can be completely extracted from the tabledrag.css file.
/* *
* @file
* Styles for custom indentation and tree item visibility for view access.
*/
/**
* Indentation.
*/
.indentation {
position: relative;
inset-inline-start: calc(var(--space-xs) * -0.5);
float: left; /* LTR */
width: 25px;
height: 25px;
background: none !important;
line-height: 0;
@nest .tabledrag-cell-content & {
/* Fixes Safari bug (16.1 at least) where table rows are overly large when
using indentation (e.g. re-ordering menu items. */
display: inline-flex;
float: none;
overflow: hidden;
flex-direction: column;
height: 100%;
}
@nest [dir="rtl"] & {
float: right;
}
}
/**
* Tree is the visual representation for the simultaneously moved draggable
* rows.
*
* These rules are styling the inline SVG that is placed inside the .indentation
* element.
*/
.tree {
width: 25px;
height: 25px;
}
.tree__item {
display: none;
}
/* LTR tree child. */
.tree-child path {
&:not(.tree__item-child-ltr) {
display: none;
}
&.tree__item-child-ltr {
display: block;
}
}
/* RTL tree child. */
[dir="rtl"] {
& .tree-child path {
&:not(.tree__item-child-rtl) {
display: none;
}
&.tree__item-child-rtl {
display: block;
}
}
/* Last RTL tree child. */
& .tree-child-last path {
&:not(.tree__item-child-last-rtl) {
display: none;
}
&.tree__item-child-last-rtl {
display: block;
}
}
}
/* Last LTR tree child. */
.tree-child-last path {
&:not(.tree__item-child-last-ltr) {
display: none;
}
&.tree__item-child-last-ltr {
display: block;
}
}
/* Horizontal line. */
.tree-child-horizontal path {
&:not(.tree__item-horizontal) {
display: none;
}
&.tree__item-horizontal {
display: block;
}
}
I have tested your suggestion and I can confirm it's working fine.
I noticed that the Promotion Type field is not being hidden in this particular scenario:
- Enable the registration
- Enable the waitlist
- Disable the registration
I added another state condition in the promotion_type field to consider the registration checkbox.
brunoalmeida β made their first commit to this issueβs fork.
brunoalmeida β created an issue.
I can confirm that the Merge request !899 is working for Drupal core version 10.4.1
I tested the #16 patch using the 10.3.7 core version and it's working.
The patch #9 solved the problem here.
brunoalmeida β created an issue.
The MR has been updated.
This is a Facets module issue: https://www.drupal.org/project/facets/issues/3463418 π Better Exposed Filters: Facets methods declarations must be compatible with FilterWidgetBase methods. Needs review
Adding a patch for the 3.0.0-beta1 version.
brunoalmeida β changed the visibility of the branch 3463418-better-exposed-filters to hidden.
brunoalmeida β created an issue.
brunoalmeida β created an issue.
_KASH_ could you please attach a screenshot of your field with this widget? I changed the widget from chosen to Autocomplete (Tag style) and it's working as expected here.
This issue happens when the Drupal field wrapper has a select and an input field. That's the typical scenario when using the "chosen" library, 'cos it will have the select default field plus the "chosen" html inputs. The DomClient._getInputType is getting lost 'cos it will find first a select and after an input, which will make the function return 'undefined' causing the error mentioned above. I created a 'else if' condition to avoid this issue.
Hi _randy!
Yes, your approach also solves the problem.
Thanks!
brunoalmeida β created an issue.
I have tested the last changes and I can confirm it's working.
I'm also adding a patch for the 10.1.6 core version.
I can confirm that the patch works as expected.
brunoalmeida β created an issue.
brunoalmeida β created an issue.
brunoalmeida β created an issue.
I have reviewed and tested MR!9 and it fixes the issue during the module installation.
brunoalmeida β created an issue.
brunoalmeida β created an issue.
brunoalmeida β created an issue.
brunoalmeida β created an issue.
Thank you samit.310@gmail.com and Charchil Khandelwal, I will review the MR.