PHP 8.3 dynamic properties deprecated warnings

The patch for v2.0.0-alpha4

Added fix for h5peditor.class.php

Automatically closed - issue fixed for 2 weeks with no activity.

The code has never been changed as per this issue.

#4 worked for me, thanks!

I am working here.

I created MR 25 related to it. Checked module code with Drupal 11 setup. At now I committed changes related to the issue only, for Drupal 11 compatibility, there is another issue available related to this project. Changing this issue status to Needs review.

I'm having more issues too just after requiring the project on the composer:

  Deprecated: Optional parameter $prefix declared before required parameter $defaultLanguage is implicitly treated as a required parameter in /var/www/vendor/h5p/h5p-editor/h5peditor.class.php on line 376

  Deprecated: Optional parameter $fileDir declared before required parameter $defaultLanguage is implicitly treated as a required parameter in /var/www/vendor/h5p/h5p-editor/h5peditor.class.php on line 376

This issue could also be fixed by just updating the h5p library right to something newer than 1.24.4 ?

If on Version: 2.0.0-alpha4 add the following patches to your extras in composer.json

"h5p/h5p-editor": {
      "PHP8 notice https://www.drupal.org/project/h5p/issues/3260094": "https://www.drupal.org/files/issues/2022-01-24/Update_H5P-editor_PHP8_compatible.patch",
    "php83 https://www.drupal.org/project/h5p/issues/346465": "https://www.drupal.org/files/issues/2025-01-13/h5p-editor83.patch"
},
"h5p/h5p-core": {
     "php83 https://www.drupal.org/project/h5p/issues/346465": "https://www.drupal.org/files/issues/2025-01-13/h5p-core83.patch"
},

Until the maintainers can get the upstream h5p library updated, watch https://www.drupal.org/project/h5p/issues/3420268 🐛 Support h5p/h5p-core:1.26 and h5p/h5p-editor:1.25 Needs work

This patch fixes issues in an old version of the h5p/h5p-core dependency. That has already been fixed in later versions of the dependency. To use the latest version of the dependencies apply patches from the merge requests at 💬 Support h5p/h5p-core 1.27 and h5p/h5p-editor 1.25 in H5PDrupal.php Active and 📌 Remove vendor directory and composer.lock from project repository Active . The latter adds a build step using Drush to copy the current version of JS/CSS assets into the module directory.