- Issue created by @shaundychko
- Merge request !16Remove composer autoloader and h5p-core and h5p-editor php files. Make module... β (Open) created by shaundychko
- Status changed to Needs review
10 months ago 11:13pm 8 February 2024 - π¨π¦Canada shaundychko
ShaunDychko β changed the visibility of the branch 3420268-support-h5ph5p-core1.26-and to hidden.
- π¨π¦Canada shaundychko
Here's a patch file for composer to automatically apply.
- π¨π¦Canada shaundychko
The previous patch created using
git diff
didn't apply correctly. The patch in comment #8 was created usinggit format-patch
. - π¨π¦Canada shaundychko
The embed.php files needs to still be in the module's /vendor/h5p/h5p-core directory since a reference to it is hardcoded in
\Drupal\h5p\Controller\H5PEmbed
. - π¨π¦Canada shaundychko
'git format-patch' output this as two separate patch files that need to be applied in sequence, starting with support-h5p-1.26-3420268-10-1.patch.
- Status changed to Needs work
8 months ago 1:12pm 28 April 2024 - πΊπΈUnited States SocialNicheGuru
No longer applies after π Allow update to H5P editor/core 1.25 Fixed
- πΊπΈUnited States SocialNicheGuru
The MR introduces files back to the h5p/vendor directory that I thought were being deleted.
- π«π·France florian.turc
Hi @shaundychko β ,
Thank you for this patch.
I succeed to install it, but he didn't want to work on its own. I have to copy the file h5p-table.css
(from project root, at the same level than the web folder: cp -pr vendor/h5p/h5p-core/styles/h5p-table.css web/modules/contrib/h5p/vendor/h5p/h5p-core/styles/.).After that, I can download and add a H5P file from the H5P editor (in this case, a field in a Paragraph).
Nevertheless, I have the impression that after clearing all caches, I need to copy again the h5p-table.css file to make it work again.
Did I miss something in my installation?My configuration: PHP 8.3.9, D10.3.6, H5P 2.0.x-dev, h5p/h5p-core 1.27.0, h5p/h5p-editor 1.25
- πΊπΈUnited States sim_1
Creating a patch from the current MR worked for me. I also then required h5p/h5p-core: "^1.25" and h5p/h5p-editor:"^1.25" in my root composer.json. This allowed me to update to core 1.27 and now I can install and use course presentation and other previously blocked types. Is the plan for people to specify the version of core they want to use?