Support h5p/h5p-core:1.26 and h5p/h5p-editor:1.25

ShaunDychko → changed the visibility of the branch 3420268-support-h5ph5p-core1.26-and to hidden.

Here's a patch file for composer to automatically apply.

The previous patch created using git diff didn't apply correctly. The patch in comment #8 was created using git format-patch.

The embed.php files needs to still be in the module's /vendor/h5p/h5p-core directory since a reference to it is hardcoded in \Drupal\h5p\Controller\H5PEmbed.

'git format-patch' output this as two separate patch files that need to be applied in sequence, starting with support-h5p-1.26-3420268-10-1.patch.

Consolidate patches into 1 file.

No longer applies after 📌 Allow update to H5P editor/core 1.25 Fixed

The MR introduces files back to the h5p/vendor directory that I thought were being deleted.

Hi @shaundychko → ,
Thank you for this patch.
I succeed to install it, but he didn't want to work on its own. I have to copy the file h5p-table.css
(from project root, at the same level than the web folder: cp -pr vendor/h5p/h5p-core/styles/h5p-table.css web/modules/contrib/h5p/vendor/h5p/h5p-core/styles/.).

After that, I can download and add a H5P file from the H5P editor (in this case, a field in a Paragraph).

Nevertheless, I have the impression that after clearing all caches, I need to copy again the h5p-table.css file to make it work again.
Did I miss something in my installation?

My configuration: PHP 8.3.9, D10.3.6, H5P 2.0.x-dev, h5p/h5p-core 1.27.0, h5p/h5p-editor 1.25

Creating a patch from the current MR worked for me. I also then required h5p/h5p-core: "^1.25" and h5p/h5p-editor:"^1.25" in my root composer.json. This allowed me to update to core 1.27 and now I can install and use course presentation and other previously blocked types. Is the plan for people to specify the version of core they want to use?

Since the h5p module's composer.json specifies dependencies on "h5p/h5p-core": "1.24.2" and "h5p/h5p-editor": "1.24.4", it prevents me from using composer require in the main composer.json file to specify newer versions like "h5p/h5p-core": "^1.25" and "h5p/h5p-editor": "^1.25".

@sim_1, how did you manage to override or work around this dependency restriction?

This issue is outdated. The patch here is trying to two things at once: remove the vendor directory, and update the h5p dependencies. This is too much for one patch since opinions might vary on how the vendor directory should be removed, whereas updating the h5p dependencies should be needed by most sites by now due to current versions of PHP not supporting older versions of h5p/h5p-core without warnings.

Apply the patches from the merge requests from 📌 Remove vendor directory and composer.lock from project repository Active , and 💬 Support h5p/h5p-core 1.27 and h5p/h5p-editor 1.25 in H5PDrupal.php Active .