Support h5p/h5p-core:1.26 and h5p/h5p-editor:1.25

Created on 8 February 2024, 5 months ago
Updated 8 June 2024, 18 days ago

Problem/Motivation

h5p-core version 1.26 breaks upon installation since the \Drupal\h5p\H5PDrupal\H5PDrupal::fetchExternalData doesn't implement the correct function signature in the \H5PFrameworkInterface interface in h5p/h5p-core:1.26.

Proposed resolution

Update the function signature. Also, there are four additional methods related to the H5P content hub that need to be implemented. The attached patch just created stubs for those methods in order to permit installation.

In order to address the issue of composer dependencies being duplicated in the project root /vendor, and in this module's ../h5p/vendor/... directory, this merge request also manually deleted the autoloader and all PHP files in the dependencies included with the module. The composer.lock file is left intact and the composer.json is constrained to a specific version since the dependency installed to the project's /vendor/ needs to match the JS and CSS included with module.

Remaining tasks

Test the merge request.

πŸ› Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada ShaunDychko

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024