- Issue created by @dmundra
- 🇺🇸United States dmundra Eugene, OR
The 1.0.3 and 1.0.2 releases on https://github.com/drgullin/icheck/releases are returning 404s. Might need a work around.
- 🇧🇷Brazil aluzzardi Pelotas, RS
Same here.
My suggestion is to move from getting from github and pull it from asset.packagist.org:https://asset-packagist.org/package/bower-asset/icheck
For now, adding this to you repositories array on your root composer.json should will solve:
"jquery.icheck": { "type": "package", "package": { "name": "jquery/icheck", "version": "1.0.2 ", "type": "drupal-library", "extra": { "installer-name": "jquery.icheck" }, "dist": { "url": "https://api.github.com/repos/drgullin/icheck/zipball/8a6eb37bd7dab1e843c1b630c91c6398ff409d05", "type": "zip" }, "license": "MIT" } }
Or replacing the url: https://codeload.github.com/drgullin/icheck/zip/1.0.2/tags/1.0.2
On your composer.lock to: https://api.github.com/repos/drgullin/icheck/zipball/8a6eb37bd7dab1e843c... - 🇺🇸United States dmundra Eugene, OR
GitHub issue https://github.com/drgullin/icheck/issues/440
Thanks @aluzzardi. I will try that.
- 🇺🇸United States dmundra Eugene, OR
Attaching a patch of the MR https://git.drupalcode.org/project/webform/-/merge_requests/561
- 🇺🇸United States dmundra Eugene, OR
Adding the package to composer.json didn't work because the wikimedia/composer-merge-plugin would still override with the webform version.
The patching of the upstream file in the webform module also didn't work for our project as the patch is applied to late.
- 🇺🇸United States kmonty San Francisco, CA
Not to hijack this, but this would be a good opportunity to upgrade to 1.0.3 as well. The release being used with iCheck is from 2014.
- 🇺🇸United States rkelbel48
Yep same,
Swapping over the url to https://api.github.com/repos/drgullin/icheck/zipball/8a6eb37bd7dab1e843c...
mentioned in #3 worked for me as well. - 🇺🇸United States lhridley
Ran into the same issue on a client project today. In my case, the only submodule of the Webform module that was actualy being used was the
webform_toggle
module, which depends on thejquery/toggles:^4.0
library.But the client had included the entire
composer.libraries.json
file from the Webform module in their main projectcomposer.json
file, which proved problematic to just remove.Here's how I solved this issue:
1. I reviewed the webform submodules that were enabled on the site, and identified the javascript libraries that were actually being used in the project.
2. I removed the webform module from thecomposer.json
file withcomposer remove drupal/webform
3. I then deleted the merge-plugin include for the webformcomposer.libraries.json
file from the project's maincomposer.json
file, and then executedcomposer update --lock
4. I then reinstalled the webform module withcomposer require drupal/webform:^6.2
5. I took the package repository reference from the webformcomposer.libraries.json
file and placed it in the "repositories" section of the maincomposer.json
file for the project, and rancomposer update --lock
6. I then executedcomposer require >jquery/toggles:^4.0
to install the javascript library needed for the submodule to operate.Opened a pull request against the project, and the client merged it in late this evening.
This step by step process should work for any project EXCEPT the
jquery/icheck
library, The issue at hand is that the archive zip and tarball files for the release required by the Webform's composer.libraries.json file are missing from Github. Version 1.0.1 however, still has the release zip and tarbal files on Github, so you could include thejquery/icheck
package repository reference, change the version to 1.0.1 instead of 1.0.2, and you should get a workable javascript library. Check the release notes for the 1.0.1 vs 1.0.2 release to see what changed before you do.For safety's sake, just in case the release tarbal and zip files gets removed for release 1.0.1, you might consider manually installing the library into your project's library directory and committing the source code to your code repository to keep from losing it again. Just a thought.
Hope this helped someone.
- 🇺🇸United States smustgrave
Think this can be elevated as this is probably breaking a number of pipelines.
- 🇵🇭Philippines mjgruta
FYI, if you already have a composer.lock file. The patch will not work so you need to override it by adding this code to your composer.json or better if you have composer.libraries.json file then add this on the require section "jquery/icheck": "1.0.2".
After this just run composer require drupal/webform:^6.2 or what ever version you would like. This will generate the correct composer lock hash."jquery.icheck": {
"type": "package",
"package": {
"name": "jquery/icheck",
"version": "1.0.2 ",
"type": "drupal-library",
"extra": {
"installer-name": "jquery.icheck"
},
"dist": {
"url": "https://api.github.com/repos/drgullin/icheck/zipball/8a6eb37bd7dab1e843c...",
"type": "zip"
},
"license": "MIT"
} - 🇪🇸Spain omarlopesino
Looks like as the username changed from dargullin to drgullin the download links are broken. Seems a temporary issue.
Alternatively to the patch, I suggest another solution that is only valid when the library is not being used in the project: adding the library to replace.
For example:"replace": { "jquery/icheck": "*" },
- 🇩🇪Germany yannickoo Berlin
FYI after applying the patch it was needed to run
composer update jquery/icheck
so that the new URL of the libraries is changed incomposer.lock
file as well ✨ - 🇦🇹Austria daniel.pernold
We are using projects with OpenSocial and are therefore stuck with Webform 6.1.8 atm. The only solution that works for us in this case is placing the following in our
composer.json
."repositories": [ { "type": "package", "package": { "name": "jquery/icheck", "version": "1.0.2", "type": "drupal-library", "extra": { "installer-name": "jquery.icheck" }, "dist": { "url": "https://github.com/drgullin/icheck/archive/refs/heads/1.0.2.zip", "type": "zip" } } } ]
- 🇬🇧United Kingdom Mattgh9152
#14 also worked for me, #19 did not work even though I was on webforms 6.2
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
RE #10 It might be better to look into deprecating/replacing the use of this. It really looks abandoned as there has been no activity for over 4 years on the project since the last release.
- First commit to issue fork.
-
jrockowitz →
committed 547f9842 on 6.3.x authored by
dmundra →
Issue #3489710: dargullin/icheck is returning a 404
-
jrockowitz →
committed 547f9842 on 6.3.x authored by
dmundra →
- 🇺🇸United States jrockowitz Brooklyn, NY
I am going to merge this and backport it to 6.2.x
-
jrockowitz →
committed 547f9842 on 6.x authored by
dmundra →
Issue #3489710: dargullin/icheck is returning a 404
-
jrockowitz →
committed 547f9842 on 6.x authored by
dmundra →
- 🇺🇸United States luke.leber Pennsylvania
+1 on deprecating the library.
The maintainer was explicitly presented with a dialog explaining what changing their username entails. They chose to do this despite the warnings about downstream chaos it would create.
To me, that means they probably shouldn't be an upstream dependency if such a change was made on a whim in this age of supply chain attacks.
- 🇨🇦Canada JayDarnell Guelph, Ontario
#14 worked for me on Webform 6.2.7. Thanks!
Oh, and hi dmundra!
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I created a follow up to try to deprecate the use of this plugin. (RE #32 & #25)
📌 Deprecate the use of drgullin/icheck Active
- 🇺🇸United States dmundra Eugene, OR
Hey @jaydarnell
Thank you @jrockowitz for merging and releasing a new version. Appreciate that.
- 🇺🇸United States tony.sayge Kansas City
@jrockowitz thank you so much for releasing a new version! Huge time-saver.
- 🇨🇦Canada TrevorBradley
6.2.8 doesn't include https://www.drupal.org/files/issues/2024-11-26/webform-icheck-library-is... → .
I'm still getting deploy fails with the call in webform_icheck.module:
In CurlDownloader.php line 641: The "https://codeload.github.com/drgullin/icheck/zip/1.0.2/tags/1.0.2" file could not be downloaded (HTTP/2 404 )
function webform_icheck_webform_libraries_info() { $libraries = []; $libraries['jquery.icheck'] = [ 'title' => t('jQuery: iCheck'), 'description' => t('Highly customizable checkboxes and radio buttons.'), 'notes' => t('iCheck is used to optionally enhance checkboxes and radio buttons.'), 'homepage_url' => Url::fromUri('http://icheck.fronteed.com/'), 'download_url' => Url::fromUri('https://github.com/dargullin/icheck/archive/refs/tags/1.0.2.zip'), 'version' => '1.0.2 ', 'optional' => FALSE, 'deprecated' => t('The iCheck library is not being maintained. It has been <a href=":href">deprecated</a> and will be removed in Webform 7.0.', [':href' => 'https://www.drupal.org/project/webform/issues/2931154']), 'license' => 'MIT', ]; return $libraries; }
Trying to patch webform in addition to the 6.2.8 update to see if that fixes the issue...
- 🇨🇦Canada TrevorBradley
Nope, user error here. webform_icheck_webform_libraries_info() is just fine (especially when uninstalled).
Folks, a note it's important to run a composer update --lock to make sure composer.lock correctly links to the right library.
- 🇧🇷Brazil aluzzardi Pelotas, RS
Another important thing is that before you run the composer update --lock remove the library from the libraries folder, otherwise it will not get the updated URL.
Composer need to detect that is missing to download and update the from the new URL.I tried only the composer update --lock and was still having the issue, if you do not want to remove it, you can go to the composer.lock file and change the URL manually.
- 🇨🇦Canada pierre paul lefebvre
I was curious if I could create a github account with the previous username, then create a new repository with the same name with the same tags. Turns out github blocks you at the repository creation (user creation worked). Which is good, anyone could have bundled anything in that package.
- 🇳🇱Netherlands Dimiter
I just wanted to mention that the solution of #20 by @yannickoo → works fine when still receiving 404-errors after updating Webform to 6.2.8 :
FYI after applying the patch it was needed to run composer update jquery/icheck so that the new URL of the libraries is changed in composer.lock file as well ✨
- 🇺🇸United States dmundra Eugene, OR
FYI, I had reached out to GitHub support about this issue and they fixed the original 404 for the URLs so https://github.com/dargullin/icheck/archive/refs/tags/1.0.2.zip should be working again.
Automatically closed - issue fixed for 2 weeks with no activity.