Account created on 3 September 2018, over 6 years ago
#

Merge Requests

Recent comments

🇦🇹Austria daniel.pernold

Another issue has cropped up with the same source, this time with the RestUI module. I'm using this ticket to fix it here.

Error: Cannot use object of type Drupal\Core\StringTranslation\TranslatableMarkup as array in Drupal\config_readonly\EventSubscriber\ReadOnlyFormSubscriber->getConfigTargetNames() (line 167 of modules/contrib/config_readonly/src/EventSubscriber/ReadOnlyFormSubscriber.php).

Drupal\config_readonly\EventSubscriber\ReadOnlyFormSubscriber->onFormAlter(Object, 'config_readonly_form_event', Object)
call_user_func(Array, Object, 'config_readonly_form_event', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'config_readonly_form_event') (Line: 21)
config_readonly_form_alter(Array, Object, 'restui') (Line: 552)
Drupal\Core\Extension\ModuleHandler->alter('form', Array, Object, 'restui') (Line: 834)
Drupal\Core\Form\FormBuilder->prepareForm('restui', Array, Object) (Line: 285)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Patch in this issue fork:

https://git.drupalcode.org/issue/config_readonly-3469854/-/commit/12ac22...

🇦🇹Austria daniel.pernold

My profiling has shown that it is mainly the access checks on the menu items that cause the problem in our projects. If we reduce the depth of the toolbar from 4 to 3, the performance increases significantly.

/admin/config/user-interface/admin-toolbar -> set 3 here

The time is spent here: https://git.drupalcode.org/project/admin_toolbar/-/blob/3.x/src/Render/E...

The same applies, of course, to the analogous implementation in the Gin Toolbar (and any other):
https://git.drupalcode.org/project/gin_toolbar/-/blob/8.x-1.x/src/Render...

Generally, if you uninstall the module, there is a huge performance jump.

Module INSTALLED:

Module UNINSTALLED:

🇦🇹Austria daniel.pernold

We are using projects with OpenSocial and are therefore stuck with Webform 6.1.8 atm. The only solution that works for us in this case is placing the following in our composer.json.

    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "jquery/icheck",
                "version": "1.0.2",
                "type": "drupal-library",
                "extra": {
                    "installer-name": "jquery.icheck"
                },
                "dist": {
                    "url": "https://github.com/drgullin/icheck/archive/refs/heads/1.0.2.zip",
                    "type": "zip"
                }
            }
        }
    ]
🇦🇹Austria daniel.pernold

You are right jurgenhaas. It was a custom action plugin. Issue can be closed.

🇦🇹Austria daniel.pernold

I have committed a patch that checks if the array key `#config_target` is of type `ConfigTarget` and if so, extracts the name from it. I think this is the proper approach since the buttons of the discussed forms then gets correctly disabled.

🇦🇹Austria daniel.pernold

I agree with @graber, Patch #51 "ignores" the group permission when the group is not in context. Modules like VBO has to provide group context on their own if they want to provide group permissions.

🇦🇹Austria daniel.pernold

But: this issue is not related to the taxonomy manager. I am facing the same issue with taxonomy manger uninstalled. I guess this is a core issue, where other reference methods get selected when the currently chosen reference method is "default" in the database. This seems to be a selection issue of the default value in the widget.

🇦🇹Austria daniel.pernold

Same here, ECA destroys the selected reference method and therefore the configuration for the field upon saving. This is a major issue at the moment in our projects.

🇦🇹Austria daniel.pernold

I'm experiencing the same issue. On my side, it is reproducable. After rebuilding the cache with Drush, the listener for my desired event is gone. \Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch does not return the event since it is not in the listener array. After editing the Rule and adding another random event, the desired event is being fired.

Patch #156 solves the issue.

🇦🇹Austria daniel.pernold

Sorry, patch #2 is broken. Fixed.

🇦🇹Austria daniel.pernold

I think this is related:

Warning: Trying to access array offset on value of type null in Drupal\doc_serialization\Encoder\Docx->encode() (line 85 of modules/contrib/doc_serialization/src/Encoder/Docx.php).

Stacktrace:

Drupal\doc_serialization\Encoder\Docx->encode(Array, 'docx', Array) (Line: 43)
Symfony\Component\Serializer\Encoder\ChainEncoder->encode(Array, 'docx', Array) (Line: 416)
Symfony\Component\Serializer\Serializer->encode(Array, 'docx', Array) (Line: 141)
Symfony\Component\Serializer\Serializer->serialize(Array, 'docx', Array) (Line: 143)
Drupal\rest\Plugin\views\style\Serializer->render() (Line: 435)
Drupal\rest\Plugin\views\display\RestExport->Drupal\rest\Plugin\views\display\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 434)
Drupal\rest\Plugin\views\display\RestExport->render() (Line: 76)
Drupal\doc_serialization\Plugin\views\display\WordExport->render() (Line: 1592)
Drupal\views\ViewExecutable->render() (Line: 426)
Drupal\rest\Plugin\views\display\RestExport->execute() (Line: 1689)
Drupal\views\ViewExecutable->executeDisplay('word_export_1', Array) (Line: 81)
Drupal\views\Element\View::preRenderViewElement(Array)
call_user_func_array(Array, Array) (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 870)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 432)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 248)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 153)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 152)
Drupal\Core\Render\Renderer->renderRoot(Array) (Line: 56)
Drupal\doc_serialization\Plugin\views\display\WordExport::buildResponse('test_for_docx_export', 'word_export_1', Array) (Line: 56)
Drupal\views\Routing\ViewPageController->handle('test_for_docx_export', 'word_export_1', Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
🇦🇹Austria daniel.pernold

I figured out that the problem appears when you select no specific currency in the field settings. So the solution should be to filter the setting in the validator. Same applies to modifiers. Here's a patch.

🇦🇹Austria daniel.pernold

I created a patch for the issue tag "3289141-automated-drupal-10" which I am using.

🇦🇹Austria daniel.pernold

Ran into a major problem, since \Monolog\LogRecord::$level is a read-only property. We disable this setter for now to provide compatibility. Needs work.

🇦🇹Austria daniel.pernold

@hiralshah1991 I fixed your last problem directly in Keycloak without hacking core.

https://www.drupal.org/project/keycloak/issues/3396331 🐛 LogicException when redirecting to Keycloak Needs review

🇦🇹Austria daniel.pernold

Ran into another problem in the KeycloakController where the old setting is used. Here's the fix: 3382665-7-fix-config-enabled-flag.diff

🇦🇹Austria daniel.pernold

The problem here is the OPENID_CONNECT_CONFIG_NAME in combination with a missing enabled config as queried in KeycloakService::isEnabled(). I assume we have to change the implementation of KeycloakService::isEnabled() to query the status config property. See attached 3382665-fix-config-enabled-flag.diff.

🇦🇹Austria daniel.pernold

@hiralshah1991 Your problem is this one:
https://www.drupal.org/project/keycloak/issues/3391108 🐛 Error to built redirect URL RTBC

in combination with this one:
https://www.drupal.org/node/2638686

🇦🇹Austria daniel.pernold

Reroll latest patch for 2.x and checking if there is a entity to avoid null references for getEntityTypeId().

🇦🇹Austria daniel.pernold

Same problem here with Drupal 9.5.9. Patch #10 solved the problem.

🇦🇹Austria daniel.pernold

Same here, the problem also occurs when using CKEditor5 inside a paragraph overlay using layout_paragraphs module.

The same environment with the same settings inside a normal "article" (without additional modules) is working.

Production build 0.71.5 2024