- Issue created by @kingdutch
- π¬π§United Kingdom Rob230
We have the same problem when any module is enabled on the site - our deployments failed due to running out of memory. Disabling the admin_toolbar_tools module resolves the problem.
Our profiling found that having the admin_toolbar_tools module enabled means when a module is enabled, an extra 1.3 GB of memory is used and an extra 21 seconds of load time. Most of the memory is used by
admin_toolbar/admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks::getDerivativeDefinitions()
. - πΊπΈUnited States JonMcL Brooklyn, NY
I am also noticing a memory issue introduced by
admin_toolbar/admin_toolbar_tools/src/Plugin/Derivative/ExtraLinks::getDerivativeDefinitions()
I end up with over 400 items in $links. If I hack the code to exclude some entity types, and get the total count of $links down to around 300, all seems to work well. It doesn't appear to matter which entity types I exclude.
Strangely, we are most likely to trigger the issue one some node bundles' Manage Field page, but the issue doesn't trigger on other entity types' bundles.
Sorry, this is probably not very useful information.
Disabling the module, or returning an empty array from
::getDerivativeDefinitions()
does seem to not cause the issue to happen. - π¬π§United Kingdom peterjlord
Thanks for the great module. This is a goto module for me as it increases usability.
I'm to having performance issues. I think it's since upgrading to 10.3I've had to remove the module to restore my sites performance :(
- π¦πΉAustria daniel.pernold
My profiling has shown that it is mainly the access checks on the menu items that cause the problem in our projects. If we reduce the depth of the toolbar from 4 to 3, the performance increases significantly.
/admin/config/user-interface/admin-toolbar -> set 3 here
The time is spent here: https://git.drupalcode.org/project/admin_toolbar/-/blob/3.x/src/Render/E...
The same applies, of course, to the analogous implementation in the Gin Toolbar (and any other):
https://git.drupalcode.org/project/gin_toolbar/-/blob/8.x-1.x/src/Render...Generally, if you uninstall the module, there is a huge performance jump.
Module INSTALLED:
βModule UNINSTALLED:
β