Contrib.social

SubmitButton selector broken with Gin theme

Open on Drupal.org →
Created on 8 November 2023, about 1 year ago
Updated 9 November 2023, about 1 year ago

Problem

When using Gin Theme, the functionality is broken.

Analysis

The selectors for the button is bound to IDs like "edit-submit" etc as implemented here. The buttons in Gin implement different ids Like "edit-submit--2--gin-edit-form".

Proposed resolution

Use the "data-drupal-selector" attribute to select the buttons, which should work across themes. Here's an example of a button i came across.

<input data-drupal-selector="edit-submit" type="submit" id="edit-submit--2--gin-edit-form" name="op" value="Save (this translation)" class="button button--primary js-form-submit form-submit" form="node-product-edit-form">

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇹Austria daniel.pernold

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024