- last update
over 1 year ago Custom Commands Failed - Issue created by @somersoft
- last update
over 1 year ago 30,126 pass - Status changed to Needs work
over 1 year ago 1:51pm 4 May 2023 - ๐บ๐ธUnited States smustgrave
Issue summary should be updated with proposed solution. "Apply patch" doesn't count unfortunately.
Also as a bug it will need a test case
Moving version to 10.1 as 9.4 is only under security coverage.
- ๐ณ๐ฟNew Zealand luke.stewart
Summarised patch and added to the proposed solution. Removed the needs issue summary update.
- last update
about 1 year ago 29,678 pass - ๐ป๐ณVietnam phthlaap
phthlaap โ changed the visibility of the branch 3357973-grouped-exposed-taxonomy to hidden.
- ๐ป๐ณVietnam phthlaap
phthlaap โ changed the visibility of the branch 3357973-grouped-exposed-taxonomy to active.
- Status changed to Needs review
8 months ago 6:18pm 20 April 2024 - Status changed to RTBC
8 months ago 1:57pm 22 April 2024 - ๐บ๐ธUnited States smustgrave
Ran test-only feature and showed you do get the WSOD https://git.drupalcode.org/issue/drupal-3357973/-/jobs/1383399 removing that tag
Manually testing following the steps and confirmed the issue
Just FYI, not a problem, but don't need to include the code in the proposed solution. Explaining the solution usually work. Again not a problem if you do just mentioning.
LGTM
- Status changed to Needs work
8 months ago 6:06am 23 April 2024 - ๐ณ๐ฟNew Zealand quietone
So, we have updates to the issue summary. Thank you!
The test-only tests have been run and there has been manually tested. That is all great. But what is missing is a code review. I left some notes in the MR.
- ๐ฎ๐ณIndia pradhumanjainOSL
pradhumanjain2311 โ made their first commit to this issueโs fork.
- ๐บ๐ธUnited States weddled
I am having his issue with Drupal 10.2.5. Add a filter to a views and use taxonomy term select expose filter, grouped, allow multiples (vocabulary). Get the error: TypeError: Illegal offset type in isset or empty in Drupal\taxonomy\Plugin\views\filter\TaxonomyIndexTid->validateExposed() (line 349 of /opt/drupal/web/core/modules/taxonomy/src/Plugin/views/filter/TaxonomyIndexTid.php). Any updates on this?
- ๐ช๐ธSpain pcambra Asturies
I think this is affecting other filters that can be grouped
TypeError: trim(): Argument #1 ($string) must be of type string, array given in trim() (line 1683 of /var/www/html/docroot/core/modules/views/src/Plugin/views/filter/FilterPluginBase.php).
- ๐ช๐ธSpain pcambra Asturies
I'm seeing a lot of duplication for the same issue
- ๐ช๐ธSpain pcambra Asturies
I've removed the commit from #21 as this issue is already handled in ๐ Views' User Name exposed group filter validation Needs work
However, not sure which one is the best option to keep as this is dupe from ๐ Grouped exposed taxonomy filter fails validation for autocomplete widget Needs work