- Merge request !1473Resolve #2920039: Views user name exposed filter validation. → (Open) created by Matroskeen
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- 🇪🇸Spain pcambra Asturies
Damn, according to https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → , only the original creator of an MR can change the base branch :(
- 🇳🇱Netherlands Lendude Amsterdam
@pcambra I think everybody in maintainers.txt can change target branches in MRs now, so updated it to 11.x, but that still doesn't seem right looking at the changes. Is 11.x the correct branch to target?
- 🇪🇸Spain pcambra Asturies
I think this is what phpstan doesn't like but the parent doesn't have return type either, I think it should be :void but not sure if it needs to happen in this issue.
Line core/modules/user/src/Plugin/views/filter/Name.php ------ ---------------------------------------------------------------------- 169 Method Drupal\user\Plugin\views\filter\Name::buildExposedFiltersGroupForm() has no return type specified. The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
