- Issue created by @mizage@gmail.com
- ๐ฎ๐ณIndia sarwan
sarwan_verma โ made their first commit to this issueโs fork.
- @sarwan_verma opened merge request.
- Status changed to Needs review
8 months ago 8:20am 30 October 2023 - ๐ฎ๐ณIndia sarwan
Hi @mizage@gmail.com ,
I have fixed this issue "Primary keys missing" and also created MR,
kindly review the MR. - ๐ฎ๐ณIndia MukhtarM
I reviewed the MR. On the
publishing_options_bundles
table the better primary key option would on thepubid
as it does for thepublishing_options
table. Updated the MR, please review - ๐บ๐ธUnited States mizage@gmail.com
Thanks for the quick response! Do we need an update hook for existing installations?
- ๐ฎ๐ณIndia MukhtarM
Updated the MR with
hook_update
that tested locally. Note that if you applied https://git.drupalcode.org/project/pub_options/-/merge_requests/15/diffs... already, it wont have any effects. Or you have to revert it to the earlier and rundrush updb
. - ๐บ๐ธUnited States geocalleo
Hi and thanks for the update. I'll check the code and get it merged in once I'm done testing!
- ๐บ๐ธUnited States mizage@gmail.com
Thanks again for the quick response.
- ๐บ๐ธUnited States mizage@gmail.com
I'm seeing the following when applying the update:
[error] SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1' for key 'PRIMARY': ALTER TABLE "publishing_options_bundles" ADD PRIMARY KEY ("pubid"); Array
- @geocalleo opened merge request.
- @geocalleo opened merge request.
- ๐บ๐ธUnited States geocalleo
Hi @MukhtarM, I am trying to merge the updates you put in place. But it looks like the merge request is set for 2.x branch. Can you switch that over to 2.0.0 branch? I've been making release tags on that branch for the latest releases.
- @mukhtarm opened merge request.
- @mukhtarm opened merge request.
- ๐ฎ๐ณIndia MukhtarM
@geocalleo i raised against
2.0.0
now. First i tried to raise in the git UI itself (as there no code change), but it didn't worked. Thats why there is a intermediate MR :)