Contrib.social

Quick Edit could not associate the rendered entity field markup

Open on Drupal.org →
Created on 16 December 2019, about 5 years ago
Updated 24 January 2024, 11 months ago

Problem/Motivation

When media is inserted inline in the WYSIWYG it's impossible to inline edit it and browser console have :

Uncaught Error: Quick Edit could not associate the rendered entity field markup (with [data-quickedit-field-id="media/1/field_media_image/en/default"]) with the corresponding rendered entity markup: no parent DOM node found with [data-quickedit-entity-id="media/1"]. This is typically caused by the theme's template for this entity type forgetting to print the attributes.

coming from quickedit.js:180:13

Steps to reproduce

  1. Install Drupal from standard profile
  2. Install media and library
  3. Enable media library button for "Basic HTML", enable "Embed media" filter
  4. Create a basic page and insert media of the image type into body
  5. Save the page
  6. Check browser console

Proposed resolution

Fix.

Remaining tasks

  1. Patch
  2. Review
  3. Commit

User interface changes

None

API changes

None?

Data model changes

None?

Release notes snippet

TBD

Original report

After I added youtube video via Media in body I have error:

drupal.js?v=8.8.0:13 Uncaught Error: Quick Edit could not associate the rendered entity field markup (with [data-quickedit-field-id="media/1/field_media_oembed_video/ru/layout_builder-default-0-0c29f75e_13d0_444c_aefb_2c3b13f4fbe1-1-821bf6e4e7b3c8e5fe4cd1b8c9814931c07b28e62a0ce7bb3d6c817b05b2938b"]) with the corresponding rendered entity markup: no parent DOM node found with [data-quickedit-entity-id="media/1"]. This is typically caused by the theme's template for this entity type forgetting to print the attributes.
at processField (quickedit.js?v=8.8.0:181)
at HTMLDivElement. (quickedit.js?v=8.8.0:298)
at Function.each (jquery.min.js?v=3.4.1:2)
at k.fn.init.each (jquery.min.js?v=3.4.1:2)
at Object.attach (quickedit.js?v=8.8.0:297)
at drupal.js?v=8.8.0:25
at Array.forEach ()
at Object.Drupal.attachBehaviors (drupal.js?v=8.8.0:22)
at drupal.init.js?v=8.8.0:28
at HTMLDocument.listener (drupal.init.js?v=8.8.0:20)

The value in the body field:

<drupal-media data-align="center" data-entity-type="media" data-entity-uuid="93e995e5-cc9f-49d7-8121-9321207ee4d6"></drupal-media>

The rendered HTML of the field:

<div class="align-center">
    <div class="layout layout--onecol">
        <div class="layout__region layout__region--content">
            <section class="block block-layout-builder block-field-blockmediaremote-videofield-media-oembed-video clearfix">
                <div data-quickedit-field-id="media/1/field_media_oembed_video/ru/layout_builder-default-0-0c29f75e_13d0_444c_aefb_2c3b13f4fbe1-1-821bf6e4e7b3c8e5fe4cd1b8c9814931c07b28e62a0ce7bb3d6c817b05b2938b"
                     class="field--formatter-oembed field field--name-field-media-oembed-video field--type-string field--label-hidden field--item">
                    <iframe src="/media/oembed?url=https%3A//www.youtube.com/watch%3Fv%3DM_sUWFIo-m0&amp;max_width=0&amp;max_height=0&amp;hash=u7UUh_ENYKBtQigY1AFxxvq6wkT1PbHIGv4NbIQipaA"
                            frameborder="0" allowtransparency="" width="480"
                            height="270" class="media-oembed-content"
                            title="Корректировка показаний весов, обман весов, автомобильные весы"></iframe>
                </div>
            </section>
        </div>
    </div>
</div>

Patch #15 in Custom blocks break layout builder module - Quick Edit could not associate the rendered entity field markup 🐛 Custom blocks break layout builder module - Quick Edit could not associate the rendered entity field markup Needs work not helped.

Interesting that I don't use Layout builder for this view mode at all.

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇷🇸Serbia super_romeo Belgrade

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
    last update over 1 year ago
    52 pass, 31 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    52 pass, 31 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update over 1 year ago
    52 pass, 32 fail
  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
    last update over 1 year ago
    57 pass, 27 fail
  • Comment over 1 year ago →
    🇳🇱Netherlands basvredeling Amsterdam

    #62 adds the \Drupal\quickedit\Plugin\Filter\QuickEditMediaEmbed class, which extends \Drupal\media\Plugin\Filter\MediaEmbed. The parent class has full annotations, but the extension doesn't. There is no "type" specified nor inherited, which potentially leads to errors like:

    Warning: Undefined array key "type" in Drupal\filter\Plugin\FilterBase->getType()

    I've also attached the core/jquery lib to the build so that might fix the testing errors.

    The MediaEmbed class is marked @internal, which is another potential problem.

  • Comment over 1 year ago →
    System Message

    The last submitted patch, 65: 3101267-65.patch, failed testing. View results →

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇳🇱Netherlands basvredeling Amsterdam

    My patch in #65 potentially makes uninstalling contrib quickedit tricky when the media_embed plugin is enabled. The uninstaller might see quickedit as the filter plugin provider of media_embed and refuse to uninstall.
    When running drush pm:uninstall quickedit, you'll get a message like: quickedit: Provides a filter plugin that is in use in the following filter formats: <em class="placeholder">Full HTML</em>.

  • Comment 11 months ago →
    🇬🇧United Kingdom 2dareis2do

    I am experiencing the same or similar with version: '1.0.3' on node edit page

    e.g. Error: Quick Edit could not associate the rendered entity field markup (with [data-quickedit-field-id="media/63/field_media_image/en/default"]) with the corresponding rendered entity markup: no parent DOM node found with [data-quickedit-entity-id="media/63"]. This is typically caused by the theme's template for this entity type forgetting to print the attributes.

    I have tried changing theme to oliveiro but I am getting the same. Drupal 10.2.2

  • Comment 11 months ago →
    🇬🇧United Kingdom 2dareis2do

    After adding patch I also have a lot of errors in my console, albeit quickedit appears to working.

    This seems a likely culprit here:

    https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#erro...

  • Comment 11 months ago →
    🇬🇧United Kingdom 2dareis2do

    Ok I have tried running the tests locally with the patch. This is the output here:

    PHPUnit 9.6.16 by Sebastian Bergmann and contributors.

    Testing
    .........E..........SSS.SSS.SSS.SSS.SSS.SSS..SSSSSSEE.....EF.EEEE 65 / 86 ( 75%)
    .E.EEEEESEEE.EEEEEEEE 86 / 86 (100%)

    Time: 09:39.780, Memory: 190.00 MB

    There were 25 errors:

    1) Drupal\Tests\quickedit\Kernel\MediaEmbedFilterDisabledIntegrationsTest::testDisabledIntegrations
    Undefined array key "default_view_mode"

    /var/www/html/web/core/modules/media/src/Plugin/Filter/MediaEmbed.php:289
    /var/www/html/web/core/modules/media/tests/src/Kernel/MediaEmbedFilterTestBase.php:240
    /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php:627
    /var/www/html/web/core/modules/media/tests/src/Kernel/MediaEmbedFilterTestBase.php:245
    /var/www/html/web/core/modules/media/tests/src/Kernel/MediaEmbedFilterTestBase.php:182
    /var/www/html/web/modules/contrib/quickedit/tests/src/Kernel/MediaEmbedFilterDisabledIntegrationsTest.php:48
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    2) Drupal\Tests\quickedit\Functional\EditorIntegrationLoadingTest::testUsersWithoutPermission
    Behat\Mink\Exception\ExpectationException: The string "

    Do you also love Drupal?

    Druplicon" was not found anywhere in the HTML response of the current page.

    /var/www/html/vendor/behat/mink/src/WebAssert.php:888
    /var/www/html/vendor/behat/mink/src/WebAssert.php:363
    /var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:540
    /var/www/html/web/modules/contrib/quickedit/tests/src/Functional/EditorIntegrationLoadingTest.php:90
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    3) Drupal\Tests\quickedit\Functional\EditorIntegrationLoadingTest::testUserWithPermission
    Behat\Mink\Exception\ExpectationException: The string "

    Do you also love Drupal?

    Druplicon" was not found anywhere in the HTML response of the current page.

    /var/www/html/vendor/behat/mink/src/WebAssert.php:888
    /var/www/html/vendor/behat/mink/src/WebAssert.php:363
    /var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:540
    /var/www/html/web/modules/contrib/quickedit/tests/src/Functional/EditorIntegrationLoadingTest.php:128
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    4) Drupal\Tests\quickedit\Functional\LayoutBuilderQuickEditTest::testPlaceFieldBlockFromDifferentEntityType
    Behat\Mink\Exception\ElementNotFoundException: Link with id|title|alt|text "Add block" not found.

    /var/www/html/vendor/behat/mink/src/Element/TraversableElement.php:72
    /var/www/html/web/modules/contrib/quickedit/tests/src/Functional/LayoutBuilderQuickEditTest.php:62
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    5) Drupal\Tests\quickedit\Functional\CKEditor5\CKEditor5QuickEditLibraryTest::testQuickeditTemporaryWorkaround
    Behat\Mink\Exception\ExpectationException: The string "css/editors/formattedText/ckeditor5.workaround.css" was not found anywhere in the HTML response of the current page.

    /var/www/html/vendor/behat/mink/src/WebAssert.php:888
    /var/www/html/vendor/behat/mink/src/WebAssert.php:363
    /var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:540
    /var/www/html/web/modules/contrib/quickedit/tests/src/Functional/CKEditor5/CKEditor5QuickEditLibraryTest.php:89
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    6) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditLoadingTest::testUserPermissions
    WebDriver\Exception\JavaScriptError: javascript error: jQuery is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:893
    /var/www/html/vendor/behat/mink/src/Session.php:376
    /var/www/html/web/core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinkClickTrait.php:50
    /var/www/html/web/core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinkClickTrait.php:29
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php:157
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    7) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditLoadingTest::testWithPendingRevision
    Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Preview" not found.

    /var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:144
    /var/www/html/web/core/tests/Drupal/Tests/UiHelperTrait.php:78
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php:192
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    8) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditLoadingTest::testTitleBaseField
    WebDriver\Exception\JavaScriptError: javascript error: jQuery is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:893
    /var/www/html/vendor/behat/mink/src/Session.php:376
    /var/www/html/web/core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinkClickTrait.php:50
    /var/www/html/web/core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinkClickTrait.php:29
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php:229
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    9) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditLoadingTest::testConcurrentEdit
    WebDriver\Exception\JavaScriptError: javascript error: jQuery is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:893
    /var/www/html/vendor/behat/mink/src/Session.php:376
    /var/www/html/web/core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinkClickTrait.php:50
    /var/www/html/web/core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinkClickTrait.php:29
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php:294
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    10) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditLoadingTest::testImageField
    Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "files[field_image_0]" not found.

    /var/www/html/vendor/behat/mink/src/Element/TraversableElement.php:306
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditLoadingTest.php:376
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    11) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditFileTest::testRemove
    Error: Call to a member function getAttribute() on null

    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:60
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditFileTest.php:91
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    12) Drupal\Tests\quickedit\FunctionalJavascript\FieldTest::testFieldWithCkeditor
    Undefined array key "ckeditor"

    /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:125
    /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:476
    /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:559
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/FieldTest.php:40
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    13) Drupal\Tests\quickedit\FunctionalJavascript\CKEditor5IntegrationTest::testDiscard
    WebDriver\Exception\JavaScriptError: javascript error: Drupal is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:902
    /var/www/html/vendor/behat/mink/src/Session.php:388
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:206
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/CKEditor5IntegrationTest.php:129
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    14) Drupal\Tests\quickedit\FunctionalJavascript\CKEditor5IntegrationTest::testArticleNode
    WebDriver\Exception\JavaScriptError: javascript error: Drupal is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:902
    /var/www/html/vendor/behat/mink/src/Session.php:388
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:206
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/CKEditor5IntegrationTest.php:211
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    15) Drupal\Tests\quickedit\FunctionalJavascript\SettingsTrayIntegrationTest::testCustomBlockLinks
    WebDriver\Exception\JavaScriptError: javascript error: jQuery is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:893
    /var/www/html/vendor/behat/mink/src/Session.php:376
    /var/www/html/web/core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinkClickTrait.php:50
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/SettingsTrayIntegrationTest.php:152
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    16) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditImageTest::testImageInPlaceEditor with data set "with permission" (true)
    Behat\Mink\Exception\ElementNotFoundException: Element matching css "[data-quickedit-entity-id="node/1"] [data-quickedit-field-id="node/1/ttfevjxh/en/full"] img[src*="image-test.png"][alt="Hello world"]" not found.

    /var/www/html/vendor/behat/mink/src/WebAssert.php:465
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditImageTest.php:127
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    17) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditImageTest::testImageInPlaceEditor with data set "without permission" (false)
    Behat\Mink\Exception\ElementNotFoundException: Element matching css "[data-quickedit-entity-id="node/1"] [data-quickedit-field-id="node/1/zeriqb8q/en/full"] img[src*="image-test.png"][alt="Hello world"]" not found.

    /var/www/html/vendor/behat/mink/src/WebAssert.php:465
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditImageTest.php:127
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    18) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditAutocompleteTermTest::testAutocompleteQuickEdit
    Undefined array key "ckeditor"

    /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:125
    /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:476
    /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:559
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditAutocompleteTermTest.php:85
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    19) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderIntegrationTest::testArticleNode
    Undefined array key "ckeditor"

    /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:125
    /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:476
    /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:559
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php:50
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    20) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderIntegrationTest::testCustomBlock
    Undefined array key "ckeditor"

    /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:125
    /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:476
    /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:559
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php:50
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    21) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testQuickEditIgnoresDuplicateFields
    Behat\Mink\Exception\ElementNotFoundException: Link with id|title|alt|text "Add block" not found.

    /var/www/html/vendor/behat/mink/src/Element/TraversableElement.php:72
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:103
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    22) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder with data set "use revisions, not admin" (true)
    WebDriver\Exception\JavaScriptError: javascript error: Drupal is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:902
    /var/www/html/vendor/behat/mink/src/Session.php:388
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:206
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:339
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:159
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    23) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder with data set "do not use revisions, not admin" (false)
    WebDriver\Exception\JavaScriptError: javascript error: Drupal is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:902
    /var/www/html/vendor/behat/mink/src/Session.php:388
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:206
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:339
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:159
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    24) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder with data set "use revisions, admin" (true, true)
    WebDriver\Exception\JavaScriptError: javascript error: Drupal is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:902
    /var/www/html/vendor/behat/mink/src/Session.php:388
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:206
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:339
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:159
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    25) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder with data set "do not use revisions, admin" (false, true)
    WebDriver\Exception\JavaScriptError: javascript error: Drupal is not defined
    (Session info: headless chrome=106.0.5249.103)
    (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.15.49-linuxkit x86_64)

    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:169
    /var/www/html/vendor/instaclick/php-webdriver/lib/WebDriver/Session.php:455
    /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:902
    /var/www/html/vendor/behat/mink/src/Session.php:388
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:206
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:339
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:159
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    --

    There was 1 failure:

    1) Drupal\Tests\quickedit\Functional\QuickEditCustomPipelineTest::testCustomPipeline
    Failed asserting that 500 matches expected 200.

    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
    /var/www/html/web/modules/contrib/quickedit/tests/src/Functional/QuickEditCustomPipelineTest.php:63
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    ERRORS!
    Tests: 86, Assertions: 1361, Errors: 25, Failures: 1, Skipped: 25.

    Remaining self deprecation notices (46)

    11x: The Drupal\Tests\field\Traits\EntityReferenceTestTrait is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Instead, use \Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait. See https://www.drupal.org/node/3401941 →
    4x in LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder from Drupal\Tests\quickedit\FunctionalJavascript
    1x in KernelTestSuite::suite from Drupal\Tests\TestSuites
    1x in CKEditor5IntegrationTest::testDiscard from Drupal\Tests\quickedit\FunctionalJavascript
    1x in CKEditor5IntegrationTest::testArticleNode from Drupal\Tests\quickedit\FunctionalJavascript
    1x in QuickEditAutocompleteTermTest::testAutocompleteQuickEdit from Drupal\Tests\quickedit\FunctionalJavascript
    ...

    10x: The core/drupal.array.find asset library is deprecated in Drupal 10.0.0 and will be removed in Drupal 11.0.0. See https://www.drupal.org/node/3280410 →
    2x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional
    1x in EditorIntegrationLoadingTest::testUserWithPermission from Drupal\Tests\quickedit\Functional
    1x in QuickEditMinimalTest::testSuccessfulInstall from Drupal\Tests\quickedit\Functional
    1x in QuickEditImageControllerTest::testAccess from Drupal\Tests\quickedit\Functional
    ...

    10x: The core/es6-promise asset library is deprecated in Drupal 10.0.0 and will be removed in Drupal 11.0.0. See https://www.drupal.org/node/3280410 →
    2x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional
    1x in EditorIntegrationLoadingTest::testUserWithPermission from Drupal\Tests\quickedit\Functional
    1x in QuickEditMinimalTest::testSuccessfulInstall from Drupal\Tests\quickedit\Functional
    1x in QuickEditImageControllerTest::testAccess from Drupal\Tests\quickedit\Functional
    ...

    10x: The core/drupal.object.assign asset library is deprecated in Drupal 10.0.0 and will be removed in Drupal 11.0.0. See https://www.drupal.org/node/3280410 →
    2x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional
    1x in EditorIntegrationLoadingTest::testUserWithPermission from Drupal\Tests\quickedit\Functional
    1x in QuickEditMinimalTest::testSuccessfulInstall from Drupal\Tests\quickedit\Functional
    1x in QuickEditImageControllerTest::testAccess from Drupal\Tests\quickedit\Functional
    ...

    2x: Support for file validation function file_validate_image_resolution() is deprecated in drupal:10.2.0 and will be removed in drupal:11.0.0. Use Symfony Constraints instead. See https://www.drupal.org/node/3363700 →
    1x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    1x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional

    2x: file_validate_image_resolution() is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use the 'file.validator' service instead. See https://www.drupal.org/node/3363700 →
    1x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    1x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional

    1x: Installing the table sequences with the method KernelTestBase::installSchema() is deprecated in drupal:10.2.0 and is removed from drupal:12.0.0. See https://www.drupal.org/node/3349345 →
    1x in QuickEditLoadingTest::testDisplayOptions from Drupal\Tests\quickedit\Kernel

    Other deprecation notices (2)

    1x: The "PHPUnit\Framework\TestCase::__construct()" method is considered internal This method is not covered by the backward compatibility promise for PHPUnit. It may change without further notice. You should not extend it from "Drupal\Tests\printable\Unit\Plugin\PrintableFormat\PrintFormatTest".
    1x in DrupalListener::endTest from Drupal\Tests\Listeners

    1x: The "PHPUnit\Framework\TestCase::__construct()" method is considered internal This method is not covered by the backward compatibility promise for PHPUnit. It may change without further notice. You should not extend it from "Drupal\Tests\printable\Unit\Plugin\Block\PrintableLinkBlockTest".
    1x in DrupalListener::endTest from Drupal\Tests\Listeners

    I try and run without the patch

  • Comment 11 months ago →
    🇬🇧United Kingdom 2dareis2do

    Without the patch I get less errors but more failures

    /var/www/html/web$ ../vendor/bin/phpunit -c core --group quickedit
    PHPUnit 9.6.16 by Sebastian Bergmann and contributors.

    Testing
    ....................SSS.SSS.SSS.SSS.SSS.SSS..SSSSSSEE............ 65 / 86 ( 75%)
    .....E.FSF...EEE.FFFF 86 / 86 (100%)

    Time: 08:02.516, Memory: 190.00 MB

    There were 6 errors:

    1) Drupal\Tests\quickedit\Functional\EditorIntegrationLoadingTest::testUsersWithoutPermission
    Behat\Mink\Exception\ExpectationException: The string "

    Do you also love Drupal?

    Druplicon" was not found anywhere in the HTML response of the current page.

    /var/www/html/vendor/behat/mink/src/WebAssert.php:888
    /var/www/html/vendor/behat/mink/src/WebAssert.php:363
    /var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:540
    /var/www/html/web/modules/contrib/quickedit/tests/src/Functional/EditorIntegrationLoadingTest.php:90
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    2) Drupal\Tests\quickedit\Functional\EditorIntegrationLoadingTest::testUserWithPermission
    Behat\Mink\Exception\ExpectationException: The string "

    Do you also love Drupal?

    Druplicon" was not found anywhere in the HTML response of the current page.

    /var/www/html/vendor/behat/mink/src/WebAssert.php:888
    /var/www/html/vendor/behat/mink/src/WebAssert.php:363
    /var/www/html/web/core/tests/Drupal/Tests/WebAssert.php:540
    /var/www/html/web/modules/contrib/quickedit/tests/src/Functional/EditorIntegrationLoadingTest.php:128
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    3) Drupal\Tests\quickedit\FunctionalJavascript\FieldTest::testFieldWithCkeditor
    Undefined array key "ckeditor"

    /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:125
    /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:476
    /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:559
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/FieldTest.php:40
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    4) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditAutocompleteTermTest::testAutocompleteQuickEdit
    Undefined array key "ckeditor"

    /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:125
    /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:476
    /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:559
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditAutocompleteTermTest.php:85
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    5) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderIntegrationTest::testArticleNode
    Undefined array key "ckeditor"

    /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:125
    /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:476
    /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:559
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php:50
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    6) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderIntegrationTest::testCustomBlock
    Undefined array key "ckeditor"

    /var/www/html/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:125
    /var/www/html/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
    /var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:476
    /var/www/html/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:81
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:559
    /var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderIntegrationTest.php:50
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    --

    There were 6 failures:

    1) Drupal\Tests\quickedit\FunctionalJavascript\CKEditor5IntegrationTest::testArticleNode
    Field node/1/body/en/full did not match its expectation selector (.quickedit-field.quickedit-editable.quickedit-candidate.quickedit-highlighted.quickedit-editing.quickedit-changed)
    Failed asserting that a NULL is not empty.

    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:267
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:244
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/CKEditor5IntegrationTest.php:264
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    2) Drupal\Tests\quickedit\FunctionalJavascript\SettingsTrayIntegrationTest::testCustomBlockLinks
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -''
    +'/admin/structure/block/manage/custom/settings-tray?destination=/user/2'

    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:94
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/SettingsTrayIntegrationTest.php:161
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    3) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder with data set "use revisions, not admin" (true)
    Found Quick Edit-enabled field whose data-quickedit-field attribute starts with: node/1/body/en
    Failed asserting that a NULL is not empty.

    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:361
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:248
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:219
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:345
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:164
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    4) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder with data set "do not use revisions, not admin" (false)
    Found Quick Edit-enabled field whose data-quickedit-field attribute starts with: node/1/body/en
    Failed asserting that a NULL is not empty.

    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:361
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:248
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:219
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:345
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:164
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    5) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder with data set "use revisions, admin" (true, true)
    Found Quick Edit-enabled field whose data-quickedit-field attribute starts with: node/1/body/en
    Failed asserting that a NULL is not empty.

    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:361
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:248
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:219
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:345
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:164
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    6) Drupal\Tests\quickedit\FunctionalJavascript\LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder with data set "do not use revisions, admin" (false, true)
    Found Quick Edit-enabled field whose data-quickedit-field attribute starts with: node/1/body/en
    Failed asserting that a NULL is not empty.

    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
    /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:361
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:248
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:219
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:345
    /var/www/html/web/modules/contrib/quickedit/tests/src/FunctionalJavascript/LayoutBuilderQuickEditTest.php:164
    /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

    ERRORS!
    Tests: 86, Assertions: 1666, Errors: 6, Failures: 6, Skipped: 25.

    Remaining self deprecation notices (61)

    15x: The core/drupal.array.find asset library is deprecated in Drupal 10.0.0 and will be removed in Drupal 11.0.0. See https://www.drupal.org/node/3280410 →
    5x in LayoutBuilderQuickEditTest::testPlaceFieldBlockFromDifferentEntityType from Drupal\Tests\quickedit\Functional
    2x in EditorIntegrationLoadingTest::testUserWithPermission from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional
    1x in QuickEditMinimalTest::testSuccessfulInstall from Drupal\Tests\quickedit\Functional
    ...

    15x: The core/es6-promise asset library is deprecated in Drupal 10.0.0 and will be removed in Drupal 11.0.0. See https://www.drupal.org/node/3280410 →
    5x in LayoutBuilderQuickEditTest::testPlaceFieldBlockFromDifferentEntityType from Drupal\Tests\quickedit\Functional
    2x in EditorIntegrationLoadingTest::testUserWithPermission from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional
    1x in QuickEditMinimalTest::testSuccessfulInstall from Drupal\Tests\quickedit\Functional
    ...

    15x: The core/drupal.object.assign asset library is deprecated in Drupal 10.0.0 and will be removed in Drupal 11.0.0. See https://www.drupal.org/node/3280410 →
    5x in LayoutBuilderQuickEditTest::testPlaceFieldBlockFromDifferentEntityType from Drupal\Tests\quickedit\Functional
    2x in EditorIntegrationLoadingTest::testUserWithPermission from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    2x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional
    1x in QuickEditMinimalTest::testSuccessfulInstall from Drupal\Tests\quickedit\Functional
    ...

    11x: The Drupal\Tests\field\Traits\EntityReferenceTestTrait is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Instead, use \Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait. See https://www.drupal.org/node/3401941 →
    4x in LayoutBuilderQuickEditTest::testEnableDisableLayoutBuilder from Drupal\Tests\quickedit\FunctionalJavascript
    1x in KernelTestSuite::suite from Drupal\Tests\TestSuites
    1x in CKEditor5IntegrationTest::testDiscard from Drupal\Tests\quickedit\FunctionalJavascript
    1x in CKEditor5IntegrationTest::testArticleNode from Drupal\Tests\quickedit\FunctionalJavascript
    1x in QuickEditAutocompleteTermTest::testAutocompleteQuickEdit from Drupal\Tests\quickedit\FunctionalJavascript
    ...

    2x: Support for file validation function file_validate_image_resolution() is deprecated in drupal:10.2.0 and will be removed in drupal:11.0.0. Use Symfony Constraints instead. See https://www.drupal.org/node/3363700 →
    1x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    1x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional

    2x: file_validate_image_resolution() is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use the 'file.validator' service instead. See https://www.drupal.org/node/3363700 →
    1x in QuickEditImageControllerTest::testValidImageUpload from Drupal\Tests\quickedit\Functional
    1x in QuickEditImageControllerTest::testInvalidUpload from Drupal\Tests\quickedit\Functional

    1x: Installing the table sequences with the method KernelTestBase::installSchema() is deprecated in drupal:10.2.0 and is removed from drupal:12.0.0. See https://www.drupal.org/node/3349345 →
    1x in QuickEditLoadingTest::testDisplayOptions from Drupal\Tests\quickedit\Kernel

    Other deprecation notices (2)

    1x: The "PHPUnit\Framework\TestCase::__construct()" method is considered internal This method is not covered by the backward compatibility promise for PHPUnit. It may change without further notice. You should not extend it from "Drupal\Tests\printable\Unit\Plugin\PrintableFormat\PrintFormatTest".
    1x in DrupalListener::endTest from Drupal\Tests\Listeners

    1x: The "PHPUnit\Framework\TestCase::__construct()" method is considered internal This method is not covered by the backward compatibility promise for PHPUnit. It may change without further notice. You should not extend it from "Drupal\Tests\printable\Unit\Plugin\Block\PrintableLinkBlockTest".
    1x in DrupalListener::endTest from Drupal\Tests\Listeners

  • Comment 11 months ago →
    🇬🇧United Kingdom 2dareis2do

    I have tried reapplying the patch here and from what I can tell the behaviour is somewhat erratic. e.g. In Safari OS X, the quickedit functionality will work with this patch where media item is embedded.

    However, if I then manually refresh the browser page, it seems to be trying to instantiate ck editor again that seems to cause the issues.

    Not sure how this is managed as I thought refreshing the browser would clear any previous instantiated class or method. Perhaps it is being called twice on browser refresh although this does appear to be using once functionality.

    screen shots uploaded for both states

  • Comment 11 months ago →
    🇬🇧United Kingdom 2dareis2do

    Ok I have enabled prod with css aggregation enabled. This patch seems to be working fine for me so far.

  • Comment 11 months ago →
    🇬🇧United Kingdom 2dareis2do

    With regards the message:

    Reduce the number of dependencies that need to be synchronized to avoid the ckeditor-duplicated-moduleserror.

    Is also mentioned here.

    https://github.com/ckeditor/ckeditor5/issues/15502

    Issue seems to go away for me once css and js aggregation is enabled on prod.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024